Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <ee30eaa0-2a1f-4dc6-8e03-c2d993eb159a@intel.com>
Date:   Tue, 21 Nov 2023 15:48:15 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next PATCH v3 2/2] octeontx2-pf: TC flower offload support
 for mirror
Content-Language: en-US
To:     Suman Ghosh <sumang@marvell.com>, <sgoutham@marvell.com>,
        <gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lcherian@marvell.com>,
        <jerinj@marvell.com>, <horms@kernel.org>
References: <20231121094346.3621236-1-sumang@marvell.com>
 <20231121094346.3621236-3-sumang@marvell.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231121094346.3621236-3-sumang@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUI4WGRnM01LU1d5NjM5MnJNQ3hVTGIzMmQxOGY2RmIxY0FwZk9HaHVUYzJu?=
 =?utf-8?B?bFA2TDgrSFdzUnRYMHVpdHJqYlRkWVdvRzZIL25qdzA4WGpQUmtIOVM0Z1ZH?=
 =?utf-8?B?WjFVUjErNGl3TG05cHAvK3dQSXI5U1dGRXBpcWhRUzlWdFZNZ0tTblJXckda?=
 =?utf-8?B?VkFkajl2b3BrRzE3NDFmRnQyYUxrTE9zTVZlR1BQMDJCQ21EY0lBbHNwanBv?=
 =?utf-8?B?ejZOaEJkQ3hrRTVYRmt1UXZReUJKY1V6aWdJWnUrSVNhRllxQUdBTXlLNStY?=
 =?utf-8?B?S1A5VS95Z3g0T095U3dGbnMxQ2lGNlllUENQc0owVE9BemJRM0FVekxybnVn?=
 =?utf-8?B?WExuTzg1NnBvMmVIbGF0WlpkOTVEaEZKOGsrR01xajJsOHNtSHMreGR2YkFy?=
 =?utf-8?B?UlFLS3BORVIwKzhlbmtjNDFyZ1lLZStvbnlSbzAwdSt4R3Q3MU8xV1BOM1gz?=
 =?utf-8?B?Ty9FUVBJMEJ4UGo0dzY3c1pWY1J4d201Q2h2N2hHUTRDZ3dJcmJNZ3EyS2pp?=
 =?utf-8?B?aGwwNHVxQXZRcU9PYlFXY0k2bXlMNFRtbzNvd1BTQWUwckRlZzlYVTZpME9I?=
 =?utf-8?B?ZW1VQXV1WlMzUzVMaVNkbC9ET3lFV2RvaVhRcVdnZzlWUlF5dW8wQUtZaWNn?=
 =?utf-8?B?WGxlYnVWUkI1SFVuUmhtMEFsQ1FYaXZoZDRscnVtcTkzRmcvbFZwZWZtQTNN?=
 =?utf-8?B?T0xVM1FwcDJMeGNGdGZUN3JmRWZoWTZTVEtMQUNVeUVOOVdMMXpsSEhmd0pw?=
 =?utf-8?B?L0NYUmlrTTU2cGxENStnMFIxT0VnVVExam90blplbGlrYTNrTDdzQXF1K1kz?=
 =?utf-8?B?Ukpqa2oxKzEyUUhIVmZXaFpOQXMwbitKU1dBQ2NGU3NlM3ptV0RKK3VVRlVt?=
 =?utf-8?B?K01MWi9JMytiU1ZGTkRqL1BQZ0VGaHBWOXFlcnFlWVBrVFFzZTVxdDJ0Umha?=
 =?utf-8?B?QTRHZUJJcHIwb0pweVlxdXVqUU0yMHYrTHJXcTdlK04zQ3BlaTkzNDB0ZTdU?=
 =?utf-8?B?RGdHTlhVSmlpZEpFZndUZlgrYlZNc0QvTE9LZWhGRXBYbFNtOSttazNnYlhT?=
 =?utf-8?B?ZmdLbjMvd2xINkdkcmVoV0dQcWhQQXZVZDBFL2tuV3JWcFpoTEF1RU1RMHhL?=
 =?utf-8?B?bk1uSXRDSXk3cWxiM29PLzFpQTcxUTZNNmV6bHFHYWIxdXYySFh2VjhSNytO?=
 =?utf-8?B?UWh1Yk96c1FMTmZ4TDh0MU05eXJKQWhNWVdMRVgyNDVqSC93UlVjSkg2TlAw?=
 =?utf-8?B?TXB1ZG1VOFR4Q1Ryd2JwVmhzMTRObEptSTNxQWRlMzlpeUhISzF4VytzZjIv?=
 =?utf-8?B?aitpaTRuK01EK0llZnEvZXhFRUdtYlVoN0ljTmtnUndOdmFWY3p2VG40dTZz?=
 =?utf-8?B?Z3E2QWtIMVorOWNPUlUwdGR5L3pSelAyOGRnK3dqZzk5L25BcHg3OEtSVndZ?=
 =?utf-8?B?dndTWDlEU3BWUjQ5cnpqSHZ6SDlHUml4L1dUbmY3Sk8yUTU2d3FaTlNCYk9I?=
 =?utf-8?B?T0ZrclBwNzFDNDJMUU9mQm1TOGZOaTVWS0ZVZU81VFhDMm1XMUtOZnhrcG1u?=
 =?utf-8?B?eWdGSWg5QWltWXpCWDBxS1g0alJlSkNnb3dzanMrcGJsNG5kNnQ3M3hVNkZK?=
 =?utf-8?B?RUlxOWRHOUFxbFlLU0hVWnA0MHR1dldkTFREMktsV0JNb205Y1NSbGp1L0Ro?=
 =?utf-8?B?MnYvaUE4dkYxdURXOTFwcGwvZzR6aWZPOXFkd3hzZzlnTW5ib1BVb3NvMklo?=
 =?utf-8?B?cUVJUzRPRUQzMjV3SFEyK2xNemxUWC9qSlZmRld6dEhpUHdMS0ZiRDRCRXZ2?=
 =?utf-8?B?Tm8rMFAwVTY1UWxuOVRkdjN5b2FoUzF0b0xibVhGaW9EcGdQSlpKZlVGaVBP?=
 =?utf-8?B?cmI5NklJUkFoYnU4WEJJY0QrRnZselJhcThDU1lMa3M1Zzg5cVRQRHlwMVRY?=
 =?utf-8?B?c0xqc1I2aUJNTkRDcGZ2Zm5wYWZuVTEzc25pOHl1MnFzb044WVBIZjZmR0hk?=
 =?utf-8?B?dWFXZ1M4LzI2d0hRMHgyNVNxZmJMUzlDdHN6WFg5bE03dmV3RzMwUG9WU2Jr?=
 =?utf-8?B?VzBEQUo2b0ViNHJmU3JXOERWUFgxWnF5OEdSVHVPY0VKSG92OUNHRGlEdkJ5?=
 =?utf-8?B?cVFCelNxc2ZDYnR1OVJobU1Ndm1QYmZndERwTHh2U3JkVjVNaWVJVjg1cmJn?=
 =?utf-8?B?a0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f705f2c6-2e59-4b49-9638-08dbeaa0e854
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 14:48:21.8954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3KOhuuWuhuYGX9QL8GFT5J9JbdB9wWwmtV5PCn7C/dFRuroBfc5IKZQwjodQljX+2bnpl3vrz3QnX1x2XAT4+NK64qEbe1dW7mkF6r7alZo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6696
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 06:48:41 -0800 (PST)


On 21.11.2023 10:43, Suman Ghosh wrote:
> This patch extends TC flower offload support for mirroring
> ingress/egress traffic to a different PF/VF. Below is an example
> command,
> 
> 'tc filter add dev eth1 ingress protocol ip flower src_ip <ip-addr>
> skip_sw action mirred ingress mirror dev eth2'
> 
> Signed-off-by: Suman Ghosh <sumang@marvell.com>

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

> ---
>  .../ethernet/marvell/octeontx2/nic/otx2_tc.c  | 113 +++++++++++++++++-
>  1 file changed, 110 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> index 8a5e3987a482..17a8d9778193 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> @@ -29,6 +29,8 @@
>  
>  #define OTX2_UNSUPP_LSE_DEPTH		GENMASK(6, 4)
>  
> +#define MCAST_INVALID_GRP		(-1U)
> +
>  struct otx2_tc_flow_stats {
>  	u64 bytes;
>  	u64 pkts;
> @@ -47,6 +49,7 @@ struct otx2_tc_flow {
>  	bool				is_act_police;
>  	u32				prio;
>  	struct npc_install_flow_req	req;
> +	u32				mcast_grp_idx;
>  };
>  
>  static void otx2_get_egress_burst_cfg(struct otx2_nic *nic, u32 burst,
> @@ -336,22 +339,96 @@ static int otx2_tc_act_set_police(struct otx2_nic *nic,
>  	return rc;
>  }
>  
> +static int otx2_tc_update_mcast(struct otx2_nic *nic,
> +				struct npc_install_flow_req *req,
> +				struct netlink_ext_ack *extack,
> +				struct otx2_tc_flow *node,
> +				struct nix_mcast_grp_update_req *ureq,
> +				u8 num_intf)
> +{
> +	struct nix_mcast_grp_update_req *grp_update_req;
> +	struct nix_mcast_grp_create_req *creq;
> +	struct nix_mcast_grp_create_rsp *crsp;
> +	u32 grp_index;
> +	int rc;
> +
> +	mutex_lock(&nic->mbox.lock);
> +	creq = otx2_mbox_alloc_msg_nix_mcast_grp_create(&nic->mbox);
> +	if (!creq) {
> +		rc = -ENOMEM;
> +		goto error;
> +	}
> +
> +	creq->dir = NIX_MCAST_INGRESS;
> +	/* Send message to AF */
> +	rc = otx2_sync_mbox_msg(&nic->mbox);
> +	if (rc) {
> +		NL_SET_ERR_MSG_MOD(extack, "Failed to create multicast group");
> +		goto error;
> +	}
> +
> +	crsp = (struct nix_mcast_grp_create_rsp *)otx2_mbox_get_rsp(&nic->mbox.mbox,
> +			0,
> +			&creq->hdr);
> +	if (IS_ERR(crsp)) {
> +		rc = PTR_ERR(crsp);
> +		goto error;
> +	}
> +
> +	grp_index = crsp->mcast_grp_idx;
> +	grp_update_req = otx2_mbox_alloc_msg_nix_mcast_grp_update(&nic->mbox);
> +	if (!grp_update_req) {
> +		NL_SET_ERR_MSG_MOD(extack, "Failed to update multicast group");
> +		rc = -ENOMEM;
> +		goto error;
> +	}
> +
> +	ureq->op = NIX_MCAST_OP_ADD_ENTRY;
> +	ureq->mcast_grp_idx = grp_index;
> +	ureq->num_mce_entry = num_intf;
> +	ureq->pcifunc[0] = nic->pcifunc;
> +	ureq->channel[0] = nic->hw.tx_chan_base;
> +
> +	ureq->dest_type[0] = NIX_RX_RSS;
> +	ureq->rq_rss_index[0] = 0;
> +	memcpy(&ureq->hdr, &grp_update_req->hdr, sizeof(struct mbox_msghdr));
> +	memcpy(grp_update_req, ureq, sizeof(struct nix_mcast_grp_update_req));
> +
> +	/* Send message to AF */
> +	rc = otx2_sync_mbox_msg(&nic->mbox);
> +	if (rc) {
> +		NL_SET_ERR_MSG_MOD(extack, "Failed to update multicast group");
> +		goto error;
> +	}
> +
> +	mutex_unlock(&nic->mbox.lock);
> +	req->op = NIX_RX_ACTIONOP_MCAST;
> +	req->index = grp_index;
> +	node->mcast_grp_idx = grp_index;
> +	return 0;
> +
> +error:
> +	mutex_unlock(&nic->mbox.lock);
> +	return rc;
> +}
> +
>  static int otx2_tc_parse_actions(struct otx2_nic *nic,
>  				 struct flow_action *flow_action,
>  				 struct npc_install_flow_req *req,
>  				 struct flow_cls_offload *f,
>  				 struct otx2_tc_flow *node)
>  {
> +	struct nix_mcast_grp_update_req dummy_grp_update_req = { 0 };
>  	struct netlink_ext_ack *extack = f->common.extack;
> +	bool pps = false, mcast = false;
>  	struct flow_action_entry *act;
>  	struct net_device *target;
>  	struct otx2_nic *priv;
>  	u32 burst, mark = 0;
>  	u8 nr_police = 0;
> -	bool pps = false;
> +	u8 num_intf = 1;
> +	int err, i;
>  	u64 rate;
> -	int err;
> -	int i;
>  
>  	if (!flow_action_has_entries(flow_action)) {
>  		NL_SET_ERR_MSG_MOD(extack, "no tc actions specified");
> @@ -423,11 +500,30 @@ static int otx2_tc_parse_actions(struct otx2_nic *nic,
>  			req->index = act->rx_queue;
>  			break;
>  
> +		case FLOW_ACTION_MIRRED_INGRESS:
> +			target = act->dev;
> +			priv = netdev_priv(target);
> +			dummy_grp_update_req.pcifunc[num_intf] = priv->pcifunc;
> +			dummy_grp_update_req.channel[num_intf] = priv->hw.tx_chan_base;
> +			dummy_grp_update_req.dest_type[num_intf] = NIX_RX_RSS;
> +			dummy_grp_update_req.rq_rss_index[num_intf] = 0;
> +			mcast = true;
> +			num_intf++;
> +			break;
> +
>  		default:
>  			return -EOPNOTSUPP;
>  		}
>  	}
>  
> +	if (mcast) {
> +		err = otx2_tc_update_mcast(nic, req, extack, node,
> +					   &dummy_grp_update_req,
> +					   num_intf);
> +		if (err)
> +			return err;
> +	}
> +
>  	if (nr_police > 1) {
>  		NL_SET_ERR_MSG_MOD(extack,
>  				   "rate limit police offload requires a single action");
> @@ -1033,6 +1129,7 @@ static int otx2_tc_del_flow(struct otx2_nic *nic,
>  			    struct flow_cls_offload *tc_flow_cmd)
>  {
>  	struct otx2_flow_config *flow_cfg = nic->flow_cfg;
> +	struct nix_mcast_grp_destroy_req *grp_destroy_req;
>  	struct otx2_tc_flow *flow_node;
>  	int err;
>  
> @@ -1064,6 +1161,15 @@ static int otx2_tc_del_flow(struct otx2_nic *nic,
>  		mutex_unlock(&nic->mbox.lock);
>  	}
>  
> +	/* Remove the multicast/mirror related nodes */
> +	if (flow_node->mcast_grp_idx != MCAST_INVALID_GRP) {
> +		mutex_lock(&nic->mbox.lock);
> +		grp_destroy_req = otx2_mbox_alloc_msg_nix_mcast_grp_destroy(&nic->mbox);
> +		grp_destroy_req->mcast_grp_idx = flow_node->mcast_grp_idx;
> +		otx2_sync_mbox_msg(&nic->mbox);
> +		mutex_unlock(&nic->mbox.lock);
> +	}
> +
>  	otx2_del_mcam_flow_entry(nic, flow_node->entry, NULL);
>  	otx2_tc_update_mcam_table(nic, flow_cfg, flow_node, false);
>  	kfree_rcu(flow_node, rcu);
> @@ -1096,6 +1202,7 @@ static int otx2_tc_add_flow(struct otx2_nic *nic,
>  	spin_lock_init(&new_node->lock);
>  	new_node->cookie = tc_flow_cmd->cookie;
>  	new_node->prio = tc_flow_cmd->common.prio;
> +	new_node->mcast_grp_idx = MCAST_INVALID_GRP;
>  
>  	memset(&dummy, 0, sizeof(struct npc_install_flow_req));
>