Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Tue, 21 Nov 2023 14:58:55 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Akash Kumar <quic_akakum@quicinc.com>
Cc:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Jing Leng <jleng@ambarella.com>,
        Felipe Balbi <balbi@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Pratham =?iso-8859-1?Q?Pratap=A0?= <quic_ppratap@quicinc.com>,
        Jack Pham <quic_jackp@quicinc.com>,
        Wesley Cheng <quic_wcheng@quicinc.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: uvc: Add framebased frame format support
Message-ID: <2023112123-setting-waking-7896@gregkh>
References: <20231114112516.2723-1-quic_akakum@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231114112516.2723-1-quic_akakum@quicinc.com>
Precedence: bulk

On Tue, Nov 14, 2023 at 04:55:16PM +0530, Akash Kumar wrote:
> Add support for framebased frame format which can be used to support
> multiple formats like H264 or H265 other than mjpeg and YUV frames.
> 
> Framebased format is set to H264 by default, which can be updated to
> other formats by updating the GUID through guid configfs attribute.
> 
> Also,add UVC 1.5 extension to support H264 format and different camera
> controls, adding support for Exposure, Zoom, Pan, tilt.

When you say "also" or list different things that are done in a single
change, that's a huge hint to divide this up into smaller patches and
make it a patch series.

Please do that here.

thanks,

greg k-h