Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231116211739.3228239-1-robh@kernel.org> <ee10e67b-6a2f-4ab5-91ef-e42d2f03a424@linaro.org>
In-Reply-To: <ee10e67b-6a2f-4ab5-91ef-e42d2f03a424@linaro.org>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 21 Nov 2023 07:58:12 -0700
Message-ID: <CAL_JsqJ67tZOmhTHQ7KqEbFuDjK8sKHR1FFtAFAaGjZ4uYi9Uw@mail.gmail.com>
Subject: Re: [PATCH] arm/arm64: samsung: Enable W=1 on dtbs by default
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Alim Akhtar <alim.akhtar@samsung.com>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Nov 17, 2023 at 3:19=E2=80=AFAM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 16/11/2023 22:17, Rob Herring wrote:
> > Samsung platforms are clean of W=3D1 dtc warnings, so enable the warnin=
gs
> > by default. This way submitters don't have to remember to run a W=3D1
> > build of the .dts files and the grumpiness of the maintainers can be
> > reduced.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Well, there's a couple of warnings on 32-bit, but they look fixable to
> > me.
> >
> > There's a few other platforms we could do this to. Sadly, they are stil=
l
> > the minority. Otherwise, we could change the default and add a flag to
> > disable (I_STILL_HAVENT_FIXED_MY_PLATFORMS=3D1).
>
> 64-bit has still few warnings:
> https://krzk.eu/#/builders/29/builds/3710/steps/26/logs/warnings__6_

I may move that graph check to W=3D2. There's some cases where port@1 is
optional and it doesn't really make sense to fix these.

Also, Conor wants to do this for all of riscv, but this solution is
per directory. So I need to rework it to use a different variable that
can be per directory or global.

Rob