Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp446613rdf; Tue, 21 Nov 2023 07:04:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2eDrUrBvL0hNUq2nd+2Lio++UpuFa2msmAKEP/bPN0UOTz+KzKcf+IJKs7Toe2hrPf0rj X-Received: by 2002:a17:90a:3ee2:b0:27d:2108:af18 with SMTP id k89-20020a17090a3ee200b0027d2108af18mr11444500pjc.25.1700579052461; Tue, 21 Nov 2023 07:04:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700579052; cv=none; d=google.com; s=arc-20160816; b=0a8YXSFgCM/KCHey+ic0MAzNIhhQ1ohSG//T6O+wbSPuQaLUzYacfpyeh+/AYYfUaZ qNq449DKpSz13/Ln2tx+lptGcfZzESBG3OcWNFNoGtYArdwJSnuODd9XIr9sgn83V7WW 7/08UqjiG1H0lTmd74srRRKKtirmbowLnhmTFjS+T1F3HJt+qsPvjK+Qkrw4A6PqNKTW ZwV0wLZdCSHPhWaWe7dyuXPdd0ifm6e9GkEAXlqJ+G8zGc48uX99rzqABXfJyUM9gP7g +ZezcBk4ZaWweCP0WbZR71RIOPyYC3jnus+PJXPDQqIb5cLlVHhS8IghYgigy4fjRmSk DJYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z618n/+nO2NWSHgyjYhU4wR7YqrtQPc6DUiog3IwsYg=; fh=WeSgq64Y7bt/tzQCXSy8/S7KE0e/r9T7exuKyMQvDoY=; b=aSn+JwKTC2+cTwlIWI2+9FeE4jrBF7XARt2Rr7HHXF/cef2oAOzd+wln9fKX9MwCjd KdF2S9R88/zcXujgeXLvMZN8w0VdLatrLp2W4RigyklMBwwkrVKyXz+s8ogOqoOxlk1A 17b+uMoIZnMQn4kKbjRxtBVzGiklZYpG+da8nhmmLIFJZNh1oAipotnTEKfi1Udh2ec7 KKTr+ZYy2RMQkR0NIJO2xpSrHGWkC8h8bXOwtb4PDZqQ3bNCfG03I3LMFN/8TL0fuYwS Y9dEBabuakUOZ6PEIUNsZ4o0wFLX3zDFQGxbpEtBgOlbXs1dW1IE6f5m0h2dZaBcaFDz 8Z0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oGnUEJcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id w2-20020a17090abc0200b00280468bfb94si6714209pjr.185.2023.11.21.07.04.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 07:04:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oGnUEJcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 74751804AD14; Tue, 21 Nov 2023 07:04:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234825AbjKUPD4 (ORCPT + 99 others); Tue, 21 Nov 2023 10:03:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234521AbjKUPDz (ORCPT ); Tue, 21 Nov 2023 10:03:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABCEAD1 for ; Tue, 21 Nov 2023 07:03:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47AD6C433C8; Tue, 21 Nov 2023 15:03:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700579031; bh=ybjDzxPZW5g+QhZul9Du8UCGPjKVYHmIO/KEc0Aw7YQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oGnUEJcGjCJUadWNW4WUkZSR3cMzcCee54zegnUDA8ilcTUNmGunCdv+Q9IDr4+Mw iACpM2DWBIvBGGHfC//8xFf0Mqq7wLY198e8tWfMB5VxPqYg3iKKmGqjWDAmDm+R+A JJs27it0sDCvJQJ6EWHm1gdt3kX2qCkXB4SWd06ox8GubkZ1FMC0/hqK1ttsjVLnUZ ki975Q/Qp7qFubmCb3G4lLk4jUogBtOezEN0QV0+IDrXwfNDUlFs9B8axkBpN+Nb8u 4pAK3DJLq+/1sUwFzqnvDTf/JwilcTCFwrJwSP1ZFzbNRPC4w7yVApZpPRmr6ujn3l cHVxaXqno7+mg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1r5SIF-0007xS-2C; Tue, 21 Nov 2023 16:04:03 +0100 Date: Tue, 21 Nov 2023 16:04:03 +0100 From: Johan Hovold To: Greg Kroah-Hartman Cc: Andrew Halaney , Konrad Dybcio , Johan Hovold , Andy Gross , Bjorn Andersson , Thinh Nguyen , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] USB: dwc3: qcom: fix resource leaks on probe deferral Message-ID: References: <20231117173650.21161-1-johan+linaro@kernel.org> <041f239f-7b40-4681-8c6c-2268f9c2c684@linaro.org> <74cswe5tivcctmnty3gfavzsxdvjz5m4rktyj5auzwvrndninm@dah4h2fdj3zv> <2023112124-duckling-absinthe-2167@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023112124-duckling-absinthe-2167@gregkh> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 21 Nov 2023 07:04:03 -0800 (PST) On Tue, Nov 21, 2023 at 03:21:34PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 20, 2023 at 05:53:10PM +0100, Johan Hovold wrote: > > On Mon, Nov 20, 2023 at 09:22:54AM -0600, Andrew Halaney wrote: > > > On Sat, Nov 18, 2023 at 12:47:30AM +0100, Konrad Dybcio wrote: > > > > On 17.11.2023 18:36, Johan Hovold wrote: > > > > > When reviewing the recently submitted series which reworks the dwc3 qcom > > > > > glue implementation [1], I noticed that the driver's tear down handling > > > > > is currently broken, something which can lead to memory leaks and > > > > > potentially use-after-free issues on probe deferral and on driver > > > > > unbind. > > > > > > > > > > Let's get this sorted before reworking driver. > > > > > > > > > > Note that the last patch has only been compile tested as I don't have > > > > > access to a sdm845 device. > > > > > > I'll sound like a broken record, but: > > > > > > > > is there anyone in the world that is actively benefiting from this failed > > > > experiment of using the ACPI tables that were shipped with these SoCs? > > I agree that if we can remove the ACPI hacks in here, we should try do > > so (e.g. given that no one really uses it anymore). > > > > As Andrew already mentioned, that is a separate issue not directly > > related to this series, though. > > > > Removing it before reworking the dwc3 binding [1] and adding multiport > > support [2] should simplify both of those series quite a bit, however. > > [1] https://lore.kernel.org/all/20231016-dwc3-refactor-v1-0-ab4a84165470@quicinc.com/ > > [2] https://lore.kernel.org/all/20231007154806.605-1-quic_kriskura@quicinc.com/ > > > > So should I apply this series now or not? Please do. Removing ACPI support should be done later if that's at all possible. Johan