Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Nick Terrell <terrelln@meta.com>
To:     Ben Dooks <ben.dooks@codethink.co.uk>
CC:     Nick Terrell <terrelln@meta.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Nick Terrell <terrelln@meta.com>
Subject: Re: [PATCH] zstd: fix g_debuglevel export warning
Thread-Topic: [PATCH] zstd: fix g_debuglevel export warning
Thread-Index: AQHZoGECYFJRnoBdN0Sz99kqw9AI77CF1roA
Date:   Tue, 21 Nov 2023 15:02:38 +0000
Message-ID: <C5610F2F-F115-49F4-851D-A8A2CB669296@meta.com>
References: <20230616144400.172683-1-ben.dooks@codethink.co.uk>
In-Reply-To: <20230616144400.172683-1-ben.dooks@codethink.co.uk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Qy90dEE1Wk9zNFZOdzd3ZnFGRG5zUzNaZEdITVo2NWRUcmpOakZ1eXFROFVD?=
 =?utf-8?B?YTM0V1hCUlN3UC9remlYdVY4aHFHWUY0NHo3MG02R0I1eTNSejNrNUZOUk4z?=
 =?utf-8?B?KzZ2UjhOV3NNRUZEeW00T0U3YVp4TzhIL2NBaVZ6WTJRVXpyemRvTUZYWUMw?=
 =?utf-8?B?U1NSV1p2bERrcmlXNjBiTVVDWnIvRW1NNnR1MWtKb2oxajcwRit3aXk0SFM3?=
 =?utf-8?B?SEkxUnlMbFkxbG0vU252cjdZV1FYbWVvc3ZIdHpOZzF2eFZac1IvNnFNcFRi?=
 =?utf-8?B?YzZWeTJjVWZGV0o5UnVXY01XOHlSM0tlL2hxUE5oak0vZlBWQUJIM1luS1B5?=
 =?utf-8?B?LzA4MjNOQVRBZkZXYmZ5QkNib1Q3S3pNVzZNWTA1d1VYVXJxWVowczFNWUx1?=
 =?utf-8?B?eFRQZStrR1NsSWNPN0pUbDlUT3h0L2ttRWZyMTR5V25kYjZBOTVLK2RRL3dH?=
 =?utf-8?B?cVNDYnhNZGp6Q3VzWDhlZUEwQ1FJakxKWnEySmJyMWxBVnl1SFpvZ1hZM1R1?=
 =?utf-8?B?YXBsMmJxZ0hBdi9rQUNqQ2U4SW4zMTk2V3l4UGY1YlNGVzNOMUhiMys0dlFy?=
 =?utf-8?B?Z3hpN3NoU0ZuNW9ubmx1QUI1b1YrT3MybVFOWnlObkhCcUZpNG1DUjBwblIv?=
 =?utf-8?B?YUVpRzdFWDFuNTdsaEZPL3BMcCs3SmNkQVh0Q2FjcHRSMEw3YWQvVEYyT3F6?=
 =?utf-8?B?NEZWS2ZuTWlWSjNZNWh3eENwS1NCT1grQko5RjRUZDJJZnFiQTV0QlFyVHpr?=
 =?utf-8?B?QThKbFJOT1ArQ2orakY3T0ozQTRLMFNFejd2TEJIWnA4eUpMZGFGVjVxWTJo?=
 =?utf-8?B?TFc4VUVjNDdkRFZ1WlpCYUtjMGpaTTNaVmsxV3gxU3dOdnhSZGIvSlByVWkv?=
 =?utf-8?B?QlZERVpob0dxSW85OTkxbDYraGRFKzF5b052OHpNWVNHNXZFVXFFaEdVbGVr?=
 =?utf-8?B?T1RZaTlCZkZrRTVETDhFN3ZTMVk1bTVONytGdFg3Wm03b0IzQVNQS0RCTUY0?=
 =?utf-8?B?ZHcvdDlHMCs5L2YzZGlqOW9rdjU3UUJNWGlmcENBK3RzT09IR0YyQXFUaTBW?=
 =?utf-8?B?b2pFdGllY1NLb0JZcGtlNnhaTFErQ0pCeGpOYUlDVEQ2a2ZNOGZOS0ZIZTZt?=
 =?utf-8?B?bFB2Qk1XNDB5TTBrOTZIbVl1MENMdCtuamIrdDJ5RVVzVTlZQllZdmJXTGdI?=
 =?utf-8?B?ZFA0S1FsS2hya3F0MCsyYTRkZW52S05iVjhMZ1crYVpjeGg5blh1Zkhud1No?=
 =?utf-8?B?dEY5NkFRTk1EeC95ejMwZEdOQTJUbzE3WEFiekNnaFN5cWZzRTVPQUdlWEpa?=
 =?utf-8?B?UHNCTnV0QjdBSllUMG84SXFjWTZrSTZHd0wvMmgwaS9URG1vSGpTdDcwOXFz?=
 =?utf-8?B?RXkyeTRRaXY1NXNQM3F1TC9sR0U5Y3Q3bllOUVZKQ0dZSE5KRm1yUEJWMmt0?=
 =?utf-8?B?TmlDMHkwSEhYRmpsNHpjWlNncWdNcEpLTmZXdlFnb0VITFV1ZkMrQkc2Q1kr?=
 =?utf-8?B?TlBNZExLN2hVTHlBUmRwMWxHTzR1VzlpUTJCU3BqTEw4eGFsY2VDcDJHUlFL?=
 =?utf-8?B?d1RDbVNGRmUrNTllN1o4dG91TTREQTlXQmxNRnhWMmtnbDNpcTh6a2ZKZTlq?=
 =?utf-8?B?aHk4eW5BZzZpMGIra09Sb3pZSzA5ckZXWVE5NlF3YS8xMTRnSEMxbzZRVGNH?=
 =?utf-8?B?L2Vna2NBeDNqT01GMVlZQmtkdWN4SERrekFPYkdLUHZiamVXL0RJK21nUFBO?=
 =?utf-8?B?aW5TTGRtOSsrbmVGbnlNK2RtVWZZMkFicVVCZGE5LzVLRXVadXZ0Z3FPTlp0?=
 =?utf-8?B?UWU1R3lzSHd4dWF1S0RSVGc4SEpHeThpTDVuSDN4bzZEb1hRaHRCN1NNSlJI?=
 =?utf-8?B?SGNaMXdjeTQwWHIrbkM3cllrVCtIb3FuWmtWc1FEOFhZSU1BV2pqYXI5aU1p?=
 =?utf-8?B?Tjd5NnlSRitNcWZjOVFHVjFvSVI4aU9iTTZ4QkIzUXMrdkZFaEQ0dm1uVnVW?=
 =?utf-8?B?VEZzdW9NTFBiZVVVQldqUW5Wckdzc210b3BGM2xaVFpuZExYaVZYS2xCcHFK?=
 =?utf-8?B?bjRlWGJ4bFNOdW9TT2c4eTZOeUdqRU5JUjIwSkVlbmg4bWJpOExMcTBYRUdO?=
 =?utf-8?Q?PjM6oujgHr85gYdKPMosw0gIk?=
Content-ID: <08DF3C298EBD2041810D612D2F651C2E@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3667.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1adef0f4-dae3-4d28-8b9f-08dbeaa2e73f
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2023 15:02:38.8270
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7q/f9bkQX9Dcj7pDtbQjIvivpwlRbY+WM9W+i+JVTIocKll8FTYZFavraKt3C3+ljpl+NGGKPEbsEInRWRjnmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR15MB4535
X-Proofpoint-ORIG-GUID: LYAgKS-n6KsDnOmOIZ-xU3JCYHBerAPW
X-Proofpoint-GUID: LYAgKS-n6KsDnOmOIZ-xU3JCYHBerAPW
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-21_08,2023-11-21_01,2023-05-22_02
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 07:02:59 -0800 (PST)


> On Jun 16, 2023, at 10:44=E2=80=AFAM, Ben Dooks <ben.dooks@codethink.co.u=
k> wrote:
>=20
> >=20
> The g_debuglevel variable in debug.c is only used when DEBUGLEVEL is
> defined to be above 2. This means by default there's no actual definition
> of this in the headers, so sparse is giving the following warning:
>=20
> lib/zstd/common/debug.c:24:5: warning: symbol 'g_debuglevel' was not decl=
ared. Should it be static?
>=20
> We can use the same check as in the header to remove this if it isn't
> going to be used, silencing the warning and removing a small bit of unused
> data.
>=20
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Thanks for the patch, I=E2=80=99ve applied it to my tree for v6.8.

Best,
Nick Terrell

> ---
> lib/zstd/common/debug.c | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/lib/zstd/common/debug.c b/lib/zstd/common/debug.c
> index bb863c9ea616..820520b93d2b 100644
> --- a/lib/zstd/common/debug.c
> +++ b/lib/zstd/common/debug.c
> @@ -21,4 +21,6 @@
>=20
> #include "debug.h"
>=20
> +#if (DEBUGLEVEL>=3D2)
> int g_debuglevel =3D DEBUGLEVEL;
> +#endif
> --=20
> 2.39.2
>=20