Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp452258rdf; Tue, 21 Nov 2023 07:10:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqlErhmKeAxGKmGyrJ0qcqDpmhsiwOVjEo6+NXNiplLLIqkk4rISmLIcU7tHq+ARUhdSBh X-Received: by 2002:a17:90b:887:b0:27d:4f1f:47f5 with SMTP id bj7-20020a17090b088700b0027d4f1f47f5mr9232658pjb.23.1700579420535; Tue, 21 Nov 2023 07:10:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700579420; cv=none; d=google.com; s=arc-20160816; b=UOuhDVmitoYYgXR/9HJOEKsijPeRKqfbyhmGu+R+MTRH462jhQMqzegDnKDMbKOVsc AheSIDBKAed88PMYv+Sw1uez0zDpM+o2o2KK+wcek+sBJKn45JtJEwZIjh/2iAgcqgLd wEJXuzlisSn246ZhiYB7SejPKh0QBWdy6U9hkUe2edpogHaDx+EUBDpRl3OimWU316Ea an9cLeWUJUKxZjKLPRNyw75eBxmaeexaFZt6I4B0gobpBAtOHolKRqa/9WwsgW+U0aj2 Yc5sXgUAO9NmCaMPQasicoZar7Srgxi68U5N7u+vmxrB9xcnv9c5yARTCndaw1jSiqEd tkeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=d2imovBiyqzcEwqpmKaZFC234HiCo956rDViSX13FFc=; fh=qvaDnocTxIrWAvU7IS7WO5yo1sS7n5cRS/1luepwBWY=; b=wxn/y2azmWQY5wtNZd5XO+ayJQEn0un9LAPP3yOtmKwGsIGom3q8f4fReKk/xJxBPW 5FPq0unmsgyL1v2D89wtHriWyIqWvnYTIeQFYf3g17jiW7/AC8704+Vs8xj8yPE+ZMMV sZobmIfzZQ82gagBXue3oCz18syaQ5qc+IJTXcoub/Vc5FoW5tl1SRoN6mpiLv/QFW2G m0NN9hhZPvZ9IyWC+/Q1480gHd2KnjJIDuQGZ3ATTdjZ0hZw0dIkFdgvH3N0Tg/CU7/G dAoYY+XeGYqUb0/JWjdFlykV+ghg4tGmxupIQK9jtJNQ+BVov0Gqot4TFfB4G42PnStA Ha2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QpMwRnzf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id a6-20020a17090a854600b002840019a45fsi8111976pjw.148.2023.11.21.07.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 07:10:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QpMwRnzf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B906F8038F3D; Tue, 21 Nov 2023 07:10:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234162AbjKUPKT (ORCPT + 99 others); Tue, 21 Nov 2023 10:10:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234100AbjKUPKS (ORCPT ); Tue, 21 Nov 2023 10:10:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC31BB for ; Tue, 21 Nov 2023 07:10:14 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D743C433C8; Tue, 21 Nov 2023 15:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700579414; bh=hoD9B9KaMcEvoeSUYddyjpm2ZdhkXr+vFTrOHMCpHEw=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=QpMwRnzf/CUaKy/Zs1u5MsOJr9UiZ4YZjf6yB078nlcpbnvgjGWnZBVs6FF2Kq2xW Ka+Kn/ebwt9mbV2o63YB5z78cP4yuVULoS8W4VAW85UrJNxJPUYgrH0NrSWL/92k6N 5teoA+r2UeqOb+OwPCze4+tLg3zrrGSgUfQfGbk0vy0jw0rbY8YXi6aaMcyRaj5UjB l+5gu9PYHyxW8ZEjp5unPrapmcdYF9RdXHomMRaFOIE+bRHBCbpacnv8szqis7BLi6 gfxGuMiSjxgj81UlfKk9mNivd028LicpDhEwAQ4HdRwwQXiC0Y28GzqXLOivwzhBxz GT9IrKq3pwB8A== From: Lee Jones To: Pavel Machek , Takashi Iwai Cc: Jean-Jacques Hiblot , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?q?Johannes_Pen=C3=9Fel?= , Jeremy Soller , Hans de Goede , Bagas Sanjaya In-Reply-To: <20231121142629.27083-1-tiwai@suse.de> References: <20231121142629.27083-1-tiwai@suse.de> Subject: Re: [PATCH] Revert "leds: class: Store the color index in struct led_classdev" Message-Id: <170057941222.880794.5199112193553712244.b4-ty@kernel.org> Date: Tue, 21 Nov 2023 15:10:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 07:10:18 -0800 (PST) On Tue, 21 Nov 2023 15:26:29 +0100, Takashi Iwai wrote: > This reverts commit c7d80059b086c4986cd994a1973ec7a5d75f8eea. > > The commit caused regressions to a few drivers (such as Logitech > keyboard or System76 ACPI) that already had "color" leds sysfs entry; > now they conflict with the commonly created sysfs of led class. > > For addressing the regression, we revert the commit, so that the > conflicting "color" sysfs entry is removed. > > [...] Applied, thanks! [1/1] Revert "leds: class: Store the color index in struct led_classdev" commit: 17e1ad377bb1d39260e0594ee284d8e03f64fdfb -- Lee Jones [李琼斯]