Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp477925rdf; Tue, 21 Nov 2023 07:46:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IF9b8YUq8TaOH005+HpkYwaZ3K2iZf4I8pvG5gY+ArlMFpN6O05v4Ei+j2u+nCJki7mMyia X-Received: by 2002:a17:903:1103:b0:1cc:45d0:470b with SMTP id n3-20020a170903110300b001cc45d0470bmr13113199plh.7.1700581576295; Tue, 21 Nov 2023 07:46:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700581576; cv=none; d=google.com; s=arc-20160816; b=G8Udvjkrq1BCKX5VSptFxVMSJV2WuJhuCEyAedbb/Eof7rQ1vRqZCvJttecuDRI6yn P3Y1rbKXYDP3mFsUP+llngTDsPEV6JJwXovZrI5ToBOJRz1pHZsErKDbSaACntLudSnr iM5e1a7HFP4X+ghnoAl3pEYDGudOrrdEOzm7snDvQR8kHlWzyWAkT0RbE1FnKa5ZHBms Q0A20Xxf+2NqXioIcY4S2b9cdUXLb390gnlWR/7Qkk+frqIo5PgMHelYxzVEokOF1Bf6 niXSjxDtdcqQIIARZJS3UfEqQxynvvwv06fCWoFyoPtQ2+AtjtbmxgosIw1/TV6KVqJR h+bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=QrrdlxnPkvBTM/dyyHD62Af+aE8UzFW+pcUz2BBDeuU=; fh=v/j7QEwtsj+94eMIzch1qbwAijHXRMR6IcasrHCGlTE=; b=kpVSHJ5rWCovMDR8xUhz0UUo0U2fAO5cXO+ByLn+0PUgfLr+KP25bKFXvSoKhqm/CD 3d0cks8dSOcpw63VbXqxudBEaU7vhzUxsXP6b2BOXgXVFMC9JvvuElAePfgYObilxb9d p95Sjgi3vOFsdol4J61e2Olm3AWe5Lincn42bdGN0HyZlETBLRSOb3qsbdh4iIM0ms/Y eUhIsu/No0Zz900FgioRefBXmzm2667qJvgVnGQXrKPRVQa6sDDmkLCZAEH4HmvenaCF i8DOEgofvy3NLeaXlkcuRM6gbaYQ0dQdA4GZSY9vxRIsMYXFirI/FVPwYWCeFcFgERz6 S/dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nd10M+JV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id bc1-20020a170902930100b001ce16902d39si9956472plb.449.2023.11.21.07.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 07:46:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Nd10M+JV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 43CDE8060C8D; Tue, 21 Nov 2023 07:46:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234440AbjKUPqG (ORCPT + 99 others); Tue, 21 Nov 2023 10:46:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234176AbjKUPqE (ORCPT ); Tue, 21 Nov 2023 10:46:04 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E83597 for ; Tue, 21 Nov 2023 07:46:01 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02E42C433CB for ; Tue, 21 Nov 2023 15:46:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700581561; bh=QrrdlxnPkvBTM/dyyHD62Af+aE8UzFW+pcUz2BBDeuU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Nd10M+JVclQzaCLDrEsgLBawo4Wg9OoO8L8dtHIvU1EhdwDQFbXvgdxX37SJxk0cH nNunW/tN/1zbcY6PnHy2ISrWW/ThPx84ryM0Qp8SrvgcVa6XmkoeMram0+9WqNPdy/ WfyNPVgX9tapd87DtoJhQ821Hpj1zdts/Zm3dLc4L+3Z8fBFLXQ3GZVRC35pEgukhB JETA7Djd4871RBNinv12o+cEwlryvS/DlmjzhA1bm9Z1qKhZqCL9fPUWIC5nxy8qFM gCdRAie605+dIU4t1DZvknlV/YinUJM5b2i9d5Ct0fq4ai2uBCuaRKYWUzdfnlYYto 2YQNx9QCojyIA== Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2839c113cbcso3173138a91.3 for ; Tue, 21 Nov 2023 07:46:00 -0800 (PST) X-Gm-Message-State: AOJu0YyGQniDOgNmMOl65nUwpVxZ+eWE5KxiiAOZxS+QLzCBNTCX/2vT Kpx2Q1uHZPM0R59X+O0FffBv8gOojmzdckJX5QyL5w== X-Received: by 2002:a17:90a:fd02:b0:280:3f33:64d8 with SMTP id cv2-20020a17090afd0200b002803f3364d8mr12148287pjb.21.1700581560471; Tue, 21 Nov 2023 07:46:00 -0800 (PST) MIME-Version: 1.0 References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-11-ryncsn@gmail.com> In-Reply-To: <20231119194740.94101-11-ryncsn@gmail.com> From: Chris Li Date: Tue, 21 Nov 2023 07:45:49 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/24] mm/swap: remove nr_rotate_swap and related code To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 21 Nov 2023 07:46:13 -0800 (PST) Hi Kairui, On Sun, Nov 19, 2023 at 11:48=E2=80=AFAM Kairui Song wro= te: > > From: Kairui Song > > No longer needed after we switched to per entry swap readhead policy. This is a behavior change patch, better separate out from clean up series for exposure and discussions. I think the idea is reasonable. The policy should be made on device level rather than system level. I saw Ying has some great feedback regarding readahead cross device boundaries. Chris