Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp499269rdf; Tue, 21 Nov 2023 08:13:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBI6ELs2unbzQ+PJA/fQm+RctmRZycUaCw69QtcG941KnGPaHmqvfqmjfobkcjgGgF4s5h X-Received: by 2002:a05:6a20:a1a0:b0:18b:c7a:7f74 with SMTP id r32-20020a056a20a1a000b0018b0c7a7f74mr1045362pzk.7.1700583236311; Tue, 21 Nov 2023 08:13:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700583236; cv=none; d=google.com; s=arc-20160816; b=x00SJXZt4bl1v2qKOIPcRogB1ztVpB8eeeGLiv3RW3y5CJaKpeO9fld6jhzAYupYum pdLjtqEzza+NmBM+7ytC6gg7s1gV1Fyt3C8r1Mq2VTXZGqBfgc/uR/sbSp8OyOcJuhr5 GBTOMrcAELqVUQgJZG/FhxfHUJ+ybJgjBGWysWA1Hu/f6W19pNx7SCb2L8SKTTLKUc+t uziFKPkaZBxyRzO0Lbi05KvgjgQjmNBYD32sFb4UpZsBkNPuHDOODvEuszDAXTX2xhps hZsqQSDRjsv5sCY99kcby9YI297laXvvCTQBJDMr+wBlmyhVFtqntO3WVqSbw1FYg/2B vsCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=vCkj0KpxevVvJ98XKlce4SLP6YBN2XcCVZPkTge4FWo=; fh=iUG7PSY9oUcRXWapcNGuMdiliwLUKUmOc4zBp7IAlLg=; b=GFTfDGpcOqEFQoQCTPBcn24xtb0ozxNmZVIPnEQ9stwg1D5wYmnavyU1efmxZtCGKR M0ofM308DFAMRZ8GNC95KeIHCvjfeS2FDAh285DAry6Uxo6k99nW0KxHUIGpzEMDcutR wyOymYMLaCd1r7sjyMf7mPFYrdtf/7QnRetrgSbYnjCSQtPc6kMvCG2RdRYeWXVlGFTT OaZOr+rXfKFQNHSLWIyAyhk2lf22STVv1pL0wkW6wDYKgmePnaOjLI3WBUGak+KoD0dE HLmUTL5NBfhgrplmkQ3bc/oKfsvCihKruzbparMaCQ43bSq1BjTzRBN2YHiVPKQYJCik uA/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=BYJ2pZ6i; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id s66-20020a635e45000000b005b8f181b729si11103448pgb.360.2023.11.21.08.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 08:13:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=BYJ2pZ6i; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 04DE1803248B; Tue, 21 Nov 2023 08:13:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230458AbjKUQNl (ORCPT + 99 others); Tue, 21 Nov 2023 11:13:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjKUQNk (ORCPT ); Tue, 21 Nov 2023 11:13:40 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9360192; Tue, 21 Nov 2023 08:13:36 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7577B218F2; Tue, 21 Nov 2023 16:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700583215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCkj0KpxevVvJ98XKlce4SLP6YBN2XcCVZPkTge4FWo=; b=BYJ2pZ6ixbRu5iK4rUeak472a+b1qznqNPZdaKPL8Yxq9Yd38+0123gu0JxZkQqFFYipX/ UQI4CHGR2UwN0zbuiFPEyZdtoCvP0PP12zJWbBOkmHBQ9RlQx9Xy2/ZGzCelsIRzOx13vD vbh1sy5E5wsjg/2I8fGfxFnBTkxe/kA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700583215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCkj0KpxevVvJ98XKlce4SLP6YBN2XcCVZPkTge4FWo=; b=XuTF1gYB0r91E0r9oS5olHMxQKtFdKGz111BrWM1roDiUu94T+B15u9FZi3jj+h4NSVk9q RpJtEWbBBGBiatBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C4C9138E3; Tue, 21 Nov 2023 16:13:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SELvBS/XXGXEEAAAMHmgww (envelope-from ); Tue, 21 Nov 2023 16:13:35 +0000 Date: Tue, 21 Nov 2023 17:13:34 +0100 Message-ID: <87v89v9j9t.wl-tiwai@suse.de> From: Takashi Iwai To: Lee Jones Cc: Pavel Machek , Takashi Iwai , Jean-Jacques Hiblot , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Johannes =?ISO-8859-1?Q?Pen=DFel?= , Jeremy Soller , Hans de Goede , Bagas Sanjaya Subject: Re: [PATCH] Revert "leds: class: Store the color index in struct led_classdev" In-Reply-To: <170057941222.880794.5199112193553712244.b4-ty@kernel.org> References: <20231121142629.27083-1-tiwai@suse.de> <170057941222.880794.5199112193553712244.b4-ty@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -4.45 X-Spamd-Result: default: False [-4.45 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; BAYES_HAM(-1.65)[92.79%]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[10]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[ucw.cz,suse.de,traphandler.com,vger.kernel.org,gmail.com,system76.com,redhat.com]; RCVD_COUNT_TWO(0.00)[2]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 08:13:50 -0800 (PST) On Tue, 21 Nov 2023 16:10:12 +0100, Lee Jones wrote: > > On Tue, 21 Nov 2023 15:26:29 +0100, Takashi Iwai wrote: > > This reverts commit c7d80059b086c4986cd994a1973ec7a5d75f8eea. > > > > The commit caused regressions to a few drivers (such as Logitech > > keyboard or System76 ACPI) that already had "color" leds sysfs entry; > > now they conflict with the commonly created sysfs of led class. > > > > For addressing the regression, we revert the commit, so that the > > conflicting "color" sysfs entry is removed. > > > > [...] > > Applied, thanks! > > [1/1] Revert "leds: class: Store the color index in struct led_classdev" > commit: 17e1ad377bb1d39260e0594ee284d8e03f64fdfb It turned out that drivers/leds/rgb/leds-group-multicolor.c initializes the cdev->color, and this revert breaks it. So please scratch my previous revert patch. I'm going to submit a partial revert instead. thanks, Takashi