Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Suman Ghosh <sumang@marvell.com>
To:     Simon Horman <horms@kernel.org>
CC:     Wojciech Drewek <wojciech.drewek@intel.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [net PATCH] octeontx2-pf: Fix ntuple rule creation to
 direct packet to VF with higher Rx queue than its PF
Thread-Topic: [EXT] Re: [net PATCH] octeontx2-pf: Fix ntuple rule creation to
 direct packet to VF with higher Rx queue than its PF
Thread-Index: AQHaG3WoW/JPw3tq9UagL7vstPIRILCDG+oAgAFuHYCAAGVEgIAABqjQ
Date:   Tue, 21 Nov 2023 16:20:11 +0000
Message-ID: <SJ0PR18MB52168E39F5F5BC22D6A7DC2DDBBBA@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231120055138.3602102-1-sumang@marvell.com>
 <745e6518-6253-4ef0-8f05-1421ee4e1fef@intel.com>
 <SJ0PR18MB52164E2721E056366EC30139DBBBA@SJ0PR18MB5216.namprd18.prod.outlook.com>
 <20231121155511.GC269041@kernel.org>
In-Reply-To: <20231121155511.GC269041@kernel.org>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3qaTuZC5Q3i45NlqhxB1NXmYqii/SUHInp8vQ1juEfYyVs5nKwkx9VoXmYJH?=
 =?us-ascii?Q?pC/1961WQjBXIsdGVpnIqFUQNumvLMwwv7kIOyESuC6ZpULzbvo/2GNG/wbN?=
 =?us-ascii?Q?wMZN5TT+NQdeevSKly8L5d4wRAR2vd7qNsbpwgvX1ezbZA1NK/yuVG1pWQcH?=
 =?us-ascii?Q?jXQC9idOp0gCDjGJEqTQxJNf0GJ4MRsiQf2SLIauPgtDf25M6yIOZ4HL1KUj?=
 =?us-ascii?Q?XfKvjBSenTq7cBwEECHVQRiNg+2Mgqx82ruNtLMB27WL3fhsG6NrUpzXn3ka?=
 =?us-ascii?Q?jBJZzhkgzZjMQt5KFM1O0iKUEh8arXpbprTZWHMcyyJK2H7+xtNM4011J1ss?=
 =?us-ascii?Q?DTLwtjDY5msZW2VAKdRCFkpl3CWfZRjvpKhezjWPyP/lsVhjOs6c9mbuD5dG?=
 =?us-ascii?Q?v+qO7sFA5GLEKY/l3YbgPzek5hcpYbLXXIYmiEG0WMMMKy4PLNjJRzTXVYrf?=
 =?us-ascii?Q?B9Vx//wtJS6Xa/ChhSA2TIdfwKKLO/OUqBDK+VtWfS2Id64P0290vIuBIhT+?=
 =?us-ascii?Q?kh9RbErDr6QAIFiE6t6Vz2OTQykSr/2ZtIh9q+06kyUDJcHei3F13XzKz89L?=
 =?us-ascii?Q?zQjEbLxUKEcFMTw+x6nQbreKUAqWrPjzMhqH0vUVqW1bNieKDM3YdY/80217?=
 =?us-ascii?Q?oUxnvuIGA2IpBbyWLriXzBX04kJvG27Xiy9x/gH4X83ME6OlEdhvQHNTWDbW?=
 =?us-ascii?Q?lwaSnChdlTx2wU/jvFayAa/5JlzLXCE9NVXQtxYX6UNWiMr71VapdLQqNaWi?=
 =?us-ascii?Q?H0Uj1BqSHq3AFLpfNhdOVeOfL+1akEAvwJHdtXtlAuNuQz+hhvjUOK/SgubA?=
 =?us-ascii?Q?/XSvlPIrK8RDN7f0BhdHHhSW3Vkz1kn1Oqy9IaNnohtutZLryt2N0roplOOb?=
 =?us-ascii?Q?FPuXx8CvtedET07wx+6yGwK/MkT79wnIQxKi9MjznU8MmU0KPvKimeT2yQOL?=
 =?us-ascii?Q?GuYglT6fACUWssl9a02NpArgTEGOy5i//0FsBVBSZtMN9xxYnBEcvHDYCz1K?=
 =?us-ascii?Q?jYnbuuB1v91c0rurG1/l3Zs6PaaLd0p4pN4Zt4ZH/apYjsdeHR9TDDweq7Op?=
 =?us-ascii?Q?7F8PtNGvPiy/nyi1fSNOCRyWgaA1bYHw9ZLR3q1UouC/kk8gqcJ6jfWlswyq?=
 =?us-ascii?Q?jKQ0R+BZPPjHCylO1UPW28mGAwY0vXAUu/U2R3U7nf2vTrN2DJpJQfr+uyTB?=
 =?us-ascii?Q?ht/vFvITi5ce+lUMdKdUFIefVDgii0XEslEk94LIVtb5d8M+0N+2ZJLWlzph?=
 =?us-ascii?Q?7R71G1IZGaTN4L7nRKGZmm7232nsAaPQkFFUh+bi4xJRv9bzq3x7yYTgk0ea?=
 =?us-ascii?Q?hB+nbvOwcgLRrpxs22RZ5litmZGTdlFe9EYZUM6y7Ql+nPBcmcx464A5kUk9?=
 =?us-ascii?Q?AdXn5ciziEDiknEWzIq6Ho2FT1a7P/XyrZsfcBSUOkR2Cj4xFeON2okYtd6V?=
 =?us-ascii?Q?tRr6qzj9CeKrkhu1S6bMwjY0E0MrZNSwcr9WUbXxXvifNkKb3Cdx0DCqYJy6?=
 =?us-ascii?Q?JtQbUfkn5K6NXUp31MBE1iDOFP/zQZBCVqCylWKA1oGBByfFc4niB2icgIqc?=
 =?us-ascii?Q?a6/I95UqTE6ogYybnQDoRgFU2Iw/LxcSeC764jgC?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9477a07f-07af-4146-5a29-08dbeaadbc39
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2023 16:20:11.0619
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B/En7ZmzqUwcEDj6Mp/HalwXiI+T4nGBzD6eR1VQI0igNzqLQckp2WR15wrw0KUMxc19T1VK/wlBi2QYSTK2mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR18MB5440
X-Proofpoint-GUID: 3MYH-lJAeniMF7b_AxhimIZDR37K5hVT
X-Proofpoint-ORIG-GUID: 3MYH-lJAeniMF7b_AxhimIZDR37K5hVT
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-21_09,2023-11-21_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 08:21:01 -0800 (PST)

>> >ethtool_rxnfc *nfc)
>> >>  	struct ethhdr *eth_hdr;
>> >>  	bool new =3D false;
>> >>  	int err =3D 0;
>> >> +	u64 vf_num;
>> >>  	u32 ring;
>> >>
>> >>  	if (!flow_cfg->max_flows) {
>> >> @@ -1100,9 +1101,26 @@ int otx2_add_flow(struct otx2_nic *pfvf,
>> >> struct
>> >ethtool_rxnfc *nfc)
>> >>  	if (!(pfvf->flags & OTX2_FLAG_NTUPLE_SUPPORT))
>> >>  		return -ENOMEM;
>> >>
>> >> +	/* Number of queues on a VF can be greater or less than
>> >> +	 * the PF's queue. Hence no need to check for the
>> >> +	 * queue count. Hence no need to check queue count if PF
>> >> +	 * is installing for its VF. Below is the expected vf_num
>value
>> >> +	 * based on the ethtool commands.
>> >> +	 *
>> >> +	 * e.g.
>> >> +	 * 1. ethtool -U <netdev> ... action -1  =3D=3D> vf_num:255
>> >> +	 * 2. ethtool -U <netdev> ... action <queue_num>  =3D=3D> vf_num:0
>> >> +	 * 3. ethtool -U <netdev> ... vf <vf_idx> queue <queue_num>
>=3D=3D>
>> >> +	 *    vf_num:vf_idx+1
>> >> +	 */
>> >> +	vf_num =3D ethtool_get_flow_spec_ring_vf(fsp->ring_cookie);
>> >> +	if (!is_otx2_vf(pfvf->pcifunc) && vf_num)
>> >> +		goto bypass_queue_check;
>> >
>> >Let's just add this condition to the next if, no need for goto.
>> [Suman] I kept it a separate check to make the code more readable.
>Otherwise the next if condition will be complicated.
>
>Readability is subjective, but, FWIIW, I'd also prefer to avoid a goto
>here.
[Suman] Okay. Since both of you are suggesting the same change, I will upda=
te the same in v2.
>
>> >> +
>> >>  	if (ring >=3D pfvf->hw.rx_queues && fsp->ring_cookie !=3D
>> >RX_CLS_FLOW_DISC)
>> >>  		return -EINVAL;
>> >>
>> >> +bypass_queue_check:
>> >>  	if (fsp->location >=3D otx2_get_maxflows(flow_cfg))
>> >>  		return -EINVAL;
>> >>
>> >> @@ -1182,6 +1200,9 @@ int otx2_add_flow(struct otx2_nic *pfvf,
>> >> struct
>> >ethtool_rxnfc *nfc)
>> >>  		flow_cfg->nr_flows++;
>> >>  	}
>> >>
>> >> +	if (flow->is_vf)
>> >> +		netdev_info(pfvf->netdev,
>> >> +			    "Make sure that VF's queue number is within its
>queue
>> >> +limit\n");
>> >>  	return 0;
>> >>  }
>> >>