Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Zi Yan <ziy@nvidia.com>
To:     Ryan Roberts <ryan.roberts@arm.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        "\"Huang, Ying\"" <ying.huang@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        "\"Yin, Fengwei\"" <fengwei.yin@intel.com>,
        Yu Zhao <yuzhao@google.com>, Vlastimil Babka <vbabka@suse.cz>,
        "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Kemeng Shi <shikemeng@huaweicloud.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Rohan Puri <rohan.puri15@gmail.com>,
        Mcgrof Chamberlain <mcgrof@kernel.org>,
        Adam Manzanares <a.manzanares@samsung.com>,
        "\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v1 0/4] Enable >0 order folio memory compaction
Date:   Tue, 21 Nov 2023 11:45:22 -0500
Message-ID: <7ED1378A-AC39-48A2-8A2A-E06C7858DCE1@nvidia.com>
In-Reply-To: <1e7cf758-ac0e-4eda-a8e2-90db5eed7f7a@arm.com>
References: <20231113170157.280181-1-zi.yan@sent.com>
 <1e7cf758-ac0e-4eda-a8e2-90db5eed7f7a@arm.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_84E3D06A-6D91-4F40-BFFD-80D59E6188DE_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0pSVkoyM0ExYUh6aDAyRmJzRlc2SUpIRkpERS9sN0tUUnZlcTd6K01JS0Rw?=
 =?utf-8?B?MzJmM0xoenRXajc1Sy9hT1lzSUNkU0Z2OUliYklhV3FkZndRa0hqLzhDQThp?=
 =?utf-8?B?dFNHSm94V0pYYkpyOTJDS1puUmhPUmU5ZW9vVndrc3RKdC9xVWdpNHJHWXI5?=
 =?utf-8?B?RmMvcmNjVTdYM0dYNDl4VzVKeTlaekNPN2pCWThrcmdwZlZZT3ZSU2o5U25z?=
 =?utf-8?B?NVN3c2VTQy95VUd1Wk0rTDZEcnlLY04xUUo4bUE5bDFtUU56TnZZbDZ6NUtN?=
 =?utf-8?B?VHZQQmxJNW0yUUVjMlNKbi8zZDlLUG0wR0VJT3ZCaHBhVXRXME9wNnpqLzIv?=
 =?utf-8?B?c002UmtWOTdzVGVnWDc3RllTbkc4dEtzQzlDS0R3SEsybk5RQ0syUXFub0pG?=
 =?utf-8?B?OUloUm96OWZoUXU4RFRvNHJsbTN1ZkxnYS9zTzBGSUNOVGFCc2tESkNrTmha?=
 =?utf-8?B?REsrWHpGS2g3UUFUL3orckxsM3ZreitMNXk4dU5qenRZcE9JUDAvQlR2YjZm?=
 =?utf-8?B?NnFtUUJZTk9lQVNoWEUyU3NhY1BmT1R3VGpyQ2ROd2VuTk5mMjJQbTZXVUF0?=
 =?utf-8?B?em04cGo0WXU0N2dNYzBDelNzb2UyVXFsVU1QSDZoUm05NGxaYnhpZnVETXMw?=
 =?utf-8?B?bnd6ME1OVWIzSURoaC9ybHhhb2F4RjdtNnk3c0V4SElvOGZ6UFN3RlhIVnFu?=
 =?utf-8?B?WENTS1lybjVXQzNkOGZxTVVVNlRaOGhZUk9kM3hRQmMxNkFaUGxIV1gvN3k4?=
 =?utf-8?B?dW5sUFIxWitRNWtBL2tocUtVZXVTNlJLVmY2dFBkd2lDWDhTQXplMHMvTnN4?=
 =?utf-8?B?eFd4cjZNYm0wVVJ4bGYrZkZWVHBWb1ptc0NmR3prd3BkOEROTDFvOFFubmh5?=
 =?utf-8?B?NmplNWE5UmlSUk1uY3JMTC9YUXhNMzhlclg0NGZFeTBQbDBpOEJQdnJtUkxO?=
 =?utf-8?B?Q0puMEZlYlcrUmkweDk3eStDd2VkbWFJL2FpQW5MWkhPSG1ELys4bGYxU0VQ?=
 =?utf-8?B?UEhBcEcwQUdjUk1Gb3I1K0EyTUxoNS83VDZDV2ZKN0xvMVd5bFZFWjI2RTJG?=
 =?utf-8?B?eDhQUVdIUXNtcVhkL0tiL1hicllnbStyR3lxcjVCbkVvRTRpbmJVcVRVb3Rr?=
 =?utf-8?B?NVIzQWRPU3NmdmlobS80c2o0aGVqS1ppOUlHMHRCQzZ1NlkxZnQ5Vlk5bld1?=
 =?utf-8?B?VXRBQmxyU3N5ZWYwUVM2Wk9iaFQwY20zajN6eWxLcTk1Nk83T0NQZ3MzdE9v?=
 =?utf-8?B?aVNLcm5xTGJLTWVZMFpFOTk0cVNOVGY2NHZiMm1na0JhZkpkakZ3czByM1BJ?=
 =?utf-8?B?UmMyWmRZS2k3Z3dic3pkOE1mV2RmMjljcnZVeGljdHUyTUZuL01la09rRWRp?=
 =?utf-8?B?dzdwSnhQSGcyVHEzZnZ5QjVRT1EzekZCOHFsMUt5WER6bE42eWFXSFRUQUs2?=
 =?utf-8?B?SitMaFg1am02b1NaZVNKaHJnRlJUeUt1KzlYSTRXdzNwRDdwbkpVM3REWWUy?=
 =?utf-8?B?a2FHT0N6R0h4RlVPZExONjFvaEUrRmRCSFE1eEsxRXlPSE9aRndsaXpuOHlM?=
 =?utf-8?B?Y0hSemxpV3VkdWRMSEVJRWtuSUQ3Ylc3Wlp5Z3hpR1ZhNmZYbUpQc2c0aUlL?=
 =?utf-8?B?aVAxUkZ5U094L2pLWVlscDVTTTNycVREY0J0V0lCWS9iR2gra1ZKWDZjWko1?=
 =?utf-8?B?WmRjdnByWnFhYlE2cktPeFAyNTNjblJxR3R5K1NKODQxMHIybVMrSDN1eVQ0?=
 =?utf-8?B?L2VuTmVZQXluMFRtUkpkOVluWTdncW1KSW1Tc096dnRUUGVVdGVDbDlFRURw?=
 =?utf-8?B?ZmhLYmlCWTN0Q2JHZUFZOGVrbEFjRWhvY2N4NU5KaCt0WlYrY2ZHUDVPSUtT?=
 =?utf-8?B?TlF5QXNCQm0vb2ZRSWRKZElqRytwbitJa0cyQVVtMXd6bGFzZ2R3RmpFWDNa?=
 =?utf-8?B?ZytMdmgydHpQOXRTbnZ1eVJhL0I5ZzlIRFo5cUNEQW5NMHlEay8zU0ZRYlNi?=
 =?utf-8?B?WTA4VTN5d1Z0dVpXZjFLcXZOaHdNRllYazRFSWhmeWxNeTcyNHJmN3VuMVdS?=
 =?utf-8?B?RkFGSjdlUWlMRXRjdGFKajZONytjcEtBQ3N4S2dDdzJ3WW9reTR4b2ZDcmw0?=
 =?utf-8?Q?CEok=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84bfcc85-0e35-4052-c140-08dbeab14340
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 16:45:26.3551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O1jE+93zMGNKnEVYiZnUFzad9w7a7TMSFE/r0wll/3n/5VWX2NkB7d4eJx6vl2IH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6759
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 21 Nov 2023 08:45:56 -0800 (PST)

--=_MailMate_84E3D06A-6D91-4F40-BFFD-80D59E6188DE_=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 21 Nov 2023, at 10:46, Ryan Roberts wrote:

>>
>> vm-scalability results
>> =3D=3D=3D
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> compiler/kconfig/rootfs/runtime/tbox_group/test/testcase:
>>   gcc-13/defconfig/debian/300s/qemu-vm/mmap-xread-seq-mt/vm-scalabilit=
y
>>
>> commit:
>>   6.6.0-rc4-mm-everything-2023-10-21-02-40+
>>   6.6.0-rc4-split-folio-in-compaction+
>>   6.6.0-rc4-folio-migration-in-compaction+
>>   6.6.0-rc4-folio-migration-free-page-split+
>>   6.6.0-rc4-folio-migration-free-page-split-sort-src+
>>
>> 6.6.0-rc4-mm-eve 6.6.0-rc4-split-folio-in-co 6.6.0-rc4-folio-migration=
-i 6.6.0-rc4-folio-migration-f 6.6.0-rc4-folio-migration-f
>> ---------------- --------------------------- -------------------------=
-- --------------------------- ---------------------------
>>          %stddev     %change         %stddev     %change         %stdd=
ev     %change         %stddev     %change         %stddev
>>              \          |                \          |                \=
          |                \          |                \
>>   12896955            +2.7%   13249322            -4.0%   12385175 =C2=
=B1  5%      +1.1%   13033951            -0.4%   12845698        vm-scala=
bility.throughput
>
> Hi Zi,
>
> Are you able to add any commentary to these results as I'm struggling t=
o
> interpret them; Is a positive or negative change better (are they times=
 or
> rates?). What are the stddev values? The title suggests percent but the=
 values
> are huge - I'm trying to understand what the error bars look like - are=
 the
> swings real or noise?

The metric is vm-scalability.throughput, so the larger the better. Some %=
stddev
are not present since they are too small. For 6.6.0-rc4-folio-migration-i=
n-compaction+,
%stddev is greater than %change, so the change might be noise.

Also, I talked to DavidH in last THP Cabal meeting about this. He suggest=
ed that
there are a lot of noise in vm-scalability like what I have here and I sh=
ould
run more iterations and on bare metal. I am currently rerun them on a bar=
emetal
and more iterations on the existing VM and report the results later. Plea=
se
note that the runs really take some time.

In addition, I will find other fragmentation-related benchmarks, so we ca=
n see
the impact on memory fragmentation.

--
Best Regards,
Yan, Zi

--=_MailMate_84E3D06A-6D91-4F40-BFFD-80D59E6188DE_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmVc3qIPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUuNIP/2mVXWbVQL1K1+romdPjGU+yNUE90FXp5jy7
4cLt//cUnhAc87ecfuAVyQSauv4hvjNtDdTNXa+EqxViwv35IpbeYu+OTBu46gqI
kMXARaTc8uIAylPwgdGZzSNBmp1nevvyqUXZFYHLGz5XEYidtZ3mXt11jUA1vSqV
pus7bPVb+odOsLCp+4QWZagDfGP0HP6cxZ4WQBLX7r2Cpf98ZicgIRd7ihDMZS1V
+ikUj36M7m4wWScg2xPLD4k76uZLmWRYia7hCJVSl1uzAUf++oW/zW+Tezb6pPKv
Cz8BR4vGwGQ8lqlCqB5+leuQcOlf4ixmPG0RJP+fZO1T3H8Vydzazj+bqzhhKhwM
RosenItdTHpq153Zs3Ll1mVbXdkD0AikOJdzoXh8tJ3aKuzpNaXh80IbVCcGyxJV
v9AcJdzEmOD+XHiux0V0/kpeafcYuytHXkTapR798zbeXjMVacimc1HM5zOkQQMo
0KBvKp1ndm180y4PyiFXMFgP6TeJb3ZPxNn7ehRNwCTfmC43H1U+1SCxqYmZYV/i
Y3ew5qHGh+MS2XJcef2Dskj8fec/kZYJqteSoyDAqdI4FKNrLPIriNLmq0N4M+FZ
VFZvYuNESA5ySE9sSDMHOLTdnEmGBSLCpaAZsMyOhU1xMGyE8AC1VY5V3SSOhIXf
2dLcTPGh
=AH+Z
-----END PGP SIGNATURE-----

--=_MailMate_84E3D06A-6D91-4F40-BFFD-80D59E6188DE_=--