Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Haiyang Zhang <haiyangz@microsoft.com>
To:     Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Dexuan Cui <decui@microsoft.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Long Li <longli@microsoft.com>,
        "sharmaajay@microsoft.com" <sharmaajay@microsoft.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "cai.huoqing@linux.dev" <cai.huoqing@linux.dev>,
        "ssengar@linux.microsoft.com" <ssengar@linux.microsoft.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
CC:     Souradeep Chakrabarti <schakrabarti@microsoft.com>,
        Paul Rosswurm <paulros@microsoft.com>
Subject: RE: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores
Thread-Topic: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT
 cores
Thread-Index: AQHaHIJJ65cwMLSQwUeLvFL6eERdgLCFAMfw
Date:   Tue, 21 Nov 2023 17:37:11 +0000
Message-ID: <PH7PR21MB3116043F0A93BD5AD23C6C91CABBA@PH7PR21MB3116.namprd21.prod.outlook.com>
References: <1700574877-6037-1-git-send-email-schakrabarti@linux.microsoft.com>
In-Reply-To: <1700574877-6037-1-git-send-email-schakrabarti@linux.microsoft.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=1dcdd3b6-59dd-4223-888c-d8cc864ebd65;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-11-21T17:05:16Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH7PR21MB3116:EE_|DS7PR21MB3452:EE_
x-ms-office365-filtering-correlation-id: 51f2c3a4-2514-42ca-c621-08dbeab87e2b
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: EudmCOQDh6RMbvKclpqyWmkSHwIaTxnXS6glhmuuM344d+lEdhfFvYOZUKpW+PihktksU5dLjOEwCHE6tqz6SFY5WGzY7RID/PHI9o1acIg9R4o7Crz15aZelSOmOVIgL5TCHkxjMCLnW84MC8AVOTmhP4zYX6sWvTQWGA8gUgmqbkD4GqUMpm/NvDqJZ+UbMwKcbKmXhL8JR6sQg4VUGG9zoYCVJEWInfbivP5EUr/nuwud0ewaSoqNAdXHvXETKWuRtcvxXkKI4rfL0XBeS5/vp/P4XoBbIc78b6RBnhYRb01V5sTQGZ38FZHbSQf9mWmeMrKzG50w42nK1unelc+MhVRO9j0X4sIWOjgauNExXxybc0n0jbJLrdH759zJjegYsp7bQy8ndxtpvifXAvCdx4ajeV6tD8sjwYYv5XrzDQbjqLoqQZHpMx8/L/Z6WhC/Y4eMU/Q53bOkNv74Spr+Ws9y6Vl7TZQUVQdQtEID73ZdCscYteX2YOGuNO8BlRWRn7yoq7ccA67+uHb5kuRlysG0eulICGfrbnGeU1Knyer/Y4dNU1HDHm1/+YNNoIRQB4lAOj12j2rJOHlrgTeAvaeqYSguRypxmZsDnDiT0wXJMtDBpaAFONalY07MOXeGtFnn9Kgwzvsv5oYPFX7qb0n2XR9HVpuri7e3IqhkHlxAtj1XXm/GTL2+19yk
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR21MB3116.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(366004)(376002)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(83380400001)(9686003)(107886003)(26005)(41300700001)(52536014)(8936002)(4326008)(8676002)(38100700002)(7416002)(2906002)(10290500003)(5660300002)(478600001)(54906003)(6506007)(7696005)(66946007)(71200400001)(8990500004)(110136005)(316002)(64756008)(66446008)(66476007)(66556008)(76116006)(33656002)(921008)(122000001)(86362001)(82950400001)(82960400001)(38070700009)(55016003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KkaASjGdX3BOrKcDGwA3jgdKZ9YouoqyWOfKEyRsiFYqEAwtR/clUwQ56TCg?=
 =?us-ascii?Q?boPloNi8pgBN/sL7xLTlqWXl/bfPkQCcqdmFiK4KEgGSm5rMxmDCWZ1UUcWc?=
 =?us-ascii?Q?j0LozWBuGDaYofKREFWUI3d7OBJbJ1HzpveDDiVkAbwQhk9fdPSvgkfnOYyr?=
 =?us-ascii?Q?9TZd8kq3GWc5RUCCFh990d5Zc51qFNkhnBdm2YtavQL9Vj20ZBllkq7k7qfC?=
 =?us-ascii?Q?Fnz38sFQhPAxhKa+LrRCUaBF+hkBPNr0KO8VafoOvNj8k7vj5n+BYt3h309L?=
 =?us-ascii?Q?mUPLQYtvI/oDrYwyCCvDsA+EtbR1lOdiXLeQE9ZUDA5f/VLaAh9BPZ9RTyO9?=
 =?us-ascii?Q?cKrZd5irdzyle9Y9xpvDQuick+27l6kLuTZ/iwe5AarM/8N36CbgYFlaoIsS?=
 =?us-ascii?Q?fsgugehMCEab5w5VAz3Z1wwPsfa1FUJZC2/Ile9dVIvoTxLh1/O8jxZ+CYNm?=
 =?us-ascii?Q?j7X93KkBMeYZpdvzYmbJH/jC13Xmw1ZL4KrQxyNBJ7oO0M4qQb2PuSQ7Xios?=
 =?us-ascii?Q?AhVwDzXBB0kxjSAjhiHZ7cYUDoBcx03T2Lwrh87zv9PSFJZIKp196l1z3O+e?=
 =?us-ascii?Q?6FLtDx3w0CmW45ViaY3rcPVAR4OefoDvHdGmlaVILchETgtmA3cwUpbSUQym?=
 =?us-ascii?Q?ae/UaT1c9FuCN1yhvtRqrtgq7CrauTpl1LnpjOs34cGKsIh/b7/DR++vstQq?=
 =?us-ascii?Q?FkUK9MrSga31+qW7qH0jaNu189QrP9MWJAcWZioy4UW6emNm4GGBkUQvVgBS?=
 =?us-ascii?Q?X2Yq9exxq8mbJS0M6AT+N5jp7zIGhd4GniMqUEkaLgb4YRxhfXgub/CQ9ES8?=
 =?us-ascii?Q?2OiZYGRge7+03CSm8wUG47yho/DicW3kgGyUm9hmfjEiocgnt1tUX9+kC7fG?=
 =?us-ascii?Q?ZQHiIwSCFIJewmhgF44yO/Y6bK0VBRmTnR715JFIWUKh1vKftJMq0tS/ujKB?=
 =?us-ascii?Q?mSFmgWE+mRh09iM+5p3fmkr/IEIhfgt7C6cXkYUh0JW6+Cv4OrMt/iuabarA?=
 =?us-ascii?Q?ZCtvJWinXdEaf1k7QyluNjgLO9wYicGxl8zdOxSdT7YO5FLwNo01m0RicI0u?=
 =?us-ascii?Q?JsQca1mgqsZQIDH1otGLlrbAoV4xcsTpDmBNNPt77z3QU4tcHE/qU5c/DD9F?=
 =?us-ascii?Q?7HS/FqiUsy9RaahcnEU7c//tNWEMwQiXBRkBaQk8ihv5/z2jIKVuzfLcQ3HA?=
 =?us-ascii?Q?rJCoYM/VcBvOtrBxfLaDB1BuyuvdW34YksjYbx5qU5js3UV/yaIsHv1ZLJe9?=
 =?us-ascii?Q?hEPpNDGBbqOSazkARNmYIvmqxChJ/7ME2iZkSRY6pL3E02wqskz13KkincD6?=
 =?us-ascii?Q?r8VVre3Q8V+LYJEKYt0SiY64+pjYWt3fZMHAckzMgucUPI9m1+AZSP235ddE?=
 =?us-ascii?Q?z8W0w0wNFio1MbHu0CxfaCyOda+5Vz8ZR1hcQmfILs5sDOaY2LPXicAiuXO8?=
 =?us-ascii?Q?tF1vN68kp/DyTzh2QOmwnatpw/M1HDw3Kxlmhff5CWRln5sAVIvlKBp+aC0M?=
 =?us-ascii?Q?dCP5R1kJPbw+Y29ouC/s0Qylvd08FiU6Jn7xs1TGBPGoQAfEjDmbbcZFzAeo?=
 =?us-ascii?Q?Y4qLQ7uXGrrRLea8wOB9CaOmEF76xK1SbAcoEY6w?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR21MB3116.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51f2c3a4-2514-42ca-c621-08dbeab87e2b
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2023 17:37:11.4595
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: syfyOadwk5lb133qPOt4W6t3KMWCJHu+Gsj703iyhcenf+J5IluPTvdXWwK5PWwG2jMH877mPcQfEK34n6Cw8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR21MB3452
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 09:37:29 -0800 (PST)


> -----Original Message-----
> From: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> Sent: Tuesday, November 21, 2023 8:55 AM


> +	/* for each interrupt find the cpu of a particular
> +	 * sibling set and if it belongs to the specific numa
> +	 * then assign irq to it and clear the cpu bit from
> +	 * the corresponding avail_cpus.
> +	 * Increase the cpu_count for that node.
> +	 * Once all cpus for a numa node is assigned, then
> +	 * move to different numa node and continue the same.
> +	 */
> +	for (i =3D irq_start; i < nvec; ) {
> +
> +		/* check if the numa node has cpu or not
> +		 * to avoid infinite loop.
> +		 */
> +		if (cpumask_empty(cpumask_of_node(numa_node))) {
> +			numa_node++;

Since it starts at start_numa_node, we should consider roll over at the=20
num_online_nodes() like the code below:
				if (numa_node =3D=3D num_online_nodes())
					numa_node =3D 0;

It should also check empty for the next one.
And set node_count =3D 0; after the loop.

> +			if (++node_count =3D=3D num_online_nodes()) {
> +				err =3D -EAGAIN;
Consider return -ENODEV, because we are not asking for retry.

> +				goto free_irq;
> +			}
> +		}

Thanks,
- Haiyang