Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp570982rdf; Tue, 21 Nov 2023 10:01:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtX/4frVJJyizAj2hGx8U0lZgOP7JExluuYalhG738I9pPSNbc4EbN/3vY4Hm9WDSKyv/H X-Received: by 2002:a05:6820:80f:b0:586:b062:f3d0 with SMTP id bg15-20020a056820080f00b00586b062f3d0mr90269oob.7.1700589659556; Tue, 21 Nov 2023 10:00:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700589659; cv=none; d=google.com; s=arc-20160816; b=fXWC/Pa2MCC+uoculkaadEz+zVPZnNe2EJhAOb9WGEnYPDoR68TBpgQydGzylyLLdL LAek0auQ8mxq0klDH1fCmTbQWH8HzqB0e/lzUbJtPtTf35W/sUcWlX4tmoAF0gaNZZB1 530ui+rnjTPT5o4NjhVQI9OfIiIHArD2L0QvKdq7XeB3vkeX74qCIw8HLBhGkoJqj11C b6n8qd1esgKcePfX5YJuZMxSYt/u1JdJ6GIioABBd26VOp37Rq04ubQoF46D+sMQJ10O 2wVeVEBTbG2xIvYvO72u/erooJOyI67UzV6uZilXFdpY7rLgHM9/RY9jERzUtpbINeXA dojA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mjCWxfluyi78Cx8vUvEqR5XltkHFZvIwrZewE7gRQXo=; fh=z7dP0sUsXLtnomzA6+FUC3zkdfBao0VqwDEfI89QmpM=; b=yh2/FdsJ1dh+JBI2CuzvQCYylIl10HJEAV7621OIUcBk4uXlqMpIjh0dPpQbBCW8w7 boUfzHDw6lQkXU17eiAI7zfqoph4Z5X8Td+nRe/eF6TL8Qjc7xm8RT1RicxAPSPLGYSU ITiAwhqxG/GVRoUfN+rnXC4gQL72gjSJR685k1hvQohS/sajxvGENsBUiwgT+/DDhdRV ZXeUYKOcQ7n+wggQG9wjcdJb6CKhRmgcgPLLXNsSuACdRALNKm7uMInltaAV/tRWIvbl YuHeHk0Poud+2B0cmfeJIDoAXifc9ND69oqKGUQuc6AGU7zqPfnkf2fgS8JD9fIMBjV9 1dlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WyTGu0aN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z5-20020a4aae05000000b00589f9052ccesi3811675oom.31.2023.11.21.10.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 10:00:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WyTGu0aN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id AEA4C80A0E05; Tue, 21 Nov 2023 10:00:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234299AbjKUSAW (ORCPT + 99 others); Tue, 21 Nov 2023 13:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjKUSAV (ORCPT ); Tue, 21 Nov 2023 13:00:21 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 785B7193; Tue, 21 Nov 2023 10:00:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700589617; x=1732125617; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kR4j5LmmglSwWkcRVhfnSdc4lXlxN4xSDvWLYtbkvvg=; b=WyTGu0aNG+ifIMIorYAC7jOYtFWYvV8SaVejrLRflfI/Qqq7vIZ0+rUH M3P8n8Yc1yxgkdDVlvwplunMPdI7tqYBDLeaSvfSG/dq/8nvpRCtJCrQT Ojfs7l9YMcwRI1CgE2CSjXLh/fQF0M/kBc8hsej8v26cOb4Rup3LKozcT omABdtYODlqohs788Ftp19CZ8lXjjfGz8uNlXuq2XQVa0bQSEJsIpzVrA ne/l/FT9NVPrGQGXcom6Pc83flO1qgcwMgIEtoy4uWweyI6ax5UKpxAce mRAOyEKVf/D4vkQ6gdfCKVMwMd/h1lUV0zLBVUMHdwtjDni9FG4wEKMtT Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="391667759" X-IronPort-AV: E=Sophos;i="6.04,216,1695711600"; d="scan'208";a="391667759" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 10:00:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="884282984" X-IronPort-AV: E=Sophos;i="6.04,216,1695711600"; d="scan'208";a="884282984" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 10:00:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r5V2g-0000000Fske-0Ql3; Tue, 21 Nov 2023 20:00:10 +0200 Date: Tue, 21 Nov 2023 20:00:09 +0200 From: Andy Shevchenko To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , "David S . Miller" , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v3 3/3] serial: core: Move console character device handling from printk Message-ID: References: <20231121113203.61341-1-tony@atomide.com> <20231121113203.61341-4-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121113203.61341-4-tony@atomide.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 10:00:39 -0800 (PST) On Tue, Nov 21, 2023 at 01:31:57PM +0200, Tony Lindgren wrote: > There's no need for console_setup() to try to figure out the console > character device name for serial ports early on before uart_add_one_port() > has been called. And for early debug console we have earlycon. > > Let's handle the serial port specific commandline options in the serial > core subsystem and drop the handling from printk. The serial core > subsystem can just call add_preferred_console() when the serial port is > getting initialized. > > Note that eventually we may want to set up driver specific console quirk > handling for the serial port device drivers to use. But we need to figure > out which driver(s) need to call the quirk. So for now, we just move the > sparc quirk and handle it directly. ... > + ret = add_preferred_console_match(name, drv->dev_name, port->line); > + if (ret && ret != -ENOENT) > + return ret; > + > + return 0; 2nd time and so on, perhaps deserves a helper? static inline int add_preferred_console...(...) { int ret; ret = add_preferred_console_match(name, drv->dev_name, port->line); if (ret == -ENOENT) return 0; return ret; } ? -- With Best Regards, Andy Shevchenko