Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 21 Nov 2023 14:52:32 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev,
        baolu.lu@linux.intel.com, linux-kernel@vger.kernel.org,
        jsnitsel@redhat.com
Subject: Re: [PATCH v6 3/7] iommu: Validate that devices match domains
Message-ID: <20231121185232.GI6083@nvidia.com>
References: <cover.1700589539.git.robin.murphy@arm.com>
 <097c6f30480e4efe12195d00ba0e84ea4837fb4c.1700589539.git.robin.murphy@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <097c6f30480e4efe12195d00ba0e84ea4837fb4c.1700589539.git.robin.murphy@arm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cED4UDMIR9w88RvdiukQzTQDIet4viiwtT/RjZeGxcRZVdF71LuwolMqHah8?=
 =?us-ascii?Q?YltaO3RTrkTxCBbRIVWMH4Oo8mIir6Iba0oyUEarUwe1/nyEELLYAVqKNdCM?=
 =?us-ascii?Q?+tAJ3JRtHocKn4mLG/EHpS9iQjOBQTrYn1nNr5HvfAnCzW+DY+Zv+m7Y7YpR?=
 =?us-ascii?Q?vJlyCY3tiz8kunMGeOC7PSKealNQZlF1ag9adi2X3g1LwrFXQ9KxFqe7SHPY?=
 =?us-ascii?Q?sJVWkmv5YUHLp+VpfgmzU8Q9fyXLx4gqJSLSwpcSsy7zSv7HScBp+DJZ+vHV?=
 =?us-ascii?Q?XGUHZWhj0oqE1h4GQYZpsw/ZzE+jlHf2Jsr7nxI1xyNk/kg9ZVrlwQSOFmda?=
 =?us-ascii?Q?XZy68ql0/QDFTs2OGiysz3JVdXEnT33bs2YGspDDb0nHJ0SbS/8C9HOE1+J7?=
 =?us-ascii?Q?hJqnDHrRCUHffPlZ/R3O6U2IbTY/ukPj5wEVBW2oXUx7BcOFetxr55+TwX7d?=
 =?us-ascii?Q?0Z0mrv8I+vXM+b71DfjleXDBrJ+8aL5Cq4VfJBcZ5RC+3TIhLuo1623yWh9U?=
 =?us-ascii?Q?82CH+GgvhtuhYHgAGHQJrjk+Xv8jg/uNdttIfUWJ9m+18cx5Dr908UU3SW/P?=
 =?us-ascii?Q?t0mN5NVC4XSh1Eti504FkRYgafhQIrqbm792IfAOsgQs1MabUOr9di02q+NN?=
 =?us-ascii?Q?ZV3VTC8fQnY5+OQ5Q+EFY8dx1nhd648MEQNZ9LXyivUhqj3P/kwAlGHfqCfk?=
 =?us-ascii?Q?PTCaJBy1Jv7q5vDIHPdsRA7rtgmv/F1nB37sn6I9VXsGWX5AuIzB4xTU/LJZ?=
 =?us-ascii?Q?R+hLkx4naCL0TYxg+4po4evEgKtN78bpwPlBQ6IrPN+xaLSqcKASnwOIwA7o?=
 =?us-ascii?Q?QXppmHUwQ0NiNwnc+KXadfErYSKTdRMylkJvtKbd26py68r46geRb4Mo9xom?=
 =?us-ascii?Q?ttaVJ0qgnQ8G+HuKwmmunl9ikiBLIb3uFVb/InOT6z8jE93u8kZ0/jHE0pXD?=
 =?us-ascii?Q?Am0Ik8L7vKBN4otQdU1RzGY+2eORFzXBQPrF7GTmkeh8+B/A/80lHErmdF8h?=
 =?us-ascii?Q?hfS3OH3D9Y+FNHTeqA/9GIVIRqdn54jkSubvBODA0pRSPKMdYP4zuCOIp4fp?=
 =?us-ascii?Q?XzrrKGBO4UyQJ2Tu8bVy8LBkTPypgBc6cpGM12PD96iuoS9XYyK1jn7l0Jcc?=
 =?us-ascii?Q?JSRh5t/S8wKfDN977KjpMwtbfrE7gKkVER//d+YmycRLLJbBEix+E4U1Kf3k?=
 =?us-ascii?Q?XEvtwe/CzbKVlwLlg95bMDwxK0+bnnH6jv8jaVhAR3ovZGsrFf7QqixFl1WQ?=
 =?us-ascii?Q?AsnFvuFRbRvJLpLksOrPOTz6Kwiu20lTZpUBpZTv5nO6JaYDxQVB8zSuML+K?=
 =?us-ascii?Q?Mi2m0oDwDb71xtpQmoDJob7YUqVZshziC1wC8JhEoH3IVaMQ2TCnjXzbT5d2?=
 =?us-ascii?Q?l0KUykHI/clnM7MDSzFPq7J1XB9Cp2/d5T+Nn5BTF/gevJtc/1pjot7Hpvst?=
 =?us-ascii?Q?Hpm5AonQrWlw2sL76Fc8tNtrnVnxjN8GGNQvVOa+gn/Sww4ohlnUE5Bh7G4p?=
 =?us-ascii?Q?n4lhEtUOmpTvtPzkaRS61E7PLMBe2YutOts2gXuCepjRPUr5DNJlGGmwHTOP?=
 =?us-ascii?Q?nRHAD6p4B/KQYCIuR9pBn7Bq5zDWxd15Cc/S+SLD?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2087bb5d-c438-4556-2d36-08dbeac305d4
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 18:52:34.1457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZT60stN3JYEmujBprLfCJJeF3RwvKGC5A7W4aBflXHPsXS18+jGwbjT26+ogdTGV
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8368
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 21 Nov 2023 10:52:49 -0800 (PST)

On Tue, Nov 21, 2023 at 06:03:59PM +0000, Robin Murphy wrote:
> Before we can allow drivers to coexist, we need to make sure that one
> driver's domain ops can't misinterpret another driver's dev_iommu_priv
> data. To that end, add a token to the domain so we can remember how it
> was allocated - for now this may as well be the device ops, since they
> still correlate 1:1 with drivers. We can trust ourselves for internal
> default domain attachment, so add checks to cover all the public attach
> interfaces.
> 
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> 
> ---
> 
> v4: Cover iommu_attach_device_pasid() as well, and improve robustness
>     against theoretical attempts to attach a noiommu group.
> v6: Cover new iommu_domain_alloc_user() sites as well. I don't entirely
>     dislike the idea of tying this into the domain ops, but I'd rather
>     do the simple thing for now and revisit that in future, since domain
>     ops also deserve some other cleanup.

Looks good

Jason