Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Tue, 21 Nov 2023 11:15:57 -0800
From:   Isaku Yamahata <isaku.yamahata@linux.intel.com>
To:     Binbin Wu <binbin.wu@linux.intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
        Sean Christopherson <seanjc@google.com>,
        Sagi Shahar <sagis@google.com>,
        David Matlack <dmatlack@google.com>,
        Kai Huang <kai.huang@intel.com>,
        Zhi Wang <zhi.wang.linux@gmail.com>, chen.bo@intel.com,
        hang.yuan@intel.com, tina.zhang@intel.com,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v17 020/116] KVM: TDX: create/destroy VM structure
Message-ID: <20231121191557.GI1109547@ls.amr.corp.intel.com>
References: <cover.1699368322.git.isaku.yamahata@intel.com>
 <997a92e4f667b497166ff8cc777ec8025b0f22bc.1699368322.git.isaku.yamahata@intel.com>
 <2a5a38d9-28e2-4718-b8fc-2b8f27610706@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2a5a38d9-28e2-4718-b8fc-2b8f27610706@linux.intel.com>
Precedence: bulk

On Sun, Nov 19, 2023 at 02:30:19PM +0800,
Binbin Wu <binbin.wu@linux.intel.com> wrote:

> > +static int tdx_reclaim_page(hpa_t pa)
> > +{
> > +	int r;
> > +
> > +	r = __tdx_reclaim_page(pa);
> > +	if (!r)
> > +		tdx_clear_page(pa);
> > +	return r;
> > +}
> > +
> > +static void tdx_reclaim_td_page(unsigned long td_page_pa)
> 
> This function is used to reclaim td control sturcture pages like TDCX,
> TDVPX,
> TDVPR. Should this function name be more specific?
> For me, it is a bit confusing.
> 
> Or maybe do "td page" have specific meaning referring to these control
> structures
> pages in TDX?

As they are control page, how about tdx_reclaim_control_page()?
-- 
Isaku Yamahata <isaku.yamahata@linux.intel.com>