Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp619906rdf; Tue, 21 Nov 2023 11:20:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IFKUswibaWkdSDNUjYnTQsiRE7g1U7CZGjJJlKQolVKNJFrIPpyBOo0cvOqEwuQDJmqEDfu X-Received: by 2002:a17:90b:4a49:b0:27d:3a3e:3a45 with SMTP id lb9-20020a17090b4a4900b0027d3a3e3a45mr174701pjb.44.1700594431212; Tue, 21 Nov 2023 11:20:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700594431; cv=none; d=google.com; s=arc-20160816; b=VafHEdLNZD9Knuyt9BIO9Wchr/0VYuNjzMS+x/tmUME+n0s78F/FEbAsew2jAtWUoN viSJepOmXzzRtcNpY5mwShR0RyFsoj/EmJN6jhpcM80JFFa5JZbWhXcFJPlh0OJAusum WcJJJrTB0AEd6fI8vqiMXcUIUTsUvNY0F/5onPEVd6939T7oQb3hXbB5wrLpqyIpJojw j2kzfOXL2N53ZRg3LjJVYY7O+uoqOeWAPTifm00dBER41MeXQBfsWhk441CbRhmsJobH 1sEy7osk/T1ZLZaEEVu9KFDHvhVbVSrrNfefF1MVuSk3FaHuW2CqXT4rKny1A2AjG9IG zGfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Qnzk+YdDT/TajVq3uEn+s3Ab6sgLH59dF35WcWJ7Ujc=; fh=SvP5MdOsByb2jilamOOXU8cSW2EvH6TR9qJ+zzPe2Og=; b=q1wU+X6R8ZSmapx2MR/SeHxyfSp4ibxTJjitO+RhQ7ypZVa8J+1V8UbZQZ8VfgYxF+ Szp8x+N9oZ8K4mQtH8xZCz4aFGp0VETsPE5fiFwDgPFPxZaGq0+y4+2p199K+2Y5dRr5 XpVxKeUQk1enmOYQ40kuMRf5rMgyd3K4K6Ws+/MTMBJqJeATjbEDizB8hserTXeRc7in PDvZFnAIGo0nST3ItQ48gOMB0I77B96uIzq3DP7b9FAqjKiKx00sILlPC63ZEv5Td58W UF60A+PpXdn10r324lFgQCEaZpxCrvmMMvP7Qc++n8gfZ1TEq5yX8T3GF+yG6I1BaV/z OBpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tp3D93Lo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id om2-20020a17090b3a8200b002805a422743si11003851pjb.12.2023.11.21.11.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 11:20:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tp3D93Lo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 35079801D480; Tue, 21 Nov 2023 11:20:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230508AbjKUTU3 (ORCPT + 99 others); Tue, 21 Nov 2023 14:20:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjKUTU2 (ORCPT ); Tue, 21 Nov 2023 14:20:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA409113 for ; Tue, 21 Nov 2023 11:20:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6769AC433C7; Tue, 21 Nov 2023 19:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700594424; bh=EBK1q+oe+c4i9o37VMayPNOAfNEEFOG6EZD0cEsQE6s=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=tp3D93Lofo2iLhrKTpzTvy2Y8ywhNK52/c6y9RRmvNYZCMC9Y3JoFYGjIkwisKgPq KN/M2WIFrZZAsN17x8ZALH6HO0f04RP4XKt7CA8RUMSJ41fPJbGQVxAGioUqdAHtGO ZpAnt5ungxlKyIihIaC4W0YU5JJjHg5cemDgF6xEsnECnlU9jkhL31WSuHjJA11Aj/ wB1LTkj6dcSCS9C4MfZV4vfs1OXLWnWjJ08U7CJ6NWx2WhTNvkg/2x3cidHqwp3How Wkz73CpK3rAAllzssxyU1vank8G3+FxeaWmkh/giH8nmeyfu141LjfcyZO9f5B8ZkP dP4RiH2HSKpig== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 505ECEAA955; Tue, 21 Nov 2023 19:20:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf-next v3 0/4] selftests/bpf: Update multiple prog_tests to use ASSERT_ macros From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170059442432.1779.10625462603877960408.git-patchwork-notify@kernel.org> Date: Tue, 21 Nov 2023 19:20:24 +0000 References: In-Reply-To: To: Yuran Pereira Cc: bpf@vger.kernel.org, andrii@kernel.org, ast@kernel.org, haoluo@google.com, john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, martin.lau@linux.dev, mykolal@fb.com, sdf@google.com, shuah@kernel.org, song@kernel.org, yonghong.song@linux.dev X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 11:20:30 -0800 (PST) Hello: This series was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Tue, 21 Nov 2023 05:33:14 +0530 you wrote: > Multiple files/programs in `tools/testing/selftests/bpf/prog_tests/` still > heavily use the `CHECK` macro, even when better `ASSERT_` alternatives are > available. > > As it was already pointed out by Yonghong Song [1] in the bpf selftests the use > of the ASSERT_* series of macros is preferred over the CHECK macro. > > [...] Here is the summary with links: - [bpf-next,v3,1/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bpf_tcp_ca https://git.kernel.org/bpf/bpf-next/c/b0e2a0395312 - [bpf-next,v3,2/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bind_perm https://git.kernel.org/bpf/bpf-next/c/3ec1114a9745 - [bpf-next,v3,3/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in bpf_obj_id https://git.kernel.org/bpf/bpf-next/c/f125d09b99fc - [bpf-next,v3,4/4] selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in vmlinux https://git.kernel.org/bpf/bpf-next/c/3ece0e85f679 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html