Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231121010318.524570-1-nickrterrell@gmail.com>
 <20231121010318.524570-3-nickrterrell@gmail.com> <CAHk-=whL+1xR_LJwJ7DRhFo2gkDv0jrRMX5PJoULoSBXppEV8A@mail.gmail.com>
 <D42705E6-94D3-4E3B-9BA8-AFFCE4B8E4E4@meta.com>
In-Reply-To: <D42705E6-94D3-4E3B-9BA8-AFFCE4B8E4E4@meta.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue, 21 Nov 2023 12:12:41 -0800
Message-ID: <CAHk-=wjcft4VEVBwSeaczuonUAGyT4BKt5PimekDpL9ygHC5cg@mail.gmail.com>
Subject: Re: [PATCH 2/2] zstd: Backport Huffman speed improvement from upstream
To:     Nick Terrell <terrelln@meta.com>
Cc:     Nick Terrell <nickrterrell@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Yann Collet <cyan@meta.com>,
        Kernel Team <kernel-team@meta.com>,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 21 Nov 2023 at 11:59, Nick Terrell <terrelln@meta.com> wrote:
>
> W.r.t. do { } while (0), our older Visual Studios CI jobs failed on the
> do { } while (0) macros, because it complained about constant false
> branches.

Wow. That is some truly incompetent compiler people.

I mean, really. As in "Why would you ever use that kind of garbage"
incompetence.

Honestly, any coding rule that includes "don't use the do-while-zero
construct" is actively broken shit.

Please just fix your upstream rules. Because they are incredible garbage.

               Linus