Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231121010318.524570-1-nickrterrell@gmail.com>
 <20231121010318.524570-3-nickrterrell@gmail.com> <CAHk-=whL+1xR_LJwJ7DRhFo2gkDv0jrRMX5PJoULoSBXppEV8A@mail.gmail.com>
 <D42705E6-94D3-4E3B-9BA8-AFFCE4B8E4E4@meta.com> <CAHk-=wjcft4VEVBwSeaczuonUAGyT4BKt5PimekDpL9ygHC5cg@mail.gmail.com>
 <41F084AA-F027-4288-9F26-E33337E1516A@meta.com>
In-Reply-To: <41F084AA-F027-4288-9F26-E33337E1516A@meta.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue, 21 Nov 2023 12:54:57 -0800
Message-ID: <CAHk-=wgF4ooJa18rYNZZQucn4YvVv+f1PCzm35_WHysyeEL+ng@mail.gmail.com>
Subject: Re: [PATCH 2/2] zstd: Backport Huffman speed improvement from upstream
To:     Nick Terrell <terrelln@meta.com>
Cc:     Nick Terrell <nickrterrell@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Yann Collet <cyan@meta.com>,
        Kernel Team <kernel-team@meta.com>,
        Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 21 Nov 2023 at 12:35, Nick Terrell <terrelln@meta.com> wrote:
> >
> > Honestly, any coding rule that includes "don't use the do-while-zero
> > construct" is actively broken shit.
> >
> > Please just fix your upstream rules. Because they are incredible garbag=
e.
>
> Yeah, that=E2=80=99s the plan. Visual Studios fixed that compiler bug in =
VS2015 [0],
> so we should be safe to migrate to safer macros.

I don't even use MSVS, but a minute of googling shows that you should
never have done that silly "avoid sane C", and you should always just
have done

  #pragma warning (disable: 4127)

for MSVC.

Honestly, the fact that the result was instead to disable that
standard - and required - construct in the project makes me worry
about the whole zstd thing. WTF?

The do-while-zero construct is _so_ important that there are (sane)
projects that literally *require* the use of it. See for example MISRA
code safety rules.

The kernel rules aren't quite that strict, but yes, do-while-zero is
very much "you should *absolutely* do this" along with all the usual
"make sure you have parentheses around macro arguments" rules.

We had some RFC patches for this area:

   https://lore.kernel.org/all/20230511152951.1970870-1-mathieu.desnoyers@e=
fficios.com/

And on that note, when I googled for the solution to the MSVC brain
damage, I was distressed by how many hits I saw where people thought
the do-while-zero pattern was some "legacy pattern".

That just shows that there are lots of incompetent people simply do
not understand why it's actually *required* for reliable parsing of
macros.  This is not some "historical stylistic" issue, it's literally
a correctness issue for generic macro usage.

           Linus