Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Tue, 21 Nov 2023 13:04:06 -0800
From:   Saeed Mahameed <saeedm@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Saeed Mahameed <saeed@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>, Leonid Bloch <lbloch@nvidia.com>,
        Itay Avraham <itayavr@nvidia.com>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH V3 5/5] misc: mlx5ctl: Add umem reg/unreg ioctl
Message-ID: <ZV0bRpnhu/zWieTT@x130>
References: <20231121070619.9836-1-saeed@kernel.org>
 <20231121070619.9836-6-saeed@kernel.org>
 <20231121124456.7a6388c6@kernel.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20231121124456.7a6388c6@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RqAA3ri3wg9fPd+CqA7J1yt9rMtT1lCNwuEA80Q7l7NDUNKkGSUytvjPOi9B?=
 =?us-ascii?Q?McA8sm0ynK5vcqtE4TXQYkbhKWdy1hemYvxWdI8oZqV1GJEWF8aTHjplCYK/?=
 =?us-ascii?Q?Tq2joq4MJDJZfwAFmK7qjDMfm5O+zmCUIX2uxy/cZLWVhbneCjOnJvDHAJx+?=
 =?us-ascii?Q?xV3/p4pODfMYeGBTQfRIsZTW3kqtbMDu0qmZmmC3PkmK5nhxosJAFZ/ii4G9?=
 =?us-ascii?Q?UySqPP9k0mNS5g7ugLN/aRvFZ6y5U32RHO3lxR4d31QpuCWJ+p3j87JJiaJW?=
 =?us-ascii?Q?Qe0byfmBfMfwagzVCEZ3KijbgSuqqzY5s69OjZMVi4B7VhymixHpHKu8IVnj?=
 =?us-ascii?Q?QxGLOIJ1RJuQyImjAQ96WNFb8fq+rfyv/FpjE1IvQn5BJldrrXkpjY5IbL+s?=
 =?us-ascii?Q?wIlekZsboBeyMh9vtjmEgicTTTzqoukljDnWDLM0jBFDlzuSBV2rIzHyAhcf?=
 =?us-ascii?Q?cavQ0x6NPvaYF88ITexP6IB12F5shwfDnVid8bQGQPdMOh2ogNfydYpEWEIh?=
 =?us-ascii?Q?BZHfRRlGj+buRvu9p9vum5H9L6Hdc3qlpDNQFxpRuGxhMIFhmLVJ9YUGh1iM?=
 =?us-ascii?Q?6mW0OWm9+lQbnR9mflI62h4OnxQPsRHSBXtDA0Lyju5uKtg4SJluTpVNjuop?=
 =?us-ascii?Q?d8onL+Y4deiTP09yqq7Tc6o4eL1+8McA8esi33LI+r5WMgVsALnxj/hcoIL5?=
 =?us-ascii?Q?vvtvxura3AFYcvI3jPbrt6/Hd1kMfMdHtV06NSvDs7BwuLjRdvY+674VDMET?=
 =?us-ascii?Q?nIVFXJK/PtQABHLY7oWErv3/e9aHzgzG0Ajs2Ja/PP6eIFDMqiiQqIznyzd7?=
 =?us-ascii?Q?pd019JiG6SjSU/8WhnZIF6qPFKUGSbGaFDs2hXKsvin6rZibKrBiYJfEh707?=
 =?us-ascii?Q?boUeQaoiiHALSQ6VLOSIE8FkEWCSyOVL5LmBOS6ZQgX2dzdasOcxgVwoA5zF?=
 =?us-ascii?Q?zDnFV6TfPZEvH+3e67QSnE66SlSeg1EOhTFmWckaTP6ymyDf0w8A50BxgGxW?=
 =?us-ascii?Q?VPNPZvmws1aUECTUBjycVd7/ujFeefBynIBTaG+tS0uXwfgOaKDcA918fYP1?=
 =?us-ascii?Q?nI+cbnvS14G98pFYNOgszk81Ca11lM20DxV+azOrFKkRuB93Zk3y/KKWGOW6?=
 =?us-ascii?Q?ctSEMpJRc0prg4SBajLC/8DAKxkdUNZjL/GuuGT1f91Izeoph8sP5HbfXSM6?=
 =?us-ascii?Q?2RF/Ed/0vtzUpidebzVUcGD8Cr/Nw0ul8TQLiWjV4ZGScaal/BBQwFlLZ/Cv?=
 =?us-ascii?Q?uCOJNJLCTmOsNzQkO4WRXKKL87xN2BLy+eV0pP3a7dn6aCOQxzmfnA05E6SI?=
 =?us-ascii?Q?kkg013UGO4BKytiPcaxa4icRRZU7vV8jm2xkxiciZ4wEj13al/zW+rYVkiNY?=
 =?us-ascii?Q?WSeouXZBqp4KSFSrPF+fncETLJ41lz4OqrE5MZ6beKdzsGny6QMAA3UU9Zua?=
 =?us-ascii?Q?BgLZ3+Ih5ww1dfcOmlWimUNL0ALLq8442LO8Db5IhQvtv1T4KlY5Q642iNHY?=
 =?us-ascii?Q?0bsphjT74qJDwNTVfEf8l7zn3d4lOdUpZBRk7G8fyqIMN4qSFfqKd/EG9vhP?=
 =?us-ascii?Q?AhRGj9t9dZuH/SNZu+DXZoZCn9mv+1FNnlsnAYJ+?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 026ab28e-7c69-45f1-820b-08dbead56717
X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9134.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 21:04:08.8001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HJ5fw/FEWZ99Fq3dwTPiVw5CdbTO4sICvY+tUMBDO7uviy6mf1CWuXGkpmgWoCmcYzD+uncIIYbr2GTb6hjxCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5734
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 13:04:34 -0800 (PST)

On 21 Nov 12:44, Jakub Kicinski wrote:
>On Mon, 20 Nov 2023 23:06:19 -0800 Saeed Mahameed wrote:
>> high frequency diagnostic counters
>
>So is it a debug driver or not a debug driver?
>

High frequency _diagnostic_ counters are a very useful tool for
debugging a high performance chip. So yes this is for diagnostics/debug.

>Because I'm pretty sure some people want to have access to high freq
>counters in production, across their fleet. What's worse David Ahern
>has been pitching a way of exposing device counters which would be
>common across netdev.
>

This is not netdev, this driver is to support ConnectX chips and SoCs
with any stack, netdev/rdma/vdpa/virtio and internal chip units and
acceleration engines, add to that ARM core diagnostics in case of
Blue-Field DPUs. 

I am not looking for counting netdev ethernet packets in this driver.

I am also pretty sure David will also want an interface to access other
than netdev counters, to get more visibility on how a specific chip is
behaving.

>Definite nack on this patch.

Based on what ?