Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp711567rdf; Tue, 21 Nov 2023 14:30:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IFG/3DdBb+V2X0MIF7c8/dSRREpE8mHxVQZNFOctIP59ioFJatullC3xalHf1EST3igQQVs X-Received: by 2002:a05:6a00:198e:b0:6b8:a6d6:f51a with SMTP id d14-20020a056a00198e00b006b8a6d6f51amr623774pfl.31.1700605856634; Tue, 21 Nov 2023 14:30:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700605856; cv=none; d=google.com; s=arc-20160816; b=n84PhRoHdGGUEY4raTUCsjw0kt1Gx1483lMGgN3WuW1GgkTn5mbeylXrX6Wrj0Heky bd0oUjaAYrRkNGOiQrdmcL3AKCJCQNs+8qyHqZLBL6MvsJjfmhf6W8SHw2sJgSTkwZ8p UomR4NugXdK+mL51A4bC6PUjQlJD7YFdJZBtYmlwk9TdEZFd4UrJAhH5IlrU/pWp60LL 83fQj8XgGseMogDThXy0QYF+CdirIKQaC3dyDi4ksEoW8YQ+5mHFyU3iOqsNTYic3fOD tIX2pIxzVmjEpilLUGS6TwoD81Aoy4OUmu6rz94nNMFiBI8B+VURU8zCx0fyqHaCo3ln ojGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=IURVujOwDyZmIl3WawFqyWSh5gpy1voE9UO1BS2n2Mk=; fh=EWJ0TKrgac8pGmh4+h68xQQLbHPzePiE+KKWgyaboAw=; b=D4Z7wncZwkn2ilh5gPP4ytYlbZVDzsGdguem7KxfPo+M3Wwv1YGX8U/OuaZuRxVl0C yzhAxh4cXNOLYj86nZnobtmsnXHcrVIzPLrGfVcLW8vLSBnWklk1S8FUW4epNd0WIlcp ytQnw5Qsy+Zb05H0cboeAM1aYLQViniAab71wzFsO7qc2vx4WwAJzHPJjJ+yZYO1egtV PDa+5nrYbJR0nfdF5SrJLGZxdfQrzAoNhEyKb2KxXOxxms0022GV3/GRLMyJnHgzneUM Jcrf3mzbw/FHZfze/SdL+Ug11/T88P8VWxRVLL5VoHCQDklhe4w20Sp8b+RvUJ5GABtP qofg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U4TUrZed; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id fi31-20020a056a00399f00b0068fd7cb5864si11714072pfb.263.2023.11.21.14.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 14:30:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U4TUrZed; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E6E0D8077A7B; Tue, 21 Nov 2023 14:30:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbjKUWaG (ORCPT + 99 others); Tue, 21 Nov 2023 17:30:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjKUWaG (ORCPT ); Tue, 21 Nov 2023 17:30:06 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0488119E for ; Tue, 21 Nov 2023 14:30:03 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A45EC433C8; Tue, 21 Nov 2023 22:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700605802; bh=j7aU0i8BzZ0LWN5tC676qAeLCJLeUSdku5k+b6N9i6U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U4TUrZedEFvbcBlmmpC9Gs1a7TVbDWGT56xCuhYva+NYZSlcBAYnXPnatx2olRHoy cGv4loLsDlRqCfWUG4NJs52rF1IbrFzMPv5N1ZaQSL+x2v0dd16kkgOSQVSKJ8m/Gu OXqU5f4nxSrOyWjFTI1flvbSjMS8ws5A/ie76W8mLhulU6EJg4vMGuuEgLgstfVu/m mOgc6GD6PxJ12mT1n1nKNf2jl5FJ/YO4XeCR+HOGolPXaG1VprGtKY+N2bui/EB/g1 v8KdRswzCcUSyLg6JRj7e+GFfYIHSAvLwaucVUBuJCnhBqu5xCtP2b6dE3G6Wux2Jx HAfvsv8hprMNw== Date: Tue, 21 Nov 2023 14:30:01 -0800 From: Jakub Kicinski To: "Jiri Slaby (SUSE)" Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 09/17] tty: hso: don't emit load/unload info to the log Message-ID: <20231121143001.4990312c@kernel.org> In-Reply-To: <20231121092258.9334-10-jirislaby@kernel.org> References: <20231121092258.9334-1-jirislaby@kernel.org> <20231121092258.9334-10-jirislaby@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 21 Nov 2023 14:30:13 -0800 (PST) On Tue, 21 Nov 2023 10:22:50 +0100 Jiri Slaby (SUSE) wrote: > It's preferred NOT to emit anything during the module load and unload > (in case the un/load was successful). So drop these prints from hso > along with global 'version'. It even contains no version after all. > > Signed-off-by: Jiri Slaby (SUSE) > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski Acked-by: Jakub Kicinski