Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <f90bc4fc-d9e3-468c-8b94-73bea4b2d764@intel.com>
Date:   Tue, 21 Nov 2023 15:05:11 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH iwl-next v3 3/5] i40e: Add helpers to find VSI and VEB by
 SEID and use them
To:     Ivan Vecera <ivecera@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <linux-kernel@vger.kernel.org>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Wojciech Drewek <wojciech.drewek@intel.com>,
        Simon Horman <horms@kernel.org>, <mschmidt@redhat.com>,
        <netdev@vger.kernel.org>
References: <20231116152114.88515-1-ivecera@redhat.com>
 <20231116152114.88515-4-ivecera@redhat.com>
Content-Language: en-US
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20231116152114.88515-4-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE5La3lLRUo5b3FuV0RhYzkrVlRKbkx0U1lCUXpKZm9GQmdxZ0pRb25mbTg1?=
 =?utf-8?B?ZmE1UnowWFJjb1dRQkM5VStvZXVKTU1neEpKWXJKa2dGUWp4N0JsVUU2Y2RX?=
 =?utf-8?B?U1FhWWg4V2RRS1MrNkNFbjVlYXVwQWhSMHhTaC8waVNJSFZwOTNlc1lZZEFH?=
 =?utf-8?B?blZlTFN3RSsxY1ZEMTM2Uk1mdVJKUUg5STBxTW1JeU5JcjNDQTVCOFVLZFlP?=
 =?utf-8?B?U1FUYjVsMjBIVXIraUFtUnZvMXFnM2FWZzExYWliT2ZHOUhrdXhHdzNFcUlG?=
 =?utf-8?B?bWtuZ25OT0RXVmRkT2lsenQwSWFwajFCdUd3eTNZZCtuK1JZdmZ0cE9MczVM?=
 =?utf-8?B?QTFHWWVWRlRwa2Z5cEd0eTFFMzgwTnpQeEdQMHJQTUNiNE5ycVh4TlpXaHpD?=
 =?utf-8?B?a0QzdmZta3dhMVZGWDJXOENuS1lsY2pHRDdPNEo5Ymt0U3JmNjZZV3V6QXc5?=
 =?utf-8?B?c1B1bGdoZkxGVUk2OG5KWU5FS0s1NDVRVUdrYkk2bGx2ZEhJUEQrdDBXam5m?=
 =?utf-8?B?RUxMYVpzUEtGVEtKOHBwMFNtRTdhc2xPdkRvNFI4aTBwY0tYaWYvcEw2UVJk?=
 =?utf-8?B?VU5uVS9ldTdNcTJidGtTWkUrR2hXV1BDSkxib0pMd0hEK3hmcUlmdFdyVnIv?=
 =?utf-8?B?cnJPSW9OTW5TTklsaUs0bEtEaDJYeGloYUQ3ODBKYXplL2JHNDI3ZmZ1Zmoz?=
 =?utf-8?B?ai8ydVZkWDFjekUrVWllQm9Tb1JkMXZ3UkJqNEEyOG4vZU1ZajBkRGsvVTZP?=
 =?utf-8?B?SHZFam5GNDdkRmY4bFFEd1dlSWw3eGorNWZIQjUyZHhwdjhMN3MycEhSK0J3?=
 =?utf-8?B?SjRlV29VL0RJS0RkRndOS2FYaSt4WWFjeU95VHFVV0xCdkRCQTBqTnFSQmFw?=
 =?utf-8?B?YXZxdHIvckJwaSt3eDRtb1JJa3A4cloyU1VEeU1UekFmOUlvTTJGSWpFZG9E?=
 =?utf-8?B?a1MvODVZSHVEY2RQMUw1c1gwY2JIV3RYYmlGZnJja1QyN3VlY0ltU21aZlFD?=
 =?utf-8?B?M2NyVFlLNmgvR1pUNzNlZkE2WG02aHZUOVpHZFFOcXZpTGZFRjBZWVE2U2dR?=
 =?utf-8?B?MWhaUFpwcnNnYWhuVGc1cVNWMG5IVWlvdFRNRy8wa1hOTHdnSVVaQk5oQ0ti?=
 =?utf-8?B?YVl2S0dlNzI2aXlLbHIrYWxaRWJHb0N1SUh5KzRTS1UyeXpqZnBic0c4ZUt6?=
 =?utf-8?B?bFdheFBXQlgxZTBFR1lnZDM2MVNMa1JmNlQ0OEc4cGhGV0pmenphVTdrWEs2?=
 =?utf-8?B?TFp6ZXlPbzVTT3VwN3ZzcG5SMnBDTCtRTVI0aDdSTUI5NlBrNDhLOTNuZ0p2?=
 =?utf-8?B?NHlYWGNEY1l2T25sbXl1VjllMEZ6MnJZMWRhWWdsTVc5d092MVdvc05saC83?=
 =?utf-8?B?disrNkFuWmY2aHhseEpIdnU0VjN5cXFoQzNHbEVSa1pPY2FxZ0o2eStkQ0Fp?=
 =?utf-8?B?U0hWR3JBdG1jcmNXL1k2R2hER0xZbGtkVHYvdlpDcnZnTnh1WkFaV1hSYVY0?=
 =?utf-8?B?ZFdndTVNU0FBRGNzRDEzTVJMTDVaY1Q3THNFL1ZQMFdHb2pMckRJYlJHZnFF?=
 =?utf-8?B?a002SGpVOUVlQXo0NWJJOHJOTEVHckZ1bEozKzFqQVBEZnhSS2phRStQVHc5?=
 =?utf-8?B?a0RoYzczVjMyaEx6Vlo5anZHbmFIWnZpYUUySUc3MFREY2kwYkhpbUdBcXY1?=
 =?utf-8?B?d0ptL2QvcXYyOWJZRm5EaHBoY1oyV0ZuOHY3N1ZrakRYNXM1U3VPeUdrc0h3?=
 =?utf-8?B?NUgzR1k0c09uOEsyVlE2LzBZWWRaL2x3RXNiMEhyRVdtTDU0NGl3aCtxbi9V?=
 =?utf-8?B?MWFjTzN3RTgzcG1yeW5IVTVQZlZBbGh1VEh6QnBMUUpHNXlJTkQwNkZQRnln?=
 =?utf-8?B?cDlrVDltYUhjcXBwV0VKMXhEMU16U05aMWlveis2eEljWndxTTZOV3hoVDkr?=
 =?utf-8?B?RFZqTHJOVnpTSkNJZ09UNXZTd0pkMmJnZzRjYWZnaStxRTVHYW1xUUhkUmJT?=
 =?utf-8?B?L09uMGliVXMwRENhRGxJT25jN3dhcnN4cThCbDBuaXE5OEc0b281QXZrZUc5?=
 =?utf-8?B?cVhRMGVoU01rWEE3MzlGVmMxTWx4bnI5WFRtbEM3UEkxczh5QllwdlFucHV3?=
 =?utf-8?B?L0xBZEZDTWcxVVhoY3pDQ3VLLzhGc3lWVkdCMm9WYmhZL2xFRDNSNURhWG5V?=
 =?utf-8?B?Wmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 98f44445-9a30-4658-2d96-08dbeae652a5
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6435.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 23:05:15.5350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oNSX19xq4see95dAMzU3Rwh7EASNhZDlemCRln93/x1cmotpY/jK/J7cLd6aNfbC/I0JrxD5ZY6TIAcYEpQuca0bIZGfYacAGoKJCd+Rq8I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5330
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 21 Nov 2023 15:05:47 -0800 (PST)


On 11/16/2023 7:21 AM, Ivan Vecera wrote:

> @@ -13197,17 +13193,14 @@ static int i40e_ndo_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
>   	struct i40e_vsi *vsi = np->vsi;
>   	struct i40e_pf *pf = vsi->back;
>   	struct i40e_veb *veb = NULL;
> -	int i;
>   
>   	/* Only for PF VSI for now */
>   	if (vsi->seid != pf->vsi[pf->lan_vsi]->seid)
>   		return -EOPNOTSUPP;
>   
>   	/* Find the HW bridge for the PF VSI */
> -	i40e_pf_for_each_veb(pf, i, veb)
> -		if (veb->seid == vsi->uplink_seid)
> -			break;
> -	if (i == I40E_MAX_VEB)
> +	veb = i40e_pf_get_veb_by_seid(pf, vsi->uplink_seid);
> +	if (!vsi)
>   		return 0;

In addition to the kdoc stuff that Simon pointed out. Should this null 
check be against veb?

>   	return ndo_dflt_bridge_getlink(skb, pid, seq, dev, veb->bridge_mode,