Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp794878rdf; Tue, 21 Nov 2023 17:42:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsCG92jlqT/9xeNj3CKTzTdyMGlHQrK2XojFvULE7SAMKH9c/lzzDkjQALsdUgGaoTS8l/ X-Received: by 2002:a9d:63c3:0:b0:6d7:d51f:86f3 with SMTP id e3-20020a9d63c3000000b006d7d51f86f3mr1289880otl.10.1700617375068; Tue, 21 Nov 2023 17:42:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700617375; cv=none; d=google.com; s=arc-20160816; b=I+txF/vcDUb1+DnMCrmViNlG8WB4K2BZ+mTubUrlI9VaxwZ8uczp6jD7FeBFNDqm40 Fs2+HUWQmq4gGSyR6nlrwJd7T4/577WVsZELD4wuSZA0Ws3/Tg/1DZ58cK9N5snbSfr5 h6hQNKo1NCs1I/fQQgJRLhcknge6Q+I9GrY94rkCoYSfj7HLA8oSDypM6NXE8I0C4uKP s4lTGy4KT7pbThrJ+JqhQEvTVY98S7GKhsVKDu9oq9Ey3x3zg7ianfP2Y+ewDutxeLQj EenSkz3eGggxYf3E4/DxoYqem1hTFgkLa1gFaZpKrAG+H8QcXW8PR3gU0Jh6Keorblos 6vFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=E3fAGw+d9Wmr7ftnpKkt5B1/vtb3iWU+zKezAb5YvOc=; fh=yeQMPg27UHNP7UP8uhWew1EalZEFNy6gjq+3l9m7wvc=; b=X9JcombuQzJj3UAUY09vFspRKLBN+ITs+oTfWjWOvsGFfCpDlJkCCrcTvOZPvay/ft YK/DItNPSMSq3eAGhv0BMRe5z2SzxVHVjzaiWmGXQo3YfZ42RNC2veumhMctL7rtyIgG c9oEB+2T1ZxoQo7BFNsfUoFqgEuWxaHHtJFl6RlGbVrAv/Eem08afKUJnEPGK0+B6H5b dnlbYQD4OhwcwoOrB1qOaEe5QnZVEqtuRzGfAeSzYGwhBWfJjYEUmALjGZz/XYx1qLDY GIbeH4JJ8SQ4hIDHrDhSr3UcUhbYbbDBMeFJkgHLsE5dOCl9LCbazyNwfNBxm5BJH4bj Wc/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id x1-20020a63fe41000000b005b8de051ac6si11416658pgj.111.2023.11.21.17.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 17:42:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 569758026B4C; Tue, 21 Nov 2023 17:42:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235052AbjKVBme (ORCPT + 99 others); Tue, 21 Nov 2023 20:42:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjKVBmc (ORCPT ); Tue, 21 Nov 2023 20:42:32 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C93DDD; Tue, 21 Nov 2023 17:42:26 -0800 (PST) X-UUID: 56764a2aa4d047c38f14754d997f3d46-20231122 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:221a0807-ac66-439a-ba02-0d2e78cf7bc5,IP:15, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:25 X-CID-INFO: VERSION:1.1.32,REQID:221a0807-ac66-439a-ba02-0d2e78cf7bc5,IP:15,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:25 X-CID-META: VersionHash:5f78ec9,CLOUDID:0305ec72-1bd3-4f48-b671-ada88705968c,B ulkID:231122094217U0J17LEI,BulkQuantity:0,Recheck:0,SF:66|38|24|17|19|44|1 02,TC:nil,Content:0,EDM:5,IP:-2,URL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil, COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI, TF_CID_SPAM_ULN X-UUID: 56764a2aa4d047c38f14754d997f3d46-20231122 X-User: chentao@kylinos.cn Received: from vt.. [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1824473249; Wed, 22 Nov 2023 09:42:17 +0800 From: Kunwu Chan To: gregkh@linuxfoundation.org, joel@jms.id.au, andrew@codeconstruct.com.au, andriy.shevchenko@linux.intel.com Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kunwu.chan@hotmail.com, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: [PATCH] usb: gadget: aspeed: Check return value of kasprintf in ast_vhub_alloc_epn Date: Wed, 22 Nov 2023 09:42:12 +0800 Message-Id: <20231122014212.304254-1-chentao@kylinos.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 17:42:52 -0800 (PST) kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Ensure the allocation was successful by checking the pointer validity. Signed-off-by: Kunwu Chan --- drivers/usb/gadget/udc/aspeed-vhub/epn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/udc/aspeed-vhub/epn.c b/drivers/usb/gadget/udc/aspeed-vhub/epn.c index 148d7ec3ebf4..e0854e878411 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/epn.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/epn.c @@ -826,6 +826,8 @@ struct ast_vhub_ep *ast_vhub_alloc_epn(struct ast_vhub_dev *d, u8 addr) ep->vhub = vhub; ep->ep.ops = &ast_vhub_epn_ops; ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", addr); + if (!ep->ep.name) + return NULL; d->epns[addr-1] = ep; ep->epn.g_idx = i; ep->epn.regs = vhub->regs + 0x200 + (i * 0x10); -- 2.34.1