Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To:     Samuel Holland <samuel.holland@sifive.com>
CC:     Ariane Keller <ariane.keller@tik.ee.ethz.ch>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Simek, Michal" <michal.simek@amd.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net] net: axienet: Fix check for partial TX checksum
Thread-Topic: [PATCH net] net: axienet: Fix check for partial TX checksum
Thread-Index: AQHaHNzERCLofLCv5UOLU+i8bfYF3LCFpijA
Date:   Wed, 22 Nov 2023 03:00:20 +0000
Message-ID: <MN0PR12MB5953E9C46E3927CD76E94C5AB7BAA@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <20231122004219.3504219-1-samuel.holland@sifive.com>
In-Reply-To: <20231122004219.3504219-1-samuel.holland@sifive.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ZmG20M9CtxniVpbQd7D2XVaxzWt7jpR+4+jhZWnCIntwG9S8mXGAswZIa8S?=
 =?us-ascii?Q?Er4e1WGtmzcdOvdTZiybP/OlXLG3k+8d3zLRLEhRSWJe+XGHljAyhY6VTQj9?=
 =?us-ascii?Q?AgTjh3e8YAEbWpqXGyQQ+KZLb9V7yaJuZ/hugw3WhWn7sGGmwbJyV8FS0+X/?=
 =?us-ascii?Q?aWyzKTGgYaxEdOvzIH6qch8o6JyUP3iCyd5X0HHb0xHXiIoP9hUDNN1RdojO?=
 =?us-ascii?Q?Kmo1rIE7FvWw0ysVFb+oa+ykCto5Lx/OznaYT582NAwl+r7flhJtsadDSKRl?=
 =?us-ascii?Q?ydDY5HKzY74kZEMc7iXnshereCzcTIIGRKFbe0B/Y9eq4iJVH1LZ8F48mV/z?=
 =?us-ascii?Q?Nhhs0GRsYMgdjaorf9IROfjR+MUudJuUdeqXcZAgul7tjbYiPbdMKiU7Qy40?=
 =?us-ascii?Q?pfONBvGYhXhz9VjV2MZZQKCzat4CXHs0mvBRew6WegO2ToGUC875UVC4+WGi?=
 =?us-ascii?Q?KOqgmW9BVDk2GC60FeP3RSybHZT+w9jsxfQ+cnsTjIr12r2U6kyCfyYkKZHE?=
 =?us-ascii?Q?iR0NVA9pKUAMY6iTI/2sy36dfy9gm+GGy9hEGCeNT2MwgOXonFq3NMlTq6TY?=
 =?us-ascii?Q?aLlz+3k5l1B2ZzqnLrDMpVmyTavlEFgggR8RxNZ022aJwDijojtjU0JAem8/?=
 =?us-ascii?Q?vWID8EpIdCglqjCH1J7hQ8UEXuWUurjIMihcxMXMNDI/mpdWtDjU+PlJ6tVV?=
 =?us-ascii?Q?oeXX0wS1yJNc403mVj1rE94L6feUmQtQPSaijAh2mvC0jnKxvchuDfr1DAIp?=
 =?us-ascii?Q?Rpw6084j11OvqTCwccq6vM6aDm9chMpajQvSpn3KicqkmQ9kf8kchV2ICGbW?=
 =?us-ascii?Q?ZQ89tK9C9zuZvLBlr9d6GNS0nHBaETN9eD53n3G0n/obG3AIRnhlY8CVIKug?=
 =?us-ascii?Q?GHgF1/Aq8HjQMHIJ7Z6klT6Bra0i+t+7ffaLxBWd8I4yDWjB0YAHnFC0fbTk?=
 =?us-ascii?Q?Cs3EBdWQ3ZVqkobXyzIlv/J29FPEHHVGBqY/PInNtUMafJrXD3FtA0NFmEA0?=
 =?us-ascii?Q?NlCMQm4srR9GHnqO+sMibnOz4Id72pQhUSFY92bov7c08XfX4bdBr6RZXXmK?=
 =?us-ascii?Q?Jvt6H++NR0yfWsl4xpFD5tA5SNoHAdaYLJXIt9cfhpo+UndFAOAJAVnfv4fH?=
 =?us-ascii?Q?mswVmUznNUNKO4PbF2epVjywMKnMLmS6z30xcuZUV+ynuyZHuuc/vXQ6Ot2b?=
 =?us-ascii?Q?OWy/wimtUOv6efb7NyAmmE6wIBIYuCo0nW03DGScMtFndlPnR8NmHQo0ut3+?=
 =?us-ascii?Q?B6WB5EsV47f/72iWMAi+mcHVJZV6etosnUALlYdRtQ1ibc2p9YfJrLTYZLRa?=
 =?us-ascii?Q?z6nT3gaLDLXzAxvUmHwxssBdRMx4aoV8qOg5SvouDt5u/oKSqv+YIgkv/sU8?=
 =?us-ascii?Q?5LrZ9Vf28m1cU2LpeMe/B0u8rEfhVJO6nFUVC2GQ0qXZkKJj2nIaDdRTjGJu?=
 =?us-ascii?Q?9rXTLXyjOs8nuS5ghkaL5A6mJWMFJdWt6VWdkb26ELSRbYUkVChcDyejw5Z3?=
 =?us-ascii?Q?XUVaIzix8/n23mdheq7daFMPGCK9wCkpInDcuexniMqJOYyPI5EM7SmWGbF/?=
 =?us-ascii?Q?W5LtHuizlP2T7Zwxhwo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 944b064f-df54-4d38-35f2-08dbeb0729d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2023 03:00:20.2032
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9jtqlQsTdvvnPGoZbRQ2Ej7JrnZhCHZNaBxpF9OTG17N4Wb1hhMktIisJ4bkCJJ/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7646
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 19:00:41 -0800 (PST)

> -----Original Message-----
> From: Samuel Holland <samuel.holland@sifive.com>
> Sent: Wednesday, November 22, 2023 6:12 AM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>
> Cc: Samuel Holland <samuel.holland@sifive.com>; Ariane Keller
> <ariane.keller@tik.ee.ethz.ch>; Daniel Borkmann <daniel@iogearbox.net>;
> David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Simek, Michal
> <michal.simek@amd.com>; Paolo Abeni <pabeni@redhat.com>; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org
> Subject: [PATCH net] net: axienet: Fix check for partial TX checksum
>=20
> Due to a typo, the code checked the RX checksum feature in the TX path.
>=20
> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ether=
net
> driver")
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> ---
>=20
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 82d0d44b2b02..bf6e33990490 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct
> net_device *ndev)
>  		if (lp->features & XAE_FEATURE_FULL_TX_CSUM) {
>  			/* Tx Full Checksum Offload Enabled */
>  			cur_p->app0 |=3D 2;
> -		} else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) {
> +		} else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) {
>  			csum_start_off =3D skb_transport_offset(skb);
>  			csum_index_off =3D csum_start_off + skb-
> >csum_offset;
>  			/* Tx Partial Checksum Offload Enabled */
> --
> 2.42.0