Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Wu Bo <bo.wu@vivo.com>
To:     Alasdair Kergon <agk@redhat.com>,
        Mike Snitzer <snitzer@kernel.org>,
        Mikulas Patocka <mpatocka@redhat.com>
Cc:     dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
        Wu Bo <wubo.oduw@gmail.com>,
        Eric Biggers <ebiggers@kernel.org>, Wu Bo <bo.wu@vivo.com>,
        stable@vger.kernel.org
Subject: [PATCH v2 1/2] dm verity: init fec io before cleaning it
Date:   Tue, 21 Nov 2023 20:51:49 -0700
Message-Id: <4257e74602bd0ea192011eaefdbf8a2205382b56.1700623691.git.bo.wu@vivo.com>
In-Reply-To: <cover.1700623691.git.bo.wu@vivo.com>
References: <cover.1700623691.git.bo.wu@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dUQx9MJIDtkTT29G+1fKJVcSkNBf524s8v7niimZAJ1TKxrZ0ShllsknesvG?=
 =?us-ascii?Q?xvOmKuV+fknORh3u77/G2XnDyaalBgo6h+bIOq0c9w+FZ1FjWdvny4gQzMvA?=
 =?us-ascii?Q?qTVI7nENz2J5gvdbMS++20igocf4aD2II7NQURLBtbQrWwexNiaYiDzoeG+D?=
 =?us-ascii?Q?DeopENTaO+qHki7V2vSbf4yb+khuWOnLRYNUqx2aePursGqa3qM8CcBLVU5N?=
 =?us-ascii?Q?8ZWvmFJTiyegiC/0hQMLb9r4r69XYXKHnfS1/GQMUhsgGpXG5CJjIuF80527?=
 =?us-ascii?Q?1XfwpfRAQLobm5B++b0vEKHd3Vo3LO8QOEne1hfQbwTWis5xLqkslVMvdbqW?=
 =?us-ascii?Q?MTdhq2Ew3U5hRTaHFr0Jss5qWidAPDllPRojRoohWabhuTxD0fVbdQZYwXb8?=
 =?us-ascii?Q?fhr58E7TXSBeQC3jDLZLgJqa01YlBAf2KZ/X/HhqTVDLQAl4XBxOd8jk5Uk9?=
 =?us-ascii?Q?+2e0y5Zwk69swetCBCqY8QQQBeo7dXkXOXGpUm+ZwvmI+JTmU4w1pNWmR8Am?=
 =?us-ascii?Q?0k417J9g5lbbEgcwTfbtOpXVIGNPZu27qkTaSsDTpz0AIJPFAFZf/wRjUCMp?=
 =?us-ascii?Q?poeXzh7PGrbajA6wLDe2H3IsDVwwt8ymcLlPOn1tLQFT3RkcwbBHxtJEN0Xs?=
 =?us-ascii?Q?34ZfDyHlu1m1ZsdR3mDCb504VI3LWVvfpo9uf3/cDzStczKN7noaoBnI1SMh?=
 =?us-ascii?Q?9qWV5e7n/Az0vTPxHK7hyNhh7YAvl13UME5mzD00Wkixl4KRtE5HRe0PtsyU?=
 =?us-ascii?Q?wA0bam7avnsDsxR1995CkCY9VrS4ZXISW/88XTILsYcQZAuPn++pdS7ZGkfw?=
 =?us-ascii?Q?zoFfLehmc+5RzD6Uqc+t+InHuDDidJiAuBO5DBQ1uG9N/loSAe1l0b32OMfs?=
 =?us-ascii?Q?oZ4uyI0hUGoFtHJjDS4CJZ4mGMyoWBspfB9dOradQzWAkd7WNr0qeoVjgYcl?=
 =?us-ascii?Q?A1kUV97BSGf3aFaRLKfULFqXDM464ye/FUur+4+oX4L8ZM6WxYwEFKFa672v?=
 =?us-ascii?Q?jRFtt4UoapfzZI10HbwP4ejR3YQRsoYEKcjwhzZspqjzyL9ci+OswHAMw77h?=
 =?us-ascii?Q?F53V/rsFUStmHKpSoN04jF6Sz3TW+bZBnNRXt7mhJ6Jw3hmbzQuR5QXNAXuT?=
 =?us-ascii?Q?atTqn7ek5pTyceJJNuLQURt9ENv0ugCz41lmmNJCtumwpiegaZQKGQMhtrhl?=
 =?us-ascii?Q?fXH1DOzvI/sNywsavIqXXVjF66eaZyz91WS+g69bdqarThcyZEGvfSuS3+M3?=
 =?us-ascii?Q?Cw1ZQAwiXHM6vmbhSDP8qPIKTz0aExBafAQb3aJch/7MmWO3Y43ZIA2yYabt?=
 =?us-ascii?Q?pCE8Q9eU33fjdxs/dJIa10Vg3ZlwxZWkhXGADiLjpXe310tdeNVxzQo24vqA?=
 =?us-ascii?Q?LE6fH6wnis7EGXzxe3d/s9ag9+I1NWwTDndeIlK5nJ+SWR2jl6L3ou65jngM?=
 =?us-ascii?Q?f/JwDIutvwZssVFST28qmS+sS2nZomK/U8nHNbRkC+jbeB6b5D02Ng41IMvj?=
 =?us-ascii?Q?w2Tf6bG+KM2iExjWPDLngxQdYhf3wQtLLcuV0m31FKNKlMtJTJsNyux/JmhF?=
 =?us-ascii?Q?+f9MwgoSGB8s4rMzDspqk22xvL82fhxpIPiWLkRO?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f1e050b-9880-40ee-06cc-08dbeb0d2e2b
X-MS-Exchange-CrossTenant-AuthSource: PS2PR06MB3509.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 03:43:24.6514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Mls7Y7bMWyAcYBDja0x9T0j1v2k0BwowSnE7Tg8Cqhr1uYtCx1HvZkTV/7vk3ZAV0AZQhclUPyUYI6SxSULQtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB3891
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 19:43:43 -0800 (PST)

If BIO error, it may goto verity_finish_io() before
verity_fec_init_io(). Therefor, the fec_io->rs is not initialized and
may crash when doing memory freeing in verity_fec_finish_io().

Crash call stack:
 die+0x90/0x2b8
 __do_kernel_fault+0x260/0x298
 do_bad_area+0x2c/0xdc
 do_translation_fault+0x3c/0x54
 do_mem_abort+0x54/0x118
 el1_abort+0x38/0x5c
 el1h_64_sync_handler+0x50/0x90
 el1h_64_sync+0x64/0x6c
 free_rs+0x18/0xac
 fec_rs_free+0x10/0x24
 mempool_free+0x58/0x148
 verity_fec_finish_io+0x4c/0xb0
 verity_end_io+0xb8/0x150

Cc: stable@vger.kernel.org      # v6.0+
Fixes: 5721d4e5a9cd ("dm verity: Add optional "try_verify_in_tasklet" feature")
Signed-off-by: Wu Bo <bo.wu@vivo.com>
---
 drivers/md/dm-verity-target.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c
index e115fcfe723c..beec14b6b044 100644
--- a/drivers/md/dm-verity-target.c
+++ b/drivers/md/dm-verity-target.c
@@ -642,7 +642,6 @@ static void verity_work(struct work_struct *w)
 
 	io->in_tasklet = false;
 
-	verity_fec_init_io(io);
 	verity_finish_io(io, errno_to_blk_status(verity_verify_io(io)));
 }
 
@@ -792,6 +791,8 @@ static int verity_map(struct dm_target *ti, struct bio *bio)
 	bio->bi_private = io;
 	io->iter = bio->bi_iter;
 
+	verity_fec_init_io(io);
+
 	verity_submit_prefetch(v, io);
 
 	submit_bio_noacct(bio);
-- 
2.25.1