Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Suman Ghosh <sumang@marvell.com>
To:     Shinas Rasheed <srasheed@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Haseeb Gani <hgani@marvell.com>,
        Vimlesh Kumar <vimleshk@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "mschmidt@redhat.com" <mschmidt@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Shinas Rasheed <srasheed@marvell.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Eric Dumazet <edumazet@google.com>
Subject: RE: [EXT] [PATCH net-next v1] octeon_ep: get max rx packet length
 from firmware
Thread-Topic: [EXT] [PATCH net-next v1] octeon_ep: get max rx packet length
 from firmware
Thread-Index: AQHaHK7LJGEoyOhokkOFzuxUo8XF0LCFwmwA
Date:   Wed, 22 Nov 2023 04:42:36 +0000
Message-ID: <SJ0PR18MB5216EA9C653D155E3F4A5D89DBBAA@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231121191224.2489474-1-srasheed@marvell.com>
In-Reply-To: <20231121191224.2489474-1-srasheed@marvell.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OdEWTsPOcsjW98poRxLZFV5TGt5KA3aiUFqYGeh/+IRJvRsyFJXK0jOTokh7?=
 =?us-ascii?Q?dJ7N2qgnTr4h0kdkG/INopC5+lF7neZWolyVXHq0JW47ZYk/K9rWXMHeJUjG?=
 =?us-ascii?Q?Zg3yeio1p56zNWLGoj4dT6nk2jsVdlM8MVBvmhA2+6uajP0B7C0a4q8saJyo?=
 =?us-ascii?Q?yfHy4MjAcvmWwfgM0Pna+G6B7hf46HRz/kcc8F5CWmO/Ss+ZtfSCSL2pWp2r?=
 =?us-ascii?Q?lGh0ITPyJ0oZqdiB+rBj/Ovf7LqgZG5YhZA8nV4xKa0cFrSPw4LAgWtxHXL4?=
 =?us-ascii?Q?SHTsswiWuGy7fcX7xYcM3b2Flr+3SGXczHji4Y7jDjgsDzEDlKNVDX8hLmvD?=
 =?us-ascii?Q?k2OuaWM3BEdMHVkwUb/e+WApQ6ebSgsH/9pFrxviIT+MV3tqLclj7JyxTqdd?=
 =?us-ascii?Q?5CkGsTRYYgQfpM5lAuJ9JPklq0GnjzO49yzUc8bv0Y35c+BZbUX5FNOjGKeT?=
 =?us-ascii?Q?XKnUpiJnDZArK09a2DooaGJqXl7UC8sHG9sGLafYtzx6DDBCRT4tYGAn32YC?=
 =?us-ascii?Q?VpStCuw3A/Hv9Ag/ZW5Ec5aqZScOIE8nsgIa8+/iqhk+xB4j/0vN696+/1qM?=
 =?us-ascii?Q?X/X+2IxMh1EIH4GRyY3FdpV1YszvrVFrzmqhn0TGL4rjtGu79lYMAMSM7xKD?=
 =?us-ascii?Q?nOlFNYHzPdDS5G4B++hyYe3Hd5l+o3YFd21cX09VYS8nyTqE5U/IWq10Pxyy?=
 =?us-ascii?Q?W4HFigvohqe/NfuNqTdZenUwtEabX1DnHKcW+4laocpy+8kn0YHsbmCDLQOr?=
 =?us-ascii?Q?GzW1voDIYjAZTSct9+1aOBfp2XM3D5QtK5eBChYzSCe3FlSYShHh45Unj7s3?=
 =?us-ascii?Q?PImvaCNLzkWG+fwUtRbq75xApg5bZIWEkIrv0M9ahBWsYnKIt2pSrYoRaxuS?=
 =?us-ascii?Q?PNt5p7Ye+eEdr6e7XGwzfpzEZ3vhBYmxzVToP/tN7NnIISJO34yYq47AiVd6?=
 =?us-ascii?Q?bsKLgTXZyMgi+i475p7HvxxU+6QYkGOoyybUoOoqPobpFtX3NTrpuwaqxMme?=
 =?us-ascii?Q?98oDcKqZxGovJ2MfbliF5+dvm/bN8249aT4Uu/MRF5Q0AKFT2eSJsFLJqDoq?=
 =?us-ascii?Q?95LrMFos24ZHZNRT6JG5YOtxU0ApoHyztHw+P5ryPe2TK3WVO8MsVJmC1kEr?=
 =?us-ascii?Q?ZDjVASU2l31sYreIwBzmZ4jZe+P1VVzmgt0ZSu17N8dScy8GUn58mnVeGEIJ?=
 =?us-ascii?Q?yF+NvbQ21TMRvzA0lc0pveCC9LFt8KUNNPsmJp7DHFR4TOMyf6HBY4bBBJ9S?=
 =?us-ascii?Q?yAPeL3Ad01jsfiglL05ePf3myPCYDAFOhvUVtTaGsYGnlOV/EKX8GDFAwS8r?=
 =?us-ascii?Q?VsvEqG+nU1FoZJ4UZz7B36qDvHCY+RKupDvBdSN5TkpsE72xULRyEgT6qbEt?=
 =?us-ascii?Q?1JYfrcHghlmD4lZ5kstGo6h09g94Ydw8dbbhRdLBflhaiOcXpofKzcb1SC8c?=
 =?us-ascii?Q?wqq5ssOE5jl7gcs0XyEQ1GBDlQe2QrBEhxUMTCkslNez7xekr7UtMftPUAkF?=
 =?us-ascii?Q?+5NnV4HcGHcPDPIsytNCEYqnPOTtfPK4NaU0Bx+iFYdQc+LkXP3gf5uTBhKJ?=
 =?us-ascii?Q?+xSuOtHH16iWKGEjjnV0LRedVeLebfOq9b510LfN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f1b0618-f243-408a-5f58-08dbeb15737c
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2023 04:42:36.6834
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BOBldzHt/8sJAtNs1fLQv+mDG3FEdhVZEZLSDwV56HlOG+ZjY4fcCQ1k6SXNTBpi1HejKx4fjJrQoJIq/IysdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4426
X-Proofpoint-GUID: 2W_DajeVpTOEtT3PtG48yenvMOmf9ywS
X-Proofpoint-ORIG-GUID: 2W_DajeVpTOEtT3PtG48yenvMOmf9ywS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-22_02,2023-11-21_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 20:42:56 -0800 (PST)

>Signed-off-by: Shinas Rasheed <srasheed@marvell.com>
>---
> .../marvell/octeon_ep/octep_ctrl_net.c         | 18 ++++++++++++++++++
> .../marvell/octeon_ep/octep_ctrl_net.h         |  9 +++++++++
> .../ethernet/marvell/octeon_ep/octep_main.c    | 10 +++++++++-
> 3 files changed, 36 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
>b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
>index 6dd3d03c1c0f..c9fcebb9bd9b 100644
>--- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
>+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
>@@ -198,6 +198,24 @@ int octep_ctrl_net_set_mac_addr(struct octep_device
>*oct, int vfid, u8 *addr,
> 	return octep_send_mbox_req(oct, &d, wait_for_response);  }
>
>+int octep_ctrl_net_get_mtu(struct octep_device *oct, int vfid) {
>+	struct octep_ctrl_net_wait_data d =3D {0};
>+	struct octep_ctrl_net_h2f_req *req;
>+	int err;
>+
>+	req =3D &d.data.req;
>+	init_send_req(&d.msg, req, mtu_sz, vfid);
>+	req->hdr.s.cmd =3D OCTEP_CTRL_NET_H2F_CMD_MTU;
>+	req->mtu.cmd =3D OCTEP_CTRL_NET_CMD_GET;
>+
>+	err =3D octep_send_mbox_req(oct, &d, true);
>+	if (err < 0)
>+		return err;
>+
>+	return d.data.resp.mtu.val;
>+}
>+
> int octep_ctrl_net_set_mtu(struct octep_device *oct, int vfid, int mtu,
> 			   bool wait_for_response)
> {
>diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.h
>b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.h
>index 4bb97ad1f1c6..46ddaa5c64d1 100644
>--- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.h
>+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.h
>@@ -282,6 +282,15 @@ int octep_ctrl_net_get_mac_addr(struct octep_device
>*oct, int vfid, u8 *addr);  int octep_ctrl_net_set_mac_addr(struct
>octep_device *oct, int vfid, u8 *addr,
> 				bool wait_for_response);
>
>+/** Get max MTU from firmware.
>+ *
>+ * @param oct: non-null pointer to struct octep_device.
>+ * @param vfid: Index of virtual function.
>+ *
>+ * return value: mtu on success, -errno on failure.
>+ */
>+int octep_ctrl_net_get_mtu(struct octep_device *oct, int vfid);
>+
> /** Set mtu in firmware.
>  *
>  * @param oct: non-null pointer to struct octep_device.
>diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
>b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
>index 3cee69b3ac38..f9c539178114 100644
>--- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
>+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
>@@ -1276,6 +1276,7 @@ static int octep_probe(struct pci_dev *pdev, const
>struct pci_device_id *ent)  {
> 	struct octep_device *octep_dev =3D NULL;
> 	struct net_device *netdev;
>+	int max_rx_pktlen;
> 	int err;
>
> 	err =3D pci_enable_device(pdev);
>@@ -1346,8 +1347,15 @@ static int octep_probe(struct pci_dev *pdev,
>const struct pci_device_id *ent)
>
> 	netdev->hw_features =3D NETIF_F_SG;
> 	netdev->features |=3D netdev->hw_features;
>+
>+	max_rx_pktlen =3D octep_ctrl_net_get_mtu(octep_dev,
>OCTEP_CTRL_NET_INVALID_VFID);
>+	if (max_rx_pktlen < 0) {
>+		dev_err(&octep_dev->pdev->dev,
>+			"Failed to get max receive packet size; err =3D %d\n",
>max_rx_pktlen);
>+		goto register_dev_err;
>+	}
[Suman] Do we need to check if max_rx_pktlen <=3D OCTEP_MAX_MTU as well? If=
 not, then this macro is not required further after the change?

> 	netdev->min_mtu =3D OCTEP_MIN_MTU;
>-	netdev->max_mtu =3D OCTEP_MAX_MTU;
>+	netdev->max_mtu =3D max_rx_pktlen - (ETH_HLEN + ETH_FCS_LEN);
> 	netdev->mtu =3D OCTEP_DEFAULT_MTU;
>
> 	err =3D octep_ctrl_net_get_mac_addr(octep_dev,
>OCTEP_CTRL_NET_INVALID_VFID,
>--
>2.25.1
>