Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp887023rdf; Tue, 21 Nov 2023 22:18:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6xS0hQxj0uL0TcQKtPBAxosKZe28poGQ424CLhCL9AUvl3vgn2fZdZA92FszRnEFvOHl2 X-Received: by 2002:a17:902:7d84:b0:1ce:89a7:4403 with SMTP id a4-20020a1709027d8400b001ce89a74403mr1366098plm.58.1700633928878; Tue, 21 Nov 2023 22:18:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700633928; cv=none; d=google.com; s=arc-20160816; b=rh75gaQlbLTyYpFIWMi0m1N+aqO7QdvSyZHNcnmUoeIFbtPdhNDKS85A2ylsFo+diQ xSBG0XwkcXTbmbohEdzAgzfQyNJHHqJVf2/Gr9Vuvq8Rsm7HhmJz9M0sHmz3u9hNslYc PTzSvPD79p1RxSkJJR92PO6gkFXiPrtOmd58bjyQTLPYEIrBVyUe3Kuqi+Q0XLvX0iW6 wGOAVShTVkUZ6w/7Xq1Qze680aCZY0YqOxpHpmBaqshZ2PcP1CpwujOp33Qem3bIvQNX D2Lfsi2KJCR+TL0vHtROemhp3OugJayvm9ScjEFt082IPMZFCvY6vrrTRLA7pAZIhX4j 29XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qI4B5gsZLWiiXBDdysw5HVQJ0fReub9T5Rnt1Eo4OyY=; fh=40+TGzva0NcwzIvtx2Kwg+nPQQvnk6Ad5NLcVD1uCnc=; b=RFSEUILxQ0qcvZWBB/i67/VBUspIqTN4pp+hxrVj0jVadxxRGBmtjy0n9SK+UvOIJ8 UZ8x7I8Jp5+VM9xZreRyCLoyNdYCM+jtsxWTssrhguMAMnwdImcARbSrecsgh9B8wlLH b3gnUasmUovux1AeDYttViNxQ44wjVVF6i8nlZq8gzoMwY6j+2QvMqsoBaNWC5rh8F89 cvIqQJC/b+OcQ1gTUOqL7pMWi286wZ6iNUxqpNaGF7vpuTbT/bt0A/GoLUc7DJZ8XE4Z unu4YIBToIix4FuXbU7INKTCw+W8BZxCsmVUey4xfmVM7F6XFwUxzS46V32tX7rzGU4g Wwjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@atomide.com header.s=25mailst header.b=OoYqo2C9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id l12-20020a170903120c00b001c61bdd8e89si12314046plh.150.2023.11.21.22.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 22:18:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=fail header.i=@atomide.com header.s=25mailst header.b=OoYqo2C9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7FE638145943; Tue, 21 Nov 2023 22:18:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbjKVGSk (ORCPT + 99 others); Wed, 22 Nov 2023 01:18:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjKVGSi (ORCPT ); Wed, 22 Nov 2023 01:18:38 -0500 Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3C48D40; Tue, 21 Nov 2023 22:18:34 -0800 (PST) Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 798D060852; Wed, 22 Nov 2023 06:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1700633913; bh=s2Rn9HZSrXpT1wimrPImmfufYVdONUvRoqjmZHEvbes=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OoYqo2C9oHA9tXrpgOX+dWYtyewBVusp46hd+a/zwCo5Skm1JZBaAqBY+c2qDMNUV YKFbT+vCt9NA/OfC18UJq9WK402lwsLMZ3w4uNFevHkG9QxCituKGb7+XaBdOAwyjQ 9FeNq3BfE2p0RWIV/55LrymCmxSIqWwRcHWO5+Rc6BMQy3gVurOlIcKGk4Grq1puVr moVB9Xwx6VQVd6/27FfDTmzdpBAQA8D4KTcv8ACydf2smsCi9ri5GOnQtF8v38cNn8 NTWAa5x8eauL9f9tgO8102loKoMSHsQCb7pUwrrtatHgtXOJ9BWXHEtzg4ANv2WYoe of0M5APHo1rtw== Date: Wed, 22 Nov 2023 08:18:00 +0200 From: Tony Lindgren To: Andy Shevchenko Cc: Greg Kroah-Hartman , Jiri Slaby , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , "David S . Miller" , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v3 1/3] printk: Save console options for add_preferred_console_match() Message-ID: <20231122061800.GC5169@atomide.com> References: <20231121113203.61341-1-tony@atomide.com> <20231121113203.61341-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 21 Nov 2023 22:18:46 -0800 (PST) * Andy Shevchenko [231121 17:53]: > On Tue, Nov 21, 2023 at 01:31:55PM +0200, Tony Lindgren wrote: > > +#include > > > +#include > > I think instead of kernel.h you may want to see these: > > linux/init.h > linux/string.h > > asm/errno.h > > > +#include "console_cmdline.h" OK > > +/** > > + * console_opt_save - Saves kernel command line console option for driver use > > + * @str: Kernel command line console name and option > > + * > > + * Saves a kernel command line console option for driver subsystems to use for > > + * adding a preferred console during init. Called from console_setup() only. > > scripts/kernel-doc -v -none -Wall ... > > most likely will complain (no Return section). OK adding. > > + */ > > +int __init console_opt_save(char *str) > > str is not const? Hmm... Nice yes it can be const char *str here. Hmm maybe with the third patch also console_setup() can use const char * now.. Will check. Thanks, Tony