Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp892050rdf; Tue, 21 Nov 2023 22:33:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IHx/NYDCV2go8ZLCE6HJxjNZ5/FkoiKC2QCKjtluXuZwPD+ziTLRp5hguRQjwIipiDyzsCX X-Received: by 2002:a17:902:bd93:b0:1cf:6c5d:f0a0 with SMTP id q19-20020a170902bd9300b001cf6c5df0a0mr1258281pls.64.1700634815256; Tue, 21 Nov 2023 22:33:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700634815; cv=none; d=google.com; s=arc-20160816; b=VPjeuNlE5H8wwow5I+tkxJHHU5vuHITQdPq/XttnVPRFJnCNveJPNF+2Jsp8xKQ6iz sGTSjAMq1AROCIut1n5QVxowo0VANKWkKwg4DDV7Bm5KQ+0J9CK8UiQFlyNcbyeAvGOV tq8rRFhY24zAAighj+PGHvE6Wo06+k0q6t1lUftksdkgWY7r4Dc5bJsM+qJY0kS/1+9i LITwtmCvv3cRQoyCsX8wtkii1rR4gUV4uCNKBSayz9ayXfluyPnrqp7yf8xFQy5tr0M5 Hgu+wY5rNTozx4QJuESahC97tkSXkOQyJxFBsJtZOh8WVPzOX5KcBBvBIGSIn8qpDHRy K47w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id; bh=wkk6KghEqaVy/lgbXkgW4CUMwyYkn5lqU65OmhfEyfQ=; fh=+X2jCOQ+G8JW4gS8muobVG/rVv5rvytivO4ylyX0tbE=; b=DFHH2B1zRnE8KxEwPM3iwCNK8rv6ctq6nhhqasMK0atc9tDw+wZr3gPFYMVUTpWMFv 4jeJwLzCpAApcn9ZG4rD5fjKb3MC0bJuvaKeHEMSDIdK+ncuEZCBT06VbMXTdMQvjqj/ Q0WHSkCB8ndScz795R9T9uIuR16EfvGrAZsn+YPmswAJ8UOoKFNoUXkfygALoiJR1ENw xYQOHOpCjHwlm7KBCkLKchJDF+EaJEzxZuLowET8ZTGCRkeHwqaTYnMsvnMK1mGoIbPw v6/YlmJH6Y63O9RtFeoEYdtggVdxRjaDDnGu90GDyHK+fi1kk9iy8HySWCvEDYQHcPxP nN6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id bj12-20020a170902850c00b001b7ea20dbf2si11356556plb.224.2023.11.21.22.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 22:33:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E7719812F444; Tue, 21 Nov 2023 22:32:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbjKVGcy (ORCPT + 99 others); Wed, 22 Nov 2023 01:32:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjKVGcx (ORCPT ); Wed, 22 Nov 2023 01:32:53 -0500 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11750F9; Tue, 21 Nov 2023 22:32:50 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-33139ecdca7so3865147f8f.0; Tue, 21 Nov 2023 22:32:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700634768; x=1701239568; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wkk6KghEqaVy/lgbXkgW4CUMwyYkn5lqU65OmhfEyfQ=; b=bo1u/iSK7d72ce7j3mja+LZnfIritsunda9yvwxLRY01E6DZx4+A1D0OuiXFYp0cza ahj8xkqS7dSOi0AjduOt1hoPLV31u7T0XyQgHutSTQs0XMevb3a842eiKoQqQnGiBKSp xDBrIgoAhKYJTNilPo1Y//zKFWOwdTTIoOWTBDWhDjHnK2gM5CwCXRONHLa0CiLFsr7R F/IakkKdkDHNO9YqwM6VHs4N+BIdBoO4+oBzRJzgh76NaVkMwEl9h2rfJEAS3gGqDu+K RepcaYJ8SL63bbJ3DAVtR1A3LxHBgeGWHvErs1wb82KMQkiQK3kxu3VK7pC6dqOjYrv1 JkcA== X-Gm-Message-State: AOJu0YxdFXXqOvV6uaVK0pJL+j5Wk7M58bajwDjW6cKEiNQ9Kruzb/NK ekexZsmI5hBiHt8/Ky13Sb4= X-Received: by 2002:a05:6000:4f:b0:32d:9d6b:ac99 with SMTP id k15-20020a056000004f00b0032d9d6bac99mr799661wrx.31.1700634768283; Tue, 21 Nov 2023 22:32:48 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id n4-20020a5d4004000000b003316b3d69b3sm15418910wrp.46.2023.11.21.22.32.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Nov 2023 22:32:47 -0800 (PST) Message-ID: <268cb513-5b17-4bd5-81b7-ed730c895e41@kernel.org> Date: Wed, 22 Nov 2023 07:32:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 17/17] tty: srmcons: make 'str_cr' const and non-array Content-Language: en-US To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Greg Kroah-Hartman , linux-serial , LKML , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org References: <20231121092258.9334-1-jirislaby@kernel.org> <20231121092258.9334-18-jirislaby@kernel.org> <82caf538-cee5-1420-4944-b26b627ef145@linux.intel.com> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <82caf538-cee5-1420-4944-b26b627ef145@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 22:32:56 -0800 (PST) On 21. 11. 23, 16:28, Ilpo Järvinen wrote: > On Tue, 21 Nov 2023, Jiri Slaby (SUSE) wrote: > >> 'str_cr' contains a single character: \n. There is no need to declare it > > Aren't \r and \n different characters? Definitely, this is a thinko -- I didn't remember properly what it contains when writing the log. Fixed. > >> - static char str_cr[1] = "\r"; >> + static const char str_cr = '\r'; > > Thanks for making these cleanups. > > I've reviewed all the patches in this series, so if I didn't comment a > patch or when you address my remarks, feel free to add: thanks, -- js suse labs