Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp903187rdf; Tue, 21 Nov 2023 23:04:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdgYJV9WJSgD0+fDTbq1HVmDu2uADSBfrCAjqFec1vpNZNAjAjOYU/U1CJLMAJDP3CYxPL X-Received: by 2002:a17:903:258a:b0:1c4:56c8:27f8 with SMTP id jb10-20020a170903258a00b001c456c827f8mr1248470plb.68.1700636684751; Tue, 21 Nov 2023 23:04:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700636684; cv=none; d=google.com; s=arc-20160816; b=rIohSUFaGHABb/At59oNhshk0zvaFfowMsrqJXMKpM5MCg4bFzsV+GOILC1bFwJ1Y6 q9R3TbPCTYvjCW++pj7lL56DtcxF1jt35RywDxnBH0xxYeI+tcmmGgWj47w1BPgnJTBb +RHnRoaXa9IXyelj14XFFZTgwxKYN37A6E8Ld9Qq8OsnOpWEdlCxI1f5GeKXg+aKXWva Gg1IIb8cqhVGg4nlcT2FP0AR7u8dkLQbHlutr40eSg3dsiNqncPkMCvKCZFkXZGffykr dk86QHu6wvqErYEJqx6Qq9L6LcNdL7WDXlEcPFqh33UHRDDxbtx6qKEROsaAaQv3KSK4 FiyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Bufw4bmBSqsw4SXqmjcJXXVYWnsGgxeyyefEbTWItRk=; fh=zXMHlSRyhZgSiSOYiHZv+WPFjyASzXDy5hFhdXImaMQ=; b=NqnLcXsk+sHSGCw6To8yiIFzYc+sJxtlG9E3MA9/jD5NeZtLkbdLzghp1xxKm0uP6a zaghmc+YwvnXcK4WlrqbtOr7N/3vYUtOf2ryuDQePEXykZooQ6AiOIYE8RId6pw6oDUY Z84JlM3D/19/h5BkYi+jNwk/0Wr5zeF0mng3+Y+JOq3p+qJJfosoc95Yf+q1h5Zmkw1I QCp+2eAw9xTeGFBmUvu+/0cl2n7yxeaZKnhikU5d3o6o1bT9Xi7YeuBoWaKFHmKlluZf /kGQiGSzP6JQWmXBhbhgdre87tAbEsgQvdnj6afUU7xpbE0vhOoPYyeF3xtiL3Ay72BF deAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@atomide.com header.s=25mailst header.b=JSEVesTc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id j10-20020a17090276ca00b001bbca0a8393si11772063plt.56.2023.11.21.23.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 23:04:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=fail header.i=@atomide.com header.s=25mailst header.b=JSEVesTc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 58180802B543; Tue, 21 Nov 2023 23:04:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234757AbjKVHEb (ORCPT + 99 others); Wed, 22 Nov 2023 02:04:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbjKVHEa (ORCPT ); Wed, 22 Nov 2023 02:04:30 -0500 Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4550419D; Tue, 21 Nov 2023 23:04:26 -0800 (PST) Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id A6E7860513; Wed, 22 Nov 2023 07:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1700636665; bh=VXGR8xQGZzWXW6baSZHRlpOMY386TuOcB9XLnlAtLsY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JSEVesTcdCirCXWm9j2QFnmIl2byVFl2VpYF4FPb9Y9egs/H5xk3uYM4wnZCSBURQ X+0wi12ozQewEC3JjKlo2I8Zig5kcBp/evrX4j5QmjNwSk7S5wpIprE97JareGLhSZ anqVwDs6jeDH+ilFU0gOiV+ROWA0MmBclmF6tp1Owlf73zK06mVLWAqb4TlqDVDshX rLbP4IrOyUcBhpAs0hVt4nJuNEkwfhZx3IUaLyMtLEeyHgtdWc88Eu+iXV/xMlE9KI tzmy9KDsrlcDjFj6bBPEA3Zo/5s9/+XXnE50Q4oqOHW1UKYj5Br/ovHIT3O8SyNRIN 1v8q0jRwbHZ6A== Date: Wed, 22 Nov 2023 09:03:53 +0200 From: Tony Lindgren To: Greg Kroah-Hartman , Jiri Slaby , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky Cc: "David S . Miller" , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v3 3/3] serial: core: Move console character device handling from printk Message-ID: <20231122070353.GF5169@atomide.com> References: <20231121113203.61341-1-tony@atomide.com> <20231121113203.61341-4-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121113203.61341-4-tony@atomide.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 23:04:42 -0800 (PST) * Tony Lindgren [700101 02:00]: > - __add_preferred_console(buf, idx, options, brl_options, true); > return 1; Looks like this can't be dropped yet. We need to keep it for the brl_options. I'll change it to return early if brl_options is NULL. Regards, Tony