Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp906752rdf; Tue, 21 Nov 2023 23:13:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFuKDL07XuhCXRiGqfr/BhJvYivKkY9veaTOF2iln8DM0EnKfqhuh5znEISyUAhVCrQ6Bs5 X-Received: by 2002:a05:6870:6c0a:b0:1f0:d96:8d9c with SMTP id na10-20020a0568706c0a00b001f00d968d9cmr2235806oab.9.1700637204803; Tue, 21 Nov 2023 23:13:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700637204; cv=none; d=google.com; s=arc-20160816; b=tTfzoSfeXzU0tu/bC8bHseoXSud8aePtOIexTClaTrQzJ8l57jOd6v0pqNaVsKS4Rx Q1AYRo+8i7zBWFOToE2qGr05Wxz37jS73o/muAgxUCB+/Vztuf17y8F/FJ1mBS+Ai3sL /0vRnKrIYBCptTorWRo54pJ8H3LqUhk29P8hXbZQV/xNA3cvwzSBDNisNGe7ol1hHhrg 16zerlVlDFkGWe1cSQkMrFqX3s+j5XSHkhgItBYO8GrlrFQm9ia7Ne1stJe0+Guq8/8x 6xR1gMTjKeTmfV1urnh46efFcoIXtC3VS0mfBm/7AMJQjqOnjsytzxTQsWqxfbfPMuyB H9Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=mP3Zh3ghe1QobYCFwkdhcpkOdhL0iT2Q9aPGVoVes/U=; fh=fyPT5phGKeBfoOC/BOPzKJl/xgSxxu2I+EcBl6g/Bns=; b=Q/O77bJmgSzptIqbbPSZKhWlKz0VVq4d5JTkROzHbVJX2Av5qqnIEcadxIy5ubbZDk P3SFIbz2k0EEzRw9ObOniLeU2SJr+0oOc3fWxqinut0sS0wMjOfTj12Iqtzyv4XTGwEt kizN+lFITG3S25zZEie1REa7PO1TQ5wgJT3zRlaADywTx7mqqlcdLGbBqKsmPifqrviV MwXLhhLV+VYsSu6sehvO+3ix1vPIKvs4T3HDxrCw0blDZLyEeSwjkOAOhriDNUPj5U7C 995cxeEIVMjp3tKoMupFG9mPb3v0wqELfD+Qgp28vO3VimQk0wWwQJG1OZAattiDou+F xWmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=GfdqENGF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id c4-20020a056a000ac400b006bc3f09ea03si12667902pfl.301.2023.11.21.23.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 23:13:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=GfdqENGF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E9025819FC63; Tue, 21 Nov 2023 23:11:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234943AbjKVHLr (ORCPT + 99 others); Wed, 22 Nov 2023 02:11:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbjKVHLk (ORCPT ); Wed, 22 Nov 2023 02:11:40 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24CA4A1; Tue, 21 Nov 2023 23:11:36 -0800 (PST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AM5n30l021040; Wed, 22 Nov 2023 07:11:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=mP3Zh3ghe1QobYCFwkdhcpkOdhL0iT2Q9aPGVoVes/U=; b=GfdqENGF/++ld/M9Gy502zOtgS61nuXBlyPOowHGhhyHJI4iNdO4ySw/TuN2MGGTzbrl BZ6+5SRZAZYkpYlT6pNXLKU9zWlC04Q1pnStfs7cBiYuVyzSmF/RBZjOPnVnJXqogUAp dSQOIUtSxI7FuP9PX2awZGOZQCEQC/h0b73TNgSpDG8hj3xgRS3tGWBLlRAl2yx9EMcl loYbzmGZMg2EK4uYlgjjwwFW4Y659nvXxwddBplxb9W9CCtWelCrKvBj8Re9Oa2bkeOV xUE46CZEimLWa0/squ8isjPuZvPiA8m7OqTsytkQPUYPs/Nl7Wxub42AyISp5gDkrS1Y rw== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ugr85uagx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Nov 2023 07:11:03 +0000 Received: from pps.filterd (NASANPPMTA02.qualcomm.com [127.0.0.1]) by NASANPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 3AM77Vp8004501; Wed, 22 Nov 2023 07:11:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA02.qualcomm.com (PPS) with ESMTP id 3uepbmy81m-1; Wed, 22 Nov 2023 07:11:01 +0000 Received: from NASANPPMTA02.qualcomm.com (NASANPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AM7AKdX008797; Wed, 22 Nov 2023 07:11:01 GMT Received: from stor-dylan.qualcomm.com (stor-dylan.qualcomm.com [192.168.140.207]) by NASANPPMTA02.qualcomm.com (PPS) with ESMTP id 3AM7B1lk011118; Wed, 22 Nov 2023 07:11:01 +0000 Received: by stor-dylan.qualcomm.com (Postfix, from userid 359480) id 2334420A65; Tue, 21 Nov 2023 23:11:01 -0800 (PST) From: Can Guo To: quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org, stanley.chu@mediatek.com, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , linux-arm-msm@vger.kernel.org (open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER...), linux-scsi@vger.kernel.org (open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER...), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 02/11] scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param() Date: Tue, 21 Nov 2023 23:10:33 -0800 Message-Id: <1700637042-11104-3-git-send-email-quic_cang@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1700637042-11104-1-git-send-email-quic_cang@quicinc.com> References: <1700637042-11104-1-git-send-email-quic_cang@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: rYFiWK0aYSPSxGgKwapL5SNeKC--5urQ X-Proofpoint-ORIG-GUID: rYFiWK0aYSPSxGgKwapL5SNeKC--5urQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-22_04,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311220050 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 23:12:02 -0800 (PST) In ufs_qcom_pwr_change_notify(), host_params.hs_rate has been set to PA_HS_MODE_B by ufshcd_init_host_param(), hence remove the duplicated line of work. Meanwhile, removed the macro UFS_QCOM_LIMIT_HS_RATE as it is only used here. Signed-off-by: Can Guo --- drivers/ufs/host/ufs-qcom.c | 1 - drivers/ufs/host/ufs-qcom.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index aee66a3..cc30ad9 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -909,7 +909,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, switch (status) { case PRE_CHANGE: ufshcd_init_host_param(&host_params); - host_params.hs_rate = UFS_QCOM_LIMIT_HS_RATE; /* This driver only supports symmetic gear setting i.e., hs_tx_gear == hs_rx_gear */ host_params.hs_tx_gear = host_params.hs_rx_gear = ufs_qcom_get_hs_gear(hba); diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h index 9950a00..82cd143 100644 --- a/drivers/ufs/host/ufs-qcom.h +++ b/drivers/ufs/host/ufs-qcom.h @@ -27,8 +27,6 @@ #define SLOW 1 #define FAST 2 -#define UFS_QCOM_LIMIT_HS_RATE PA_HS_MODE_B - /* QCOM UFS host controller vendor specific registers */ enum { REG_UFS_SYS1CLK_1US = 0xC0, -- 2.7.4