Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <3fa7ec68a0302667f1b73682e4db96f6ba618397.camel@sipsolutions.net>
Subject: Re: [PATCH] um: Use swap() instead of open coding it
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, richard@nod.at
Cc:     anton.ivanov@cambridgegreys.com, linux-um@lists.infradead.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Date:   Wed, 22 Nov 2023 08:25:54 +0100
In-Reply-To: <20231122032518.53305-1-jiapeng.chong@linux.alibaba.com>
References: <20231122032518.53305-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-11-22 at 11:25 +0800, Jiapeng Chong wrote:
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
>=20
> ./arch/um/os-Linux/sigio.c:81:28-29: WARNING opportunity for swap().
>=20

Hm. There's already a use of swap() here in this file, but I actually
think we should revert that? This is basically userspace code, not
kernel code, so I don't think it should include linux headers, even if
those happen to be "standalone enough" right now to work.

johannes