Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 22 Nov 2023 09:01:06 +0100
From:   Andrew Jones <ajones@ventanamicro.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] selftests/kvm: Fix issues with $(SPLIT_TESTS)
Message-ID: <20231122-ef1578645fb74a7aa0fca822@orel>
References: <20231121165631.1170797-1-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231121165631.1170797-1-pbonzini@redhat.com>
Precedence: bulk

On Tue, Nov 21, 2023 at 11:56:31AM -0500, Paolo Bonzini wrote:
> The introduction of $(SPLIT_TESTS) also introduced a warning when
> building selftests on architectures that include get-reg-lists:
> 
>     make: Entering directory '/root/kvm/tools/testing/selftests/kvm'
>     Makefile:272: warning: overriding recipe for target '/root/kvm/tools/testing/selftests/kvm/get-reg-list'
>     Makefile:267: warning: ignoring old recipe for target '/root/kvm/tools/testing/selftests/kvm/get-reg-list'
>     make: Leaving directory '/root/kvm/tools/testing/selftests/kvm'
> 
> In addition, the rule for $(SPLIT_TESTS_TARGETS) includes _all_
> the $(SPLIT_TESTS_OBJS), which only works because there is just one.
> So fix both by adjusting the rules:
> 
> - remove $(SPLIT_TESTS_TARGETS) from the $(TEST_GEN_PROGS) rules,
>   and rename it to $(SPLIT_TEST_GEN_PROGS)
> 
> - fix $(SPLIT_TESTS_OBJS) so that it plays well with $(OUTPUT),
>   rename it to $(SPLIT_TEST_GEN_OBJ), and list the object file
>   explicitly in the $(SPLIT_TEST_GEN_PROGS) link rule
> 
> Fixes: 17da79e009c3 ("KVM: arm64: selftests: Split get-reg-list test code", 2023-08-09)
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tools/testing/selftests/kvm/Makefile | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
>

Thanks for these fixes, Paolo! And thanks for keeping my old @redhat.com
address alive!

I've tested this on riscv,

Tested-by: Andrew Jones <ajones@ventanamicro.com>

Thanks,
drew