Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Lukas Funke <lukas.funke-oss@weidmueller.com>
To:     lkp@intel.com, MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
Cc:     Lukas.Funke@weidmueller.com, linux-kernel@vger.kernel.org,
        lukas.funke-oss@weidmueller.com, oe-kbuild-all@lists.linux.dev,
        Lukas Funke <lukas.funke@weidmueller.com>
Subject: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity based on device-tree
Date:   Wed, 22 Nov 2023 09:07:48 +0100
Message-Id: <20231122080749.947682-1-lukas.funke-oss@weidmueller.com>
In-Reply-To: <202311221355.yxYpTIw3-lkp@intel.com>
References: <202311221355.yxYpTIw3-lkp@intel.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tZgo8f2amh8mHD+cqqodFL7V5sVS8Obg4+yB8dskvjwASE1vfSl5YW8yXWM8?=
 =?us-ascii?Q?G0hY9g7kaFHlYaMOuTBVVIS5ndQUswyVYPkACTSfkaZbWo9vsJPCfSMIpgr/?=
 =?us-ascii?Q?51dgvKLLKN1BgfXTdAgvsVcsl206hXIThaZOSbxZOzdp8O9lQphwXBbd8XJ3?=
 =?us-ascii?Q?3LA7lQ24VVq854YJ2UXbA/TBYIyyDf4Y+8RRKerFAFBcRD53Lcj7wCGaA1mf?=
 =?us-ascii?Q?Eszd+pSCLg5heOd4sMwfn4cXTB90yk4bszo8RAW9RtJ0nEXcl6e01G3wOUY+?=
 =?us-ascii?Q?7HxjC+vox6Q1G614Fm4j8U30sheaHRww4dtiMI2WxE1KjNC6FT25JNeV9W6u?=
 =?us-ascii?Q?KlzTr+FJKmDZOpVqMUsh7tPOTIAKdu6lk5jsejUOIPKmZ58iCrQ6tcHTB4+m?=
 =?us-ascii?Q?qwl+W9uQSsSUxxiqa36oC5Vw9Q+zwyZFKVEBjn9K0AK5fQ643A7jKwgE7sEy?=
 =?us-ascii?Q?VnNrBHZng1jtiW14+MS2ctxVjTD0D/Trqboamwsai8HOak8SESWAnsDmNT2L?=
 =?us-ascii?Q?VWu9/oiTQDRDQlBd1BQqR95ixFZZ7f4UWR95qPHjbdmaMsqs51Q77NlZ97aM?=
 =?us-ascii?Q?j9AHYKVrkFox5SiesKjj2LWHTksd2135KP5OATjpBGODzI9LRyObJnpM6TM4?=
 =?us-ascii?Q?KeMsRSM/irzTomr3e7AcpDc3hwJifxwynSjh0ASz4xzCQA5qYezDdblsxX++?=
 =?us-ascii?Q?9L7VGtbbPI279nm3pqc4vxUJIHw5Z33TFbdnpZt3KKMP/5LcSMhK+6G1Bn57?=
 =?us-ascii?Q?hFl1rZ6/d/7WzEdkX/M+Ql5jCqLybvh1Y/flHsiG1hwc2SHN1IKvQBQS86JW?=
 =?us-ascii?Q?50iuYbR+DpK0YXhAL6kNQSsFkZfxIJp2cs/vFxilGxrdsZMER12pwu7I2lk5?=
 =?us-ascii?Q?Lq8tl+ZWLaQr00pq7b2MmZr5hZyCchV8I/5LfUSU9yoQz/zszYW+jEOnMtRS?=
 =?us-ascii?Q?em+RtTtjSrlh2qjP08CN1Xx/EF96c1jnrEboZP8B6y3EPdaNtKV2+1gAxAPR?=
 =?us-ascii?Q?pn7aDrUHW/vVJrmWvCJ71D+4HJXfaHNVtr7aNUhE4Z3dmSDWVmca5Fq37KmZ?=
 =?us-ascii?Q?ILR9njdFj169CjPllWmusH/89gn29jgJhdgBs22mW70LkeFRdkrFBHsbSSyT?=
 =?us-ascii?Q?Oc++eG26/YxbUZMhS5xpYmxQeq9GtGUU0+YbWEkhQT8CikL0cAC4KCDgB+DP?=
 =?us-ascii?Q?zDm4E2z4ALnCV1yao10ZU6EwtsBx6ks+BAFLSWLruueL5xDEv4rnMFiQjacv?=
 =?us-ascii?Q?CmgIF3zSvKdJr6ifgJtMLfSusMqAcr8vPq9x7geoi0awC6dRwKsuNDhcKPE1?=
 =?us-ascii?Q?lnA5GiloS76tK7gPz7AZDKDPIOCQp/03Qhu1akBMNwTnnw9qVVIfzGBvyXCg?=
 =?us-ascii?Q?EcrzxPgYO5owJBrcg4Rrf78VYBY5anzc1rBhKHYJhRvMIJt85TpJZMM2y3tM?=
 =?us-ascii?Q?QLRXs8g+XOAKU6ec/UW/Tk+qLfK6SfPSRkjD4RW2KbHYFe8tKLclKy0bA3NQ?=
 =?us-ascii?Q?L8AD/IYHof4oKmJivFkqFVIT2jh6JisAtCWfDy47V/rNPx9oyoaMu9M7VvGM?=
 =?us-ascii?Q?hz+QjrML1EkacuqxfNE3IYwMW03u+wuXBaniZweKLLklXxYihtV1bqX/omBT?=
 =?us-ascii?Q?IQ=3D=3D?=
X-OriginatorOrg: weidmueller.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed293e02-ab39-4bb7-7485-08dbeb322269
X-MS-Exchange-CrossTenant-AuthSource: AS2PR08MB8431.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 08:07:56.2380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ovd0La8H2BYozW7ithSBLx02MZGHNs/syws4Ung1NMs6gSzvQXoLyiNSOc3ac+XOTOTmEU3O7zzPBAMF9nQ8Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5433
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 22 Nov 2023 00:08:44 -0800 (PST)

From: Lukas Funke <Lukas.Funke@weidmueller.com>

Remove 'IRQF_TRIGGER_FALLING' request which is not allowed on
every interrupt controller (i.e. arm64 GIC). Replace flag by a
request that depends on the actual device-tree setting.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311221355.yxYpTIw3-lkp@intel.com/
Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
---
 drivers/extcon/extcon-usbc-tusb320.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-usbc-tusb320.c b/drivers/extcon/extcon-usbc-tusb320.c
index 4d08c2123e59..140ab28dbd36 100644
--- a/drivers/extcon/extcon-usbc-tusb320.c
+++ b/drivers/extcon/extcon-usbc-tusb320.c
@@ -17,6 +17,7 @@
 #include <linux/usb/typec.h>
 #include <linux/usb/typec_altmode.h>
 #include <linux/usb/role.h>
+#include <linux/irq.h>
 
 #define TUSB320_REG8				0x8
 #define TUSB320_REG8_CURRENT_MODE_ADVERTISE	GENMASK(7, 6)
@@ -515,6 +516,8 @@ static int tusb320_probe(struct i2c_client *client)
 	const void *match_data;
 	unsigned int revision;
 	int ret;
+	int irq_pol;
+	struct irq_data *irq_d;
 
 	priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -568,9 +571,17 @@ static int tusb320_probe(struct i2c_client *client)
 		 */
 		tusb320_state_update_handler(priv, true);
 
+	irq_d = irq_get_irq_data(client->irq);
+	if (!irq_d) {
+		dev_err(&client->dev, "Invalid IRQ: %d\n", client->irq);
+		return -ENODEV;
+	}
+
+	irq_pol = irqd_get_trigger_type(irq_d);
+
 	ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
 					tusb320_irq_handler,
-					IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+					IRQF_ONESHOT | irq_pol,
 					client->name, priv);
 	if (ret)
 		tusb320_typec_remove(priv);
-- 
2.30.2