Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp937179rdf; Wed, 22 Nov 2023 00:32:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfNhgtgX3H/OTgnlkRAuv0UIxumo+KayBSrlKLKqoFsMyHRx675AKS3J7jwnLPwC+aqFpO X-Received: by 2002:a05:6808:120e:b0:3ab:8e86:fc26 with SMTP id a14-20020a056808120e00b003ab8e86fc26mr2136567oil.46.1700641962148; Wed, 22 Nov 2023 00:32:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700641962; cv=none; d=google.com; s=arc-20160816; b=p/mbdCzG27vjLK+1sEXLr1nE1ALmvv4FYCCIA6472K4hnWlYYuLpWLZvIJ1hT6nbt1 /3YX03kz+23NCyYYo3mPiNObVCxQN+LO4JI8mHnCSv7dXJgAIWZCsVxfpXapuVk9xu7a eDdD4PAjm7RSe9QLWk0zDTb8JVhi7CRuXb3xVO/DMdNFvn7F9MN3Js2/rQ3hHc/wOQZD 9n013d6r9ceQRoRTT6u2WPnBfz3IiRMopACmeFtFLmbL8WbIPlH8BDjC5vpkb2FllStC uTTfQ8BmEZRLxuMqichZQVPcqiSIWUVBJPCfDveTrtQdqves/x5rXpAg81xd82pcT/os 2s0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=SKD7ps1yzVN9YyslM/iBpqLP523I7QRimM6aSYFE9qw=; fh=eMvwTdWCXuLO7i3TqK/xoDDobsHi6QKrqrkIykk2SDw=; b=W+T/WOBzORTwv7w5y+yPYqYQ+q+yY61gyI2MyaMKLcmo2jjsFqYvfWaWNPvOPL/TNB 4Lme/mOn9JImonFleW3KcoXA7znoCwXRgnjb4AzZ19sQlMZL8U5AuCRv79SgTfiqIBWp TIFIre2MoXcx4KpvJI0SjBqYJgETdPqt3CKehZfBakDTI6dWNW8n5WSp1i2mX28fJnSn YJMZ287iTrzOyoFOUnG3OdkM3qHSLh8hNVx3WsE/1wXK2gB+m7ejh26rV157kpirDlBq AkCOFOGRxbblpNun++eeWL1l0wIvY19jjw3Q3WN90tmhstduh80Q7SfRXA/bldJmuiUF jZUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xl9atxrt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id n5-20020a634005000000b005aa83686f32si12134283pga.42.2023.11.22.00.32.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 00:32:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xl9atxrt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C6D2881A2061; Wed, 22 Nov 2023 00:32:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235054AbjKVIce (ORCPT + 99 others); Wed, 22 Nov 2023 03:32:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230257AbjKVIcd (ORCPT ); Wed, 22 Nov 2023 03:32:33 -0500 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B5A0109 for ; Wed, 22 Nov 2023 00:32:29 -0800 (PST) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5c8c8f731aaso49017727b3.0 for ; Wed, 22 Nov 2023 00:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700641948; x=1701246748; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SKD7ps1yzVN9YyslM/iBpqLP523I7QRimM6aSYFE9qw=; b=xl9atxrtCs/O7Rljt3oJ7A8T+hwiYAonhbMg3odgk4h25Y70BWpEwUph5hmpQuDN7D DUWnVyLcwiSSADhUFGdJq5rftQnd9Trcj0BGNq5DQbYuMsLr7sLS5oUEqiZMCarvCSFs OB37XZKqRJW/308+NwTes7JnLDTros8r07dI0uAofJK4r+o7ajBTa0+NNejjJhDX1kSz LY5lhUAkLjU+FRNNck1CdFuk6uSALy/bjV4cVQzpCukH1wjpTZxBHWSvsJiNSakcf5oY nn4scrcYucAWZ7DB5V8X9B2MYZfc5e+G8K90/zSEjVhUmbm8deFJ18lSQ/zngwGiFVWy QqtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700641948; x=1701246748; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SKD7ps1yzVN9YyslM/iBpqLP523I7QRimM6aSYFE9qw=; b=T7WpaQuYiQhDMz04pjmlcwhSfqiQmucMKYdCW6nGoUI6rse8JlkDvL7rqLF1XXMvrw 9uzv+p8eZK8OOfZJh/KqdJyvSpV5Ocmh5iMfyi5V9YHW9bevAG1bFlrr5xC0YfJdcar0 SV+IQk11mKiLM4cagVwhW1vxHwzsyF+YYao4PpVqxe9B/4NmF463Wm8M4bb1Yh6BtupO aWW2M3tx5jW7oUmvg5lKa85CUGhJviDCJMIN2jQIF8US3hVJqNGiJv3sd6ws+YjuQ2UU +drSM7cjzrVCbxNTXm9GJo0+sXPC36/WBNLofV6cMT76MK1W/1mWns5J82GhPNXCV4da 2uGQ== X-Gm-Message-State: AOJu0YyyuUY9Zpx/IWQRfBKewetC4zu+dErlHb6q8doyWSAy0pc02ShB m6JyVxY8vjhQsWuXXKod/1ekD9jBAtcNfDwwHlVK/Q== X-Received: by 2002:a05:690c:4782:b0:5cc:7431:871 with SMTP id ha2-20020a05690c478200b005cc74310871mr699694ywb.25.1700641948499; Wed, 22 Nov 2023 00:32:28 -0800 (PST) MIME-Version: 1.0 References: <1700637042-11104-1-git-send-email-quic_cang@quicinc.com> <1700637042-11104-9-git-send-email-quic_cang@quicinc.com> In-Reply-To: <1700637042-11104-9-git-send-email-quic_cang@quicinc.com> From: Dmitry Baryshkov Date: Wed, 22 Nov 2023 10:32:17 +0200 Message-ID: Subject: Re: [PATCH v3 08/11] phy: qualcomm: phy-qcom-qmp-ufs: Rectify SM8550 UFS HS-G4 PHY Settings To: Can Guo Cc: bvanassche@acm.org, mani@kernel.org, stanley.chu@mediatek.com, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com, Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Johan Hovold , Abel Vesa , "open list:ARM/QUALCOMM SUPPORT" , "open list:GENERIC PHY FRAMEWORK" , open list Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 22 Nov 2023 00:32:39 -0800 (PST) On Wed, 22 Nov 2023 at 09:11, Can Guo wrote: > > The registers, which are being touched in current SM8550 UFS PHY settings, > and the values being programmed are mainly the ones working for HS-G4 mode, > meanwhile, there are also a few ones somehow taken from HS-G5 PHY settings. > However, even consider HS-G4 mode only, some of them are incorrect and some > are missing. Rectify the HS-G4 PHY settings by strictly aligning with the > SM8550 UFS PHY Hardware Programming Guide suggested HS-G4 PHY settings. > > Fixes: 1679bfef906f ("phy: qcom-qmp-ufs: Add SM8550 support") > Signed-off-by: Can Guo Reviewed-by: Dmitry Baryshkov > --- > .../qualcomm/phy-qcom-qmp-qserdes-txrx-ufs-v6.h | 3 +++ > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 28 +++++++++++++++------- > 2 files changed, 22 insertions(+), 9 deletions(-) -- With best wishes Dmitry