Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp940554rdf; Wed, 22 Nov 2023 00:41:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsvqSJg10IDSjt5bWWHdu7AYTRFVByRpP/pbMOqW3z9YGn4nPj7iPCo/2Q1m1yUEP/ywNB X-Received: by 2002:a17:902:f805:b0:1cf:669b:613c with SMTP id ix5-20020a170902f80500b001cf669b613cmr1589710plb.55.1700642492807; Wed, 22 Nov 2023 00:41:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700642492; cv=none; d=google.com; s=arc-20160816; b=g4WxcQSF2ku2+khkfvn6RBPGKQSss55Ozmubc9B8ltGLgI8EfY4Gd2KjAlpb+jJbYv sO5HCJPiSloTzjn06XmTrscSfcZAB0+8MpaXkmUdqHZoZGAaQb/reg0BaIdQxPfmOSUz ojlAw1tHHIdO2+Tbp7E/HxCyb8fzjKz6FOEbbjTMpXR3uRZmsRxm3OQ7fy+cWuD10lJI R4xRIsqcrdx045DcDR4UUwZ5CAfJKDXsHMOyDhY86DXEwax+4x5ia2r0TpKBJ/WDJWEM I1YFVqX99RLsc8SPTb+eQhO8EFMMUDj81qNcn0Aeo3hlGVK0PZYF/4Nmc7R73orrSA6c lnTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=7Wkcu8kmGItliZN0XfKbebEr2eOskFSIhLTVCyGFKXs=; fh=Ki8MRzLyE/Y/nO5gLvam90tOlc8MuUdOuXbZJ+/4Wv4=; b=gJwg1gIDzn1saNzTzPykHWnTJPuwqa1TBEYPDEDRmgr0aQbZOX/udIvliPlTadu8yW 3su4NlsgrLJW5pX+u6g/+ECLfhkYErSxwgemMaUbxv66CD2yvY6IXwKnBVdHI/ZLB7/D 6BsyvqGahxP/Nv+x4go61L6x7xNdG1w5d/nCzsf9IKQ9Sl2h0lJcSnqgWuL4ExKm0zQp 6/R1+gQVGLRdmvQsoTWze/htHq8ohplFsiEqgeDZn978Kl909n14/nfK2X3sssEHG2L3 tlsm1V/PzdOEn5Hw0cJaxJhO6jJwpY+4/+c6diqd6Nm5vJYx0pU9kv/7QbYWnrrTv1Yp MHpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="bBZ7M/Ic"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id bj12-20020a170902850c00b001cc18133022si11536520plb.285.2023.11.22.00.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 00:41:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="bBZ7M/Ic"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id CF38080AD979; Wed, 22 Nov 2023 00:41:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbjKVIlQ (ORCPT + 99 others); Wed, 22 Nov 2023 03:41:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbjKVIlO (ORCPT ); Wed, 22 Nov 2023 03:41:14 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0DF210E for ; Wed, 22 Nov 2023 00:41:09 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5484ef5e3d2so7064594a12.3 for ; Wed, 22 Nov 2023 00:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700642468; x=1701247268; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7Wkcu8kmGItliZN0XfKbebEr2eOskFSIhLTVCyGFKXs=; b=bBZ7M/IcwahMxIvIzLl3EHWe+wnJ9ZkR1B+E6HhFWxSY5JlmLFb5ETYApC3NjO9CvB b/QppfF+z9nlf9sRUHu3pNaKcVmEi8aea8sDlAQb5EzbchRjfqsSMuWAG0OHGZodfPjh 4S6z0KeB3EnC0hlJfdr1qW4TlgnVTMeJFwHwAeRugoXij7K32KeT7YzINb3ha2fWm7Pt SiKGEHXeXqqAZ2G/U0AvTuQxsVturtJdq0tKwv/5Q9bvs6pbYiJIfwdQtlaPP2IsfFg6 esiZsOobfSyETsEZZnNlQ63lhWJbaxZzTlDEReu3VycqQCpuNeLy0GI6hnhvSnD0pyin 2q+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700642468; x=1701247268; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7Wkcu8kmGItliZN0XfKbebEr2eOskFSIhLTVCyGFKXs=; b=AU9BAun3y5k4u+KFRPOPV6BFYqobHLIGaN7JCEGKA+fsYrsY4MUZrLqG2+f/XwKmo9 xLPmR1Rse2M2xzpeO0TriNX0uPECcwHf4KWPxVw+4XZOnwGjSW9Yjx4SHmI13tP3yyd7 pRZtsDwsJIgWMMmtXAl+jAhfGzoHQpHqAZVGADik1WeBcjNSJlL96FAnMdSgqGy0nWli 2vZU9lg/42WGecRkMH95wtXofgv3Ksz6lfyICR1Cpz5RxjaiHaY/a2Mhe8AhJQcph7IQ EfiMjKn+JqhqR4Blqbtyu/z7tNWD+GbEFQmo8SQeHUszkN3wVBcbu3tilo1mg+fsTNfi yrMw== X-Gm-Message-State: AOJu0YyH/WptcaABYhd7JqGwHRS1fthpRwTUhTJrSYsNVCOJ0i9Pd6Ig YWYVrtpdkuKnSGu7bkdU+ul/3Q== X-Received: by 2002:a17:906:e46:b0:9bd:bbc1:1c5f with SMTP id q6-20020a1709060e4600b009bdbbc11c5fmr1002158eji.35.1700642468424; Wed, 22 Nov 2023 00:41:08 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.100]) by smtp.gmail.com with ESMTPSA id a1-20020a170906190100b009a19701e7b5sm6321163eje.96.2023.11.22.00.41.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 00:41:08 -0800 (PST) Message-ID: Date: Wed, 22 Nov 2023 09:41:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] arm64: dts: amlogic: migrate pwms to new meson8 v2 binding Content-Language: en-US To: Jerome Brunet , Thierry Reding , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Kevin Hilman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org, JunYi Zhao References: <20231117125919.1696980-1-jbrunet@baylibre.com> <20231117125919.1696980-7-jbrunet@baylibre.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231117125919.1696980-7-jbrunet@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 22 Nov 2023 00:41:24 -0800 (PST) On 17/11/2023 13:59, Jerome Brunet wrote: > Update Amlogic based SoC PWMs to meson8-pwm-v2 compatible Please write proper commit msgs. > > Signed-off-by: Jerome Brunet ... > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi > index 18f7b730289e..690552e5a104 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi > @@ -237,8 +237,6 @@ &pwm_ef { > status = "okay"; > pinctrl-0 = <&pwm_e_pins>; > pinctrl-names = "default"; > - clocks = <&clkc CLKID_FCLK_DIV4>; > - clock-names = "clkin0"; > }; > > &saradc { > diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > index 2673f0dbafe7..bf00672b9009 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi > @@ -329,14 +329,14 @@ i2c_A: i2c@8500 { > }; > > pwm_ab: pwm@8550 { > - compatible = "amlogic,meson-gx-pwm", "amlogic,meson-gxbb-pwm"; > + compatible = "amlogic,meson8-pwm-v2"; This is just wrong. NAK. Replacing specific and correct (nothing in commit msg said these are incorrect!) compatibles with generic, unspecific one is a no-go. It does not make sense to replace correct code with incorrect... Best regards, Krzysztof