Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp952041rdf; Wed, 22 Nov 2023 01:07:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmCV6Y9XHqFRcXzDYFPjSuOIa5GJTIjv9xKu278Zj1VuRS80v7HuUEez3eKgu6rAW/tI4b X-Received: by 2002:aca:230b:0:b0:3b6:ccce:b20f with SMTP id e11-20020aca230b000000b003b6ccceb20fmr1998269oie.33.1700644047803; Wed, 22 Nov 2023 01:07:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700644047; cv=none; d=google.com; s=arc-20160816; b=LohQIfKjWwz7eAKdd07RtT90c42d90mEkZQUzofqvI0pqqKdaNkHggkQILpuiIuETm YvWjgngF/KEN+rmnSPf0maap+dVffHLZrC5lmz4uMNySOF/XJdKSWUFBP3ahyDZa5+/5 CkgqDAcE30VOiodfMFyhDkB4vPZjUpS7KVkkkiPxuEhdQoKBWdoPQ0bGEyBxPHuTT6jN VktXzSfg/K8Ui93cgrcNnrRKpdKVUV3Sxq8GEuhLR3VWikx2tV+cYFmz8wqf97hTu0q+ 2Emjbn3XuvtTMYhTWxtmyZNamugqF6ZUUw39PSgQZI+Zq01CqCEoe9jQLdJq6TOlFITS NqUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:reply-to:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=xVjBPzvWlzEGqqaX8S5wRVinJtydKB4lYeGuIuO+E6Y=; fh=I9fUWaVgxv7hK8MxLn0fUnKG6dE6MSFgPTJFnnLWtv8=; b=IS2eX/nzb4v41M8RD1Ex7l7/v6LcA2Of0QcexDieYoKKFMcpwfohdCBMKqicn2BCb2 6vZShvrIB2Z+DeDC1P9jZ4s5GCF/EIvAAcdphL+XfZo645rwh7yfMVFzJ77bEKw5daa/ CcB5FlYQyzXaxspLKg/D7yPujAzudOABT8kqQRpSNIqZHCZi3rEF6MZjwdG11GuS7zTI GzTzFBjMaBDVQMA6NrtXHMMEBKif6k8ZyYlneKadtcIO9Gd0wchwFGl4z1rk0JJzzdyM EBjQpvQgXfddte/l6+sS+OAd81UiIcH4HAma1ppVnauGILnxHCjvzLETn66pE640ptGT UBxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s+YXIoEo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id a20-20020a634d14000000b005c20241fdf2si11921592pgb.49.2023.11.22.01.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 01:07:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s+YXIoEo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 628BF80294D4; Wed, 22 Nov 2023 01:03:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235216AbjKVJDl (ORCPT + 99 others); Wed, 22 Nov 2023 04:03:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343575AbjKVJB0 (ORCPT ); Wed, 22 Nov 2023 04:01:26 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D42DCF4 for ; Wed, 22 Nov 2023 01:01:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id 1CFE5C4E67D; Wed, 22 Nov 2023 09:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700643676; bh=0b1oOIKSonoNpzqhYrexAH7NPPnUv6uLf+ZzCDCtDjc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=s+YXIoEoo/dp7X6bX6RpMGJAL3TPO/0fWA4VZRdMFKU4BNdpvz/0wp1A6ppiJCcIp jT5FEYe1j2ocMX9bWvE6aF4xpiJ2DWR9fFsgJNAOcMU/Dpmt/r5hKqhj10VYtXEkcs XItAxQ7ucYiL270/OPNkzywg5ld1+lKSW6Q4swTaL4RsF7sqFXEKh+ssUDYXBp1ab5 /RxSwrwLg21gvNF2752Izy9YD5sSCVGfObRR/fT6VZjEEswlfP2WwOGLrAhcISfuuD 8YFiXaBm/OgFpebG44UfSe8RwEcfGeqzoB6CeUoF/fqmCEe3B0beMnVvzbopYvqyys i8gLCVoxa4qUw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A5F0C61DB1; Wed, 22 Nov 2023 09:01:16 +0000 (UTC) From: Nikita Shubin via B4 Relay Date: Wed, 22 Nov 2023 12:00:12 +0300 Subject: [PATCH v5 34/39] pwm: ep93xx: drop legacy pinctrl MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20231122-ep93xx-v5-34-d59a76d5df29@maquefel.me> References: <20231122-ep93xx-v5-0-d59a76d5df29@maquefel.me> In-Reply-To: <20231122-ep93xx-v5-0-d59a76d5df29@maquefel.me> To: Hartley Sweeten , Alexander Sverdlin , Russell King , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Nikita Shubin , Linus Walleij , Damien Le Moal , Dmitry Torokhov Cc: Sergey Shtylyov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Alexander Sverdlin X-Mailer: b4 0.13-dev-e3e53 X-Developer-Signature: v=1; a=ed25519-sha256; t=1700643671; l=4467; i=nikita.shubin@maquefel.me; s=20230718; h=from:subject:message-id; bh=5BHGSx0rvPz4xyQWEXwBhZIRB6xUAXP0jsfbP3JUPqk=; =?utf-8?q?b=3Du+NbkYcgvcPH?= =?utf-8?q?BPZ1uMc807B8+XPrq3vATcMYNI/EMFnVsvMCr3QbwLoH5izcR4ZgIOE8qpIkqExI?= BDZ6kfjKCAjlCrx3D9gGjW1yq0V8wXV3fCdsFxmGDoJcUmh3njex X-Developer-Key: i=nikita.shubin@maquefel.me; a=ed25519; pk=vqf5YIUJ7BJv3EJFaNNxWZgGuMgDH6rwufTLflwU9ac= X-Endpoint-Received: by B4 Relay for nikita.shubin@maquefel.me/20230718 with auth_id=65 X-Original-From: Nikita Shubin Reply-To: X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 22 Nov 2023 01:03:58 -0800 (PST) From: Nikita Shubin Drop legacy gpio request/free since we are using pinctrl for this now. Acked-by: Uwe Kleine-König Acked-by: Thierry Reding Acked-by: Linus Walleij Signed-off-by: Nikita Shubin --- arch/arm/mach-ep93xx/core.c | 42 --------------------------------------- drivers/pwm/pwm-ep93xx.c | 18 ----------------- include/linux/soc/cirrus/ep93xx.h | 4 ---- 3 files changed, 64 deletions(-) diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c index c60a9d3632dd..9afc6095d1c1 100644 --- a/arch/arm/mach-ep93xx/core.c +++ b/arch/arm/mach-ep93xx/core.c @@ -576,48 +576,6 @@ void __init ep93xx_register_pwm(int pwm0, int pwm1) platform_device_register(&ep93xx_pwm1_device); } -int ep93xx_pwm_acquire_gpio(struct platform_device *pdev) -{ - int err; - - if (pdev->id == 0) { - err = 0; - } else if (pdev->id == 1) { - err = gpio_request(EP93XX_GPIO_LINE_EGPIO14, - dev_name(&pdev->dev)); - if (err) - return err; - err = gpio_direction_output(EP93XX_GPIO_LINE_EGPIO14, 0); - if (err) - goto fail; - - /* PWM 1 output on EGPIO[14] */ - ep93xx_devcfg_set_bits(EP93XX_SYSCON_DEVCFG_PONG); - } else { - err = -ENODEV; - } - - return err; - -fail: - gpio_free(EP93XX_GPIO_LINE_EGPIO14); - return err; -} -EXPORT_SYMBOL(ep93xx_pwm_acquire_gpio); - -void ep93xx_pwm_release_gpio(struct platform_device *pdev) -{ - if (pdev->id == 1) { - gpio_direction_input(EP93XX_GPIO_LINE_EGPIO14); - gpio_free(EP93XX_GPIO_LINE_EGPIO14); - - /* EGPIO[14] used for GPIO */ - ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_PONG); - } -} -EXPORT_SYMBOL(ep93xx_pwm_release_gpio); - - /************************************************************************* * EP93xx video peripheral handling *************************************************************************/ diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c index 361984ef4c0b..ac08bd0e7572 100644 --- a/drivers/pwm/pwm-ep93xx.c +++ b/drivers/pwm/pwm-ep93xx.c @@ -27,8 +27,6 @@ #include -#include /* for ep93xx_pwm_{acquire,release}_gpio() */ - #define EP93XX_PWMx_TERM_COUNT 0x00 #define EP93XX_PWMx_DUTY_CYCLE 0x04 #define EP93XX_PWMx_ENABLE 0x08 @@ -45,20 +43,6 @@ static inline struct ep93xx_pwm *to_ep93xx_pwm(struct pwm_chip *chip) return container_of(chip, struct ep93xx_pwm, chip); } -static int ep93xx_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm) -{ - struct platform_device *pdev = to_platform_device(chip->dev); - - return ep93xx_pwm_acquire_gpio(pdev); -} - -static void ep93xx_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm) -{ - struct platform_device *pdev = to_platform_device(chip->dev); - - ep93xx_pwm_release_gpio(pdev); -} - static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, const struct pwm_state *state) { @@ -157,8 +141,6 @@ static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, } static const struct pwm_ops ep93xx_pwm_ops = { - .request = ep93xx_pwm_request, - .free = ep93xx_pwm_free, .apply = ep93xx_pwm_apply, .owner = THIS_MODULE, }; diff --git a/include/linux/soc/cirrus/ep93xx.h b/include/linux/soc/cirrus/ep93xx.h index ea2b2c1074e4..fc4a2f9d4729 100644 --- a/include/linux/soc/cirrus/ep93xx.h +++ b/include/linux/soc/cirrus/ep93xx.h @@ -37,8 +37,6 @@ struct ep93xx_regmap_adev { container_of((_adev), struct ep93xx_regmap_adev, adev) #ifdef CONFIG_ARCH_EP93XX -int ep93xx_pwm_acquire_gpio(struct platform_device *pdev); -void ep93xx_pwm_release_gpio(struct platform_device *pdev); int ep93xx_ide_acquire_gpio(struct platform_device *pdev); void ep93xx_ide_release_gpio(struct platform_device *pdev); int ep93xx_i2s_acquire(void); @@ -46,8 +44,6 @@ void ep93xx_i2s_release(void); unsigned int ep93xx_chip_revision(void); #else -static inline int ep93xx_pwm_acquire_gpio(struct platform_device *pdev) { return 0; } -static inline void ep93xx_pwm_release_gpio(struct platform_device *pdev) {} static inline int ep93xx_ide_acquire_gpio(struct platform_device *pdev) { return 0; } static inline void ep93xx_ide_release_gpio(struct platform_device *pdev) {} static inline int ep93xx_i2s_acquire(void) { return 0; } -- 2.41.0