Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp953863rdf; Wed, 22 Nov 2023 01:11:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHz1rlmrjkjY9H/1zGXKMYmvCs7YvTvGwESCi/mPImKprvCTVDAHa2ihgNbr54VFaZlDuxu X-Received: by 2002:a05:6a00:4287:b0:690:d620:7801 with SMTP id bx7-20020a056a00428700b00690d6207801mr2052836pfb.11.1700644289116; Wed, 22 Nov 2023 01:11:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700644289; cv=none; d=google.com; s=arc-20160816; b=RJaHUd7KZuvpwl1UskN29YtdMsVIOc+BN+puzbGGIPJtdveYz3ghN+u/MjjLIQw84N VlUH5YMBZOytRQ+qf9Lr4oPZU48/ae1o1y0G4LxEthp2pTIs56msXZbVIrP+m+f9fad/ z/RgRp8mSNFxd55ty/Yv54NzRdPnupHHKTXH3i040IlsDBOWEsL8P5ywEFiD+ir1+u3Z a0uIAQ8M/b31J9Tx4tEUTwyzh4c3NTrA3huLei7qtffPnKFVo/V6VoqmqPHLONFfUQsY 6t9RvLyXA5AxTJ/dm6a8NoXfR1jAVKQQ24RRZ/+iOShQT9/iBusNT3bY/OwZ19IMRRUB KNbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=K5UVn0/IoE/i39vG/S5P95vjTryqzFZW31nMPHoqGEA=; fh=d0EtQ3eMwNnd9hyip2xPgF606TjFYfZE9NT0/hBYPEk=; b=IJamXzUqUrujiohUXDAp6dIJMgRj2sIbJcJhnsnuh3oBCkUzghhm1dpsHC2cqTICAP v3LzrUkG5c22E5z8svgrJo+Pxm8GvDEU9+MX/v8OlEqde3U8t+57oqdhEl2UJ4Eu9wjZ ODxQkX9UKGxOCyz99Os6O7coWlXCja1dTxykjHuqowSb6m1hfRwL3y32yXemfPqb5rx0 DHEvBlWoqQpQnTfKG5oFQASqD77030vXdYs8WmRD8QwLSBrCnzQQjCqcd8lmJg5VB2to HwM0TtR741O5hhVifKRHBCKV5BfGYFzas5Tn8gyRB8oBjKs1cf/cFPEZ0QoL5NjFbGsB ekQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id fc23-20020a056a002e1700b006c1222c5eaasi12701881pfb.175.2023.11.22.01.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 01:11:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 31B09804392C; Wed, 22 Nov 2023 01:08:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235125AbjKVJIH (ORCPT + 99 others); Wed, 22 Nov 2023 04:08:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235123AbjKVJHt (ORCPT ); Wed, 22 Nov 2023 04:07:49 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13D942684; Wed, 22 Nov 2023 01:04:55 -0800 (PST) X-UUID: a7243eea2bb4484da5eecc3a6a940782-20231122 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:30d706e5-2215-47f0-ba78-3b214e0a0653,IP:10, URL:0,TC:0,Content:-5,EDM:0,RT:19,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,AC TION:release,TS:9 X-CID-INFO: VERSION:1.1.32,REQID:30d706e5-2215-47f0-ba78-3b214e0a0653,IP:10,UR L:0,TC:0,Content:-5,EDM:0,RT:19,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:9 X-CID-META: VersionHash:5f78ec9,CLOUDID:14b15960-c89d-4129-91cb-8ebfae4653fc,B ulkID:2311221523287WIPHSL6,BulkQuantity:4,Recheck:0,SF:64|66|24|17|19|44|1 02,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:40,QS:nil,BEC:nil,COL :0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: a7243eea2bb4484da5eecc3a6a940782-20231122 X-User: chentao@kylinos.cn Received: from [172.21.13.26] [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 188473119; Wed, 22 Nov 2023 17:04:50 +0800 Message-ID: <37452b03-9c24-42a7-bb4f-ed19f622f0ef@kylinos.cn> Date: Wed, 22 Nov 2023 17:04:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ipv6: Correct/silence an endian warning in ip6_multipath_l3_keys Content-Language: en-US To: Christoph Hellwig Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jkbs@redhat.com, kunwu.chan@hotmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231122071924.8302-1-chentao@kylinos.cn> From: Kunwu Chan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 22 Nov 2023 01:08:15 -0800 (PST) Hi Christoph, Thanks for your reply. I also can't guarantee that it's the right thing to do. Just wanted to dispel this warning. If you have any better way, please let me know. On 2023/11/22 15:23, Christoph Hellwig wrote: > On Wed, Nov 22, 2023 at 03:19:24PM +0800, Kunwu Chan wrote: >> net/ipv6/route.c:2332:39: warning: incorrect type in assignment (different base types) >> net/ipv6/route.c:2332:39: expected unsigned int [usertype] flow_label >> net/ipv6/route.c:2332:39: got restricted __be32 > > Can you expain why you think the __force cast is the correct thing to do > here?