Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp954284rdf; Wed, 22 Nov 2023 01:12:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IGh7gSorIizytfvlofzPhulBBnGWiItl+DdDAcRn72kfhXRZACjsLQauFKajqgnMtOaK/c+ X-Received: by 2002:a9d:6f1a:0:b0:6d6:4972:b7ae with SMTP id n26-20020a9d6f1a000000b006d64972b7aemr2296426otq.13.1700644343545; Wed, 22 Nov 2023 01:12:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700644343; cv=none; d=google.com; s=arc-20160816; b=oSGLav8/1TdtbOSuVJ1yv0oWXlR5/ufH6mxFDLFO24sZFO95a26jFp6yeQHpe6K3Yu fIZ3lX/DE/glFY+DhMh6CEgP3P5EmBZP/wAk3pV0LQdeXbpNpeH6I6FpNFBU1jIdm91O KuLZg2utk2+yK20Rx2vcWu+JNSjbb0Ys1Bj+vRUeX1ZKPra8iXMKtQ/DBXh87xWEv5LQ E2hIBJkm42Eg9vE12q/dUgTvbgYoz4QU3E9Vqj8EuSSaCJijeZJ59Niw8TE4zRV4JeqA IHtk8OjZ1oQueBi/lFi9aX5jQ9sEBmxfP5uCJIpiqHRwnX6dLfNNqj8cAPjOZCBwtNLP Tdyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=0LmLpncZ7ZPLn6Iin3MIZKsAE3YQeRteHqQvwpY4M0U=; fh=LHTnc1Qwl4yiVMEiTersJbu+mnh7AT2RPrvRvVhYXk8=; b=Z/wxOgRCK5xnrz23BjdVBHWZPRUot+IwKqmQHBqnT9EObj/MVcpXEUluIJJJpa+Wyu noC7Hn2Cjemfdujdo57it1qXAJ4K8UqvtfIkXeyV640tyPjeQdtaJZF9MpRTkXURFo6J 5e8s5yxvUjBkNEW/QNdmu7r6GQQdhiJizzmwR3Aqrhg0zLrU0i02NHm3RHe9HcPvCjm9 oYzyfCctpXfMHHW/XSDUKBIDkczLF+gjwJGFgpef+T2mUCjH+/JB2ldS1Ubc60Tj7B9i GdR9JAlwSTcgUnNKggF102sYTaqUB3VmveVC86RAOostGuZvSKFyAD0Carahh8W8OzUY cldg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=H7GSmfP2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id k26-20020a63561a000000b005bd3d377a54si12427922pgb.123.2023.11.22.01.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 01:12:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=H7GSmfP2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 7E82F8088A50; Wed, 22 Nov 2023 01:12:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbjKVJL7 (ORCPT + 99 others); Wed, 22 Nov 2023 04:11:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbjKVJL6 (ORCPT ); Wed, 22 Nov 2023 04:11:58 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9555E83; Wed, 22 Nov 2023 01:11:53 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AM5bWBI029251; Wed, 22 Nov 2023 09:11:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=0LmLpncZ7ZPLn6Iin3MIZKsAE3YQeRteHqQvwpY4M0U=; b=H7GSmfP2I6OAMrteaxVyARiGUXzl6m+5XFHonwnnziww0plu5e40Sn7WatOM0b2yx5mh 5TTdcD2kl/CLkC1YsD4temhUQGNQzWk9sD0vmWWsPK0BD4Stw2eB1WQ9z1zUP4rhmTti hTLfDRBlCNMdkXixGPIAUMFBH968NFRyQvyzVQZxBVDZxc8gtoaksll24uJmqsERWDcD wRU1bmA2CYM2Ggftq7YR15RLpynd8WLSC5TP5/njU42IZ2UrOp+oBeaHQnL68euFKOqz 8aX1qmapxyHrWATz2m7XXMlOEhL16Te54QPSECrJSyyphE9UPIIZfI9UkRTUu52bvgvr og== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uh8mw8y78-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Nov 2023 09:11:50 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AM9BoGL019426 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Nov 2023 09:11:50 GMT Received: from hu-uaggarwa-hyd.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 22 Nov 2023 01:11:47 -0800 From: Uttkarsh Aggarwal To: Thinh Nguyen , Greg Kroah-Hartman CC: , , "Uttkarsh Aggarwal" , Subject: [RFC] usb: dwc: ep0: Use -ESHUTDOWN in dwc3_ep0_stall_restart Date: Wed, 22 Nov 2023 14:41:27 +0530 Message-ID: <20231122091127.3636-1-quic_uaggarwa@quicinc.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 7nz0rxhFdPU3BWU14Y79CcZShWtnNe1c X-Proofpoint-ORIG-GUID: 7nz0rxhFdPU3BWU14Y79CcZShWtnNe1c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-22_06,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1011 mlxlogscore=613 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311220063 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 01:12:20 -0800 (PST) Current implementation blocks the running operations when Plug-out and Plug-In is performed continuously, process gets stuck in dwc3_thread_interrupt(). Code Flow: CPU1 ->Gadget_start ->dwc3_interrupt ->dwc3_thread_interrupt ->dwc3_process_event_buf ->dwc3_process_event_entry ->dwc3_endpoint_interrupt ->dwc3_ep0_interrupt ->dwc3_ep0_inspect_setup ->dwc3_ep0_stall_and_restart By this time if pending_list is not empty, it will get the next request on the given list and calls dwc3_gadget_giveback which will unmap request and call its complete() callback to notify upper layers that it has completed. Currently dwc3_gadget_giveback status is set to-ECONNRESET, whereas it should be -ESHUTDOWN. Cc: Fixes: d742220b3577 ("usb: dwc3: ep0: giveback requests on stall_and_restart") Signed-off-by: Uttkarsh Aggarwal --- drivers/usb/dwc3/ep0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index b94243237293..8317fedda1c0 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -238,7 +238,7 @@ void dwc3_ep0_stall_and_restart(struct dwc3 *dwc) struct dwc3_request *req; req = next_request(&dep->pending_list); - dwc3_gadget_giveback(dep, req, -ECONNRESET); + dwc3_gadget_giveback(dep, req, -ESHUTDOWN); } dwc->eps[0]->trb_enqueue = 0; -- 2.17.1