Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <7dcd5d24-800b-4c58-a308-e0fda2b8dfbc@intel.com>
Date:   Wed, 22 Nov 2023 10:11:47 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [net PATCH v2] octeontx2-pf: Fix ntuple rule creation to direct
 packet to VF with higher Rx queue than its PF
To:     Suman Ghosh <sumang@marvell.com>, <sgoutham@marvell.com>,
        <gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
        <lcherian@marvell.com>, <jerinj@marvell.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <horms@kernel.org>
References: <20231121165624.3664182-1-sumang@marvell.com>
Content-Language: en-US
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231121165624.3664182-1-sumang@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTNPNTlWTTM5U2JrV3dGbjZSWStaZ1FQbm9PekQ3L0NIcWVaL2RMQXpRcjds?=
 =?utf-8?B?WkdtWXRYaUoxVUEvYmtkMVdzTkFlOVZ6cWNmZ2RJbHdVY3dTWTlrK1o0YUR3?=
 =?utf-8?B?NTFGU3BkV3RRL0FtRFBKaE9HcTAyRVpTSmhGdTFvVWUzaGQ4azAxQTc5NVM2?=
 =?utf-8?B?M29SSjc5SVFzNTM0Y3ExWEhSVVlxN1I3YlBVeWRYU1hFMlRMWVdYVVJBeEVw?=
 =?utf-8?B?ZDRwZFNSWkhQZXdEcHhBcWx2d09ycU9Obm9JNWdHZCthQzdKWFJzOUNhYkFT?=
 =?utf-8?B?ZG5IQlVINHFXMXlITCs3clRLQWU0cldmZ2pyMU5lN2g3cHFSbGtwTlFvTTFL?=
 =?utf-8?B?QW1YQWtKcjZSRkY4K3cvN0NpQldteXd1bDNPS1VnZmkxVFlVRVhaR1FyWDZH?=
 =?utf-8?B?dUFvbFFNUmRFcE5hR1grbk9HWXRsNlllbW1pTzRwMVB0Z1lYQmdTVTNMK1JP?=
 =?utf-8?B?c3FtN2VzcFpBckw0OTRUdGJ4TklaK0thdUFobzdFdHFHcWVzR2k4VGpXbUdz?=
 =?utf-8?B?WVlSSUVkTjFJcS9SdmYvT2VqMGc0ZDVsdUZSUDg5SVF4NmRhYm1Sb3JHNnkr?=
 =?utf-8?B?S3VlZTBXUEdBcVJyZWNrMk1pUjNtblU4a0NoMEQzYUUxVmlMemZMNHJ1cnFy?=
 =?utf-8?B?Y083UUdCUk1udmxyVDdqMGJZMlZsOHY2SkNiTlFObXJVNWg4ZTdvY1lDMmF4?=
 =?utf-8?B?WnhqMllxa3BydEowblpMc2d3M1Z1WTE5VXVDSWxlMGgxQjQ4cUhZNDUrallh?=
 =?utf-8?B?aUhwN05qdFJZUDU5OFlGUkRubXlCNmpCc200THA0TytscGliUHlNQ2JKZ3ZG?=
 =?utf-8?B?a2pmczIraGhKWEVSdTgxRkFTVnpNMVB2WElPbk1CMjhFdFZHQUNoajFkWita?=
 =?utf-8?B?VVV1bkk3Z1JCNWw4ZXMwb3NNSEpuNllFRkpEbjBnQWNFNVlrM2NBOFRJMmVD?=
 =?utf-8?B?SzRhVUgwT2c2TVowMGxlZ01mWDQyelNtYTVNaXg4UWNtbWY3M2xQWDFNcmZ2?=
 =?utf-8?B?eHNiMGFJdE5NY0M1czNTUVpma3ZSYmI4WFhSWkU1VUtQdHpVb2FBSmhSM1h2?=
 =?utf-8?B?Uk9nVVV5UmpqNld6ZEhOZlpJOWl6TWFveGxaY1BWajRLNkVMb0c5QkRpNWNJ?=
 =?utf-8?B?a0NuY1IybEExdzBOa1J1QkIyZEZrM2dlOTZtZ0RoT2VPSm1xVmoyVGY3d1dh?=
 =?utf-8?B?c3dSSUhHZlRobWFFWGJoNVAxRGxob2FNV3F0UldFdnFtMW1BQXJrb3MrSDJr?=
 =?utf-8?B?cnZZL2w3M3F3QkJ2OEp4cUxCRmkzZmlNWHU2d0dSbkpoTjFLdlU1RnBuVW5G?=
 =?utf-8?B?NXBMaTdDMjRuRGVHZ0F2Qm9XRWVrTjl0SnBodmcwQWFacGJiZmR0V1Y5K1lP?=
 =?utf-8?B?bm9rNjBjM29wMEEwck1kZnVrcjllSTFidnltN2tWSUVuWlZRZ0JWSkNZc0JK?=
 =?utf-8?B?NWpqeHZZRVpCWktkU2xjMW5velIzTVlXQTlDS3FEbHYyeDJ0NHdHT0thVTNG?=
 =?utf-8?B?VjlvNGNDT3ptbFkxNVEvOFdtYkdOekR4K2hCcGZWS3NiUUVSV2p3czN6WHYw?=
 =?utf-8?B?dUtyMGNjZUFPTHB1OXFQNzBXNVB5Ymg0dVRjR0pPejBPRDI4cFhpYzR2VzVt?=
 =?utf-8?B?cDBVVG5XcHFLRFE1Y3Y2YXcvM290Q0U4NFlBZ0tYOGw1bkFJVVN0cGJsUUNF?=
 =?utf-8?B?TlpEclRaT1VBWjhuejAzTGl3WlhJZjltSEhyV20wM3Fmcjc3dmFycXh4WXhD?=
 =?utf-8?B?blJ0bi9NcnBoNjZOV3FlTFRzRWhvWnpEbVpkenh2eFFPNy83Y3VDMWxEazVh?=
 =?utf-8?B?RC9MN1pySk4wMTZlWUNkWkFTd3VqV2ZuOFFpVFdKZWVYcnM0d04xQjR3RW9S?=
 =?utf-8?B?eDQ5ODcvSDIvQWpZQlp5ZmNwMWlRVE5Pc0Vqa1Z0bUNaME5LM2QvVE0wVWQr?=
 =?utf-8?B?QmZ5Ly9WaEtSRFZxKzJ6ZmxZWlgrbGFwdUtETEM1NUFBSE41OEdNT0hRbDJY?=
 =?utf-8?B?TXUyVUNpTEFDRmN5a1pSUmV6cUVOU1JxVndRQld0NUFCYmRzdWh1R0NBUGhi?=
 =?utf-8?B?bGprTjZnYTM1YjFNc1M0bHhhUlJhZURCbnZ0ODJ5Sk1vbG1aWVBjNE9zdkI4?=
 =?utf-8?B?cnVqYkVndlBxMUNxSVRvek1hUytNeFFXcXhlVVNZWjk3clpFeHFQZ21wMWZH?=
 =?utf-8?B?N1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f1cd7d3-14e8-4143-0197-08dbeb3b120b
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 09:11:54.4067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /i1AKET7lVbBesjfFhjzViu4MNGLE4GQPsysltbYMgjWCyC8F8BY/90/SBO3vjvflTXPmD1OiUxIf5oMkp3OE2JI59CZBgi7D5zPiARHJ7M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6080
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 01:12:27 -0800 (PST)


On 21.11.2023 17:56, Suman Ghosh wrote:
> It is possible to add a ntuple rule which would like to direct packet to
> a VF whose number of queues are greater/less than its PF's queue numbers.
> For example a PF can have 2 Rx queues but a VF created on that PF can have
> 8 Rx queues. As of today, ntuple rule will reject rule because it is
> checking the requested queue number against PF's number of Rx queues.
> As a part of this fix if the action of a ntuple rule is to move a packet
> to a VF's queue then the check is removed. Also, a debug information is
> printed to aware user that it is user's responsibility to cross check if
> the requested queue number on that VF is a valid one.
> 
> Fixes: f0a1913f8a6f ("octeontx2-pf: Add support for ethtool ntuple filters")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

> v2 changes:
> - Removed 'goto' and added the new condition to existing if check.
> 
>  .../marvell/octeontx2/nic/otx2_flows.c        | 20 ++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> index 4762dbea64a1..97a71e9b8563 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
> @@ -1088,6 +1088,7 @@ int otx2_add_flow(struct otx2_nic *pfvf, struct ethtool_rxnfc *nfc)
>  	struct ethhdr *eth_hdr;
>  	bool new = false;
>  	int err = 0;
> +	u64 vf_num;
>  	u32 ring;
>  
>  	if (!flow_cfg->max_flows) {
> @@ -1100,7 +1101,21 @@ int otx2_add_flow(struct otx2_nic *pfvf, struct ethtool_rxnfc *nfc)
>  	if (!(pfvf->flags & OTX2_FLAG_NTUPLE_SUPPORT))
>  		return -ENOMEM;
>  
> -	if (ring >= pfvf->hw.rx_queues && fsp->ring_cookie != RX_CLS_FLOW_DISC)
> +	/* Number of queues on a VF can be greater or less than
> +	 * the PF's queue. Hence no need to check for the
> +	 * queue count. Hence no need to check queue count if PF
> +	 * is installing for its VF. Below is the expected vf_num value
> +	 * based on the ethtool commands.
> +	 *
> +	 * e.g.
> +	 * 1. ethtool -U <netdev> ... action -1  ==> vf_num:255
> +	 * 2. ethtool -U <netdev> ... action <queue_num>  ==> vf_num:0
> +	 * 3. ethtool -U <netdev> ... vf <vf_idx> queue <queue_num>  ==>
> +	 *    vf_num:vf_idx+1
> +	 */
> +	vf_num = ethtool_get_flow_spec_ring_vf(fsp->ring_cookie);
> +	if (!is_otx2_vf(pfvf->pcifunc) && !vf_num &&
> +	    ring >= pfvf->hw.rx_queues && fsp->ring_cookie != RX_CLS_FLOW_DISC)
>  		return -EINVAL;
>  
>  	if (fsp->location >= otx2_get_maxflows(flow_cfg))
> @@ -1182,6 +1197,9 @@ int otx2_add_flow(struct otx2_nic *pfvf, struct ethtool_rxnfc *nfc)
>  		flow_cfg->nr_flows++;
>  	}
>  
> +	if (flow->is_vf)
> +		netdev_info(pfvf->netdev,
> +			    "Make sure that VF's queue number is within its queue limit\n");
>  	return 0;
>  }
>