Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <1e9ac484-5764-496d-ab00-9690d9042c91@gmx.de>
Date:   Wed, 22 Nov 2023 10:31:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] serial: imx: also enable Transmit Complete interrupt in
 rs232 mode
To:     Rasmus Villemoes <rasmus.villemoes@prevas.dk>, sherry.sun@nxp.com
Cc:     festevam@gmail.com, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, kernel@pengutronix.de,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        s.hauer@pengutronix.de, shawnguo@kernel.org,
        eberhard.stoll@kontron.de
References: <AS8PR04MB8404D066C247F5B2979CBD1F92BBA@AS8PR04MB8404.eurprd04.prod.outlook.com>
 <dbe5959d-2b68-4f16-89ee-32538aab4f34@gmx.de>
 <5ad44085-c90b-4a88-bb7b-8ddc2b612793@prevas.dk>
Content-Language: en-US
From:   Eberhard Stoll <eberhard.stoll@gmx.de>
In-Reply-To: <5ad44085-c90b-4a88-bb7b-8ddc2b612793@prevas.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Xok3tUOxw2c=;3lXZGwwkRvCGRTyJEdEPP0+gM7G
 W4N+ft0emvZQMWVag/hBsaeuiovcL7FBRwrnWCi50LwWPi/tWAMhop46aCwnuUdPfFWK3tNGA
 Ql2AiICpN3cWF9grab30mgvq80Hed/23DFMJl5SqsRsW10GOTNsGmxF3mZF2PCp/3efq4ja2A
 V/4ckNgjH4XkS6P18oBa90BpitLNnqocraA9LxnO+8qJ8l2bDJOu/XZPBzJrYw+2vaYGtQLQv
 jsF5W/a425xSzBixFgtCQlSGyn3VejVUW/S6557DzQdDb7i/vNwO+wfDvGcxVx/h8THIjAs7e
 Ssv9+VgyBaJ2BCVSVkydcctt5v3VsIaR3ce0r+yKwGkVoZG+xxbmcMqT2MNGHWeKVzxSRXkm7
 Cynb6vrHByLC2uk8wdoSfLLhMg+mN50PLS2VTTLtJiSn0ZjZVlqowSem3G9mWJqW+nWEVOiWZ
 yvOYTRm2jRSkcWNWZ7tPRjCyxxb0qx8tbBWyjVVvlo7qEV1h6u0wmzo0D8w11FNDnqDqQY/oC
 mSlw7X5TLUg6rS466p5A9tgptVxwBD7Adva+Wbaq/vhMa/O2GpjwuaFgWipkfBqLWd7YxvW4E
 ncTF7bLcQSl13axaBP15+dgEmDCc99Y0xQQJA+QIeI/8wyxHIxXOu46T9aCo5Z8xqKakcilhX
 hAT5rhDJYfKwtrznixn3nVKLB+eMZa797FLWMhDPm3ostKh5b+Uz2h94wDkQ6RoA1WzSfjwqh
 TjawZxr+mSS4byC1sGmORxL0Bhnw1TQZry1KZXqhbfhenDXvPRm2U3DHWwwOobqMZ3kR91ejA
 rZNoQ7Oi11kexeUfkI97hG0ryPJZrjEEC0Um6Rp9rERmqOSO1cfJ3cfGCSKtRB2ODWV2ejsuR
 AFQeUwOHDOijaFhUXuNsBj885IO6cUdcLPkXTiCZo25qytZ1DfH+5XKw9PvC0m8QO+z2yS1/N
 qMRjl3y7PA1UyUl3ghS2Shcj+jQ=
Precedence: bulk


>> i can observe a very similar situation, but with a litte different
>> configuration. This is how i can trigger the situation very quickly:
>>
>>  =C2=A0 1) open the port
>>  =C2=A0 2) send 1 byte out
>>  =C2=A0 3) close the port
>
> Hi Eberhard
>
> Thanks for chiming in. I assume this is all in rs485 mode, no switching
> to rs232 and back involved?

Yes, no mode switching is involved here. Only rs485 mode.

>> Setting ->tx_state =3D SEND in imx_uart_shutdown() helps for my issue
>> (and should be ok IMHO).
>
> [I assume you mean tx_state =3D OFF]. Yes, I suppose doing that would be=
 > ok, but I'm not sure it's a complete fix. In my simple test cast, I hav=
e

Oh, yes, sorry my mistake!
I really meant ->tx_state =3D OFF as you expected in your comment

> separate programs invoked to do the I/O and do the mode switch, but in a
> real scenario, I'd expect the application itself to just open the device
> once, and then do I/O and mode switching as appropriate for the
> application logic, and I don't think uart_shutdown would then ever get
> called.

Switching between rs232 mode and rs485 mode on an open port is a special
use case in my experience. But it's valid and introduces some extra
complexity. As you stated, for this use case setting ->tx_state =3D OFF in
imx_uart_shutdown() does not really help.

> Indeed, that's an extra complication. Adding two hrtimer_try_to_cancel()
> in shutdown would probably not hurt, along with setting tx_state OFF.
>
> I wonder if at least mode switching should simply be disallowed (-EBUSY)
> if tx_state is anything but OFF.

Seems there are various issues in ->tx_state handling and transmitter
timing in this driver!

Best Regards
Eberhard