Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp980408rdf; Wed, 22 Nov 2023 02:12:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/VQMuWanUTmM99+urHiJdPAEWwD0Muq0qiD4QjBaMmEg44UblTQnCQog7X5B+XXyA6RBc X-Received: by 2002:a05:6a00:2883:b0:666:e1f4:5153 with SMTP id ch3-20020a056a00288300b00666e1f45153mr2276493pfb.0.1700647955932; Wed, 22 Nov 2023 02:12:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700647955; cv=none; d=google.com; s=arc-20160816; b=A4NDRwCj0dgapunGwZEeGtmdO6fU7/5LKMP52nGiK1kvO+KAWILQgKiw92QEyYqQoh 41cIf1wt/8p8KiBSSsmPNbGFzoWhMJ4A3xNB2qGYTFTjt34UprVjIBUGo5GGMT6j3DUp Bapxcsdqwu7TFy/W47zZt/ftclCMwtFZVRYPsQ7J/q7wLZN8NcBEfYYOzgla7KoshAru 4Uth30ScRSth7nZLZijICqdLJv6gmoTR92GviR0S9ddXBBdxb+4OiD7s+1CGI2A1puel dwCg5QdNIzxnrJjJiNjxu2ZLJAszIP39uBS1usHr9xm0ML0KE2nkRFNhKyXN1ApxnlTd 679A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=R7lvimWBnQgw4+7Zyq1orIeAHjF3AsXe/AqQs5bXYU0=; fh=eMJYr5J56ZIDVw8D4qM2LjGydHAdbENAfzHobBsRCJo=; b=fRut0nrlCtunxg0vu2tjxcB+DO+0nlpzhieOsqln2yWKmiGV+H4GwSbIQ3cYRdTDJI qDGbQkB+uKRGMLcxTLm7viekX9BNVREZeMUXXxUUkXszuk14vs2SARrV0hP2dQPVEGzY UidTj3MG77lBeqJtM1M9K4ur0Q+27BA+L21syYmr8yjAUYg09/L5qSWez841IAVvCym4 QC+4CKmxcEqeby4nnqEsnToCrGAJ5E/qy45tbk3qDln4N17++A5HV5A7XT6heTdwrbgW 4CdD5oAYLBmphvRystqlhI23qgHEUgJDC/M2Exu3FNWm6P6F8XvSse339Saa11vqoghJ mjtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mUZKtBcH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id j33-20020a635961000000b005b8f298110csi12312794pgm.6.2023.11.22.02.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 02:12:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mUZKtBcH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 97A1481B0CF1; Wed, 22 Nov 2023 02:12:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235117AbjKVKMO (ORCPT + 99 others); Wed, 22 Nov 2023 05:12:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235202AbjKVKMM (ORCPT ); Wed, 22 Nov 2023 05:12:12 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3778E112; Wed, 22 Nov 2023 02:12:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700647929; x=1732183929; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ekVyR2LTJTYq3ZM1BPKwRkdTVcMVyNkfXXO7GdIDxpQ=; b=mUZKtBcHFbuzBYKXkL7haGA/QKAXCprwNPULGH5lD2zgcDuCDM8UNf5V x5y/zSwJNeOAGXbV0cK6RuXcVUHA0y9JscECMZwviVxt43tKCOAfY5HTx qHsI/vAQqO8ZFoHLqdspP7u4+MMPfAZ/CWVJXDhLDF2qVaEjhjeKsA57p wTKuBdKa4Vv/7Q6BGLMozqgBVX6Vcp97F7f3+ULPU8S5iRa6P62w0c3vm 5DjGIW7bdgSTq6jUqLpFivrfmPVFaDFw/3a1kG4NVMD7/mNC2XuK7JJPa q4JGmJuAiG6efQg0cJOg2/uc8kHQROOtq2iBD3tBG9X5BMFneThfvceUk w==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="395945573" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="395945573" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 02:12:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="832958152" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="832958152" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 02:12:04 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r5kDB-0000000G3jf-2eSS; Wed, 22 Nov 2023 12:12:01 +0200 Date: Wed, 22 Nov 2023 12:12:01 +0200 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: Raag Jadav , mika.westerberg@linux.intel.com, lenb@kernel.org, robert.moore@intel.com, ardb@kernel.org, will@kernel.org, mark.rutland@arm.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v2 2/6] ACPI: bus: update acpi_dev_uid_match() to support multiple types Message-ID: References: <20231121103829.10027-1-raag.jadav@intel.com> <20231121103829.10027-3-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 22 Nov 2023 02:12:33 -0800 (PST) On Tue, Nov 21, 2023 at 08:25:20PM +0100, Rafael J. Wysocki wrote: > On Tue, Nov 21, 2023 at 11:38 AM Raag Jadav wrote: > > > > According to ACPI specification, a _UID object can evaluate to either > > a numeric value or a string. Update acpi_dev_uid_match() helper to > > support _UID matching for both integer and string types. > > > > Suggested-by: Andy Shevchenko > > Suggested-by: Mika Westerberg > > Suggested-by: Rafael J. Wysocki > > You need to be careful with using this. There are some things below > that go beyond what I have suggested. Same to me and actually I've asked several times to remove this tag of mine! -- With Best Regards, Andy Shevchenko