Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Suman Ghosh <sumang@marvell.com>
To:     Wei Fang <wei.fang@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
        "vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH net-next] net: enetc: add ethtool::get_channels
 support
Thread-Topic: [EXT] [PATCH net-next] net: enetc: add ethtool::get_channels
 support
Thread-Index: AQHaHS+BTRkH+cf5B0qioiFUKZKZDLCGKB9Q
Date:   Wed, 22 Nov 2023 10:49:40 +0000
Message-ID: <SJ0PR18MB5216A0B9582DAE0DF8B6F1E3DBBAA@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231122102540.3766699-1-wei.fang@nxp.com>
In-Reply-To: <20231122102540.3766699-1-wei.fang@nxp.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z6LWxjQqcO8JAFDGMZ/a3mxJniTdZt6WLhdyLKpOEMYwIBy0JjQXYZy2nFot?=
 =?us-ascii?Q?4A16YkAkyQoxBFJ0WiXKtIqM83rLYIZBzz4LkewBG7x2euZydSOfhhDUpo9m?=
 =?us-ascii?Q?tWajd6ZyoGcAlLC0XEgCepzQIzzh4vXowmbyg9nH73Lh6anlviEWhTHTjx0U?=
 =?us-ascii?Q?8IHvIPUYak5ufIwIkCz7L0P77pT4IkjrApuwv7eLabSWNsfXgvnZUtvvpA8D?=
 =?us-ascii?Q?dKcod2KkAtZPYcWwXBLurxmUluhSG1A/K2PAkZNB8Q8D34ZICRYH1NT/RJkk?=
 =?us-ascii?Q?aDpAKSHDz8H526rrU/DYEZc4K7KOJOl2rcsQgivdRWjqaA359Us31XXaVaaI?=
 =?us-ascii?Q?vBKNzXOPdWqudhdU47ovVYPEF+ciur/iuyuUFXdYG92iWbIxWitpjZLd74yN?=
 =?us-ascii?Q?7EKtA1xReIZVzbxgyvn71egZnv7gSoweV5R+vFA73t2y3t4AUrYohY9zV61z?=
 =?us-ascii?Q?J+81VkkCYCZ1a96ZdPGJy8jP1Ga0wssTWTZemvNNcX8FFSWK6L/tHfTTf7xN?=
 =?us-ascii?Q?hHjusyLrpurEFQoDHLffsuzPFtzaDu94zCcBJJzNb/5IsJ/tg2dzdzhvg2is?=
 =?us-ascii?Q?mehkp7EqLtA0xmLUkb+Yd3df+cnNMVIm2F0Yw+kjXa3r2Ddy20xpY2ejH69e?=
 =?us-ascii?Q?jzKOx51YMHQ2JsLpYqhJ/MljsZ94Zt/327M/DJXBFZ6TfoOd/tMQPI2oeieN?=
 =?us-ascii?Q?DpcSLfWNmW3FUhXXXQMOtFSx/lt7055QWf/cg/yZxl8U3tmbip7Ewugj7r/d?=
 =?us-ascii?Q?tuYC7e5hIIGewRE0uNDPMEHa4n8eIdYMTZN1m32OonMx6gwB6D38HObcua9k?=
 =?us-ascii?Q?mo0GnmZ0/1baW/Es0+ptqhB0MNXDvkJmR8CinTDIlPUDW+/fYdaEGzmxa4Us?=
 =?us-ascii?Q?sjVss2cu4Jmv7JSqXtnf1lQBv1bA2S4CmU+cM8dftiFKn6YjUaZ20crWxu5l?=
 =?us-ascii?Q?0CW/860Rx+Sgj3P8/IqiqpYDIxBwwAEyjM/aEoUcdHtj4hu9zuyQ3MU3Q4xe?=
 =?us-ascii?Q?nj11eZM++jWfjXF6yR6N+gWTnfranTLGGfJCeZwLwewEzBR68wxrtcJ8yAin?=
 =?us-ascii?Q?y2wtU+OFGa9ikBXrml3f3PHqhBppff3PpmTkfqGhdPLwiiNSpmm2FWS9VkuV?=
 =?us-ascii?Q?G+zvbDEj35FBNlKskhEbo548CiVfDN/qbdPj6szRRNJvn9Os4kHzw1bu4sdT?=
 =?us-ascii?Q?dmZm9vQoWnUNfK0+Ewq6asrjEAZbWBcanbWvOWpBhrvdwZcjAjxjx9onRC1G?=
 =?us-ascii?Q?bgeLF71SEVOOw/G6gIpgpN9jOoeEAEIm9F7zTkUPGhQdb3SA8a8A1rWDumDB?=
 =?us-ascii?Q?kLHlaDJLzZPzEa4A2vbXqhUzt6770KxoOrUu+j+uqzKSruPQ8i9W4ojwlRqI?=
 =?us-ascii?Q?EBSOJd5GXthDAQNpNxRwqeiBQVVao2wY5seNDY5VBzPbQHTU7W9PO28JIpl7?=
 =?us-ascii?Q?X2Gd+adrF54D5aqHRnUnsEaIKpFwyxsRk/R9x8flWi9qMFn0jnWub958KaSc?=
 =?us-ascii?Q?L9OvEZDOvYZcGoKCeylKecZPfNmemSG1NXaBMLSV0SBbZqDIYh4MqcZU+sdF?=
 =?us-ascii?Q?cIQpf1aXBm6nZwOJGRqAfQQ0Y5dV/1HPHUIKJ26j?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cac2ef8-8a5d-44e1-5fb8-08dbeb48badc
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2023 10:49:40.7678
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PnxuGSWvjz4W/0ZPrJi8mAgCf9fXsBn2vAPIP/QblK2XlOapmKMVtegSzL5QmyrMuOLrP3k1Dkh+zEnRUx9t5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3513
X-Proofpoint-GUID: KVRwWeVF6nkQdMebt-5z8c4uZO1HiiBm
X-Proofpoint-ORIG-GUID: KVRwWeVF6nkQdMebt-5z8c4uZO1HiiBm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-22_06,2023-11-22_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 02:50:24 -0800 (PST)

>Subject: [EXT] [PATCH net-next] net: enetc: add ethtool::get_channels
>support
>
>External Email
>
>----------------------------------------------------------------------
>Since ETHTOOL_MSG_RSS_GET netlink message [1] has been applied to
>ethtool tree, there is a netlink error when using "ethtool -x eno0"
>command to get RSS information from fsl-enetc driver, and the user
>cannot get the information, the error logs are as follows:
>
>root@ls1028ardb:~# ./ethtool -x eno0
>netlink error: Operation not supported
>
>The rationale is that ethtool will issue a ETHTOOL_MSG_CHANNELS_GET
>netlink message to get the number of Rx ring. However, the fsl-enetc
>driver doesn't support ethtool::get_channels, so it directly returns -
>EOPNOTSUPP error.
>
>[1]: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
>3A__git.kernel.org_pub_scm_linux_kernel_git_jkirsher_ethtool.git_commit_
>-3Fid-
>3Dffab99c1f3820e21d65686e030dcf2c4fd0a8bd0&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPa=
z7
>xtfQ&r=3D7si3Xn9Ly-Se1a655kvEPIYU0nQ9HPeN280sEUv5ROU&m=3D-
>6bW3FaCKau7jio6XSUWDZw3IEqdetIwhU_Bgcv87QcnjyMDGD0slJGQYFlbVx7l&s=3D8vMevY
>UEvNkyCjMDO278j67ir4daMquk6QK9wR65NSQ&e=3D
>
>Signed-off-by: Wei Fang <wei.fang@nxp.com>
>---
> .../net/ethernet/freescale/enetc/enetc_ethtool.c    | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
>b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
>index e993ed04ab57..5fa1000b9b83 100644
>--- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
>+++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
>@@ -740,6 +740,17 @@ static int enetc_set_rxfh(struct net_device *ndev,
>const u32 *indir,
> 	return err;
> }
>
>+static void enetc_get_channels(struct net_device *ndev,
>+			       struct ethtool_channels *ch)
>+{
>+	struct enetc_ndev_priv *priv =3D netdev_priv(ndev);
>+
>+	ch->max_rx =3D priv->num_rx_rings;
>+	ch->max_tx =3D priv->num_tx_rings;
>+	ch->rx_count =3D priv->num_rx_rings;
>+	ch->tx_count =3D priv->num_tx_rings;
[Suman] max_rx/tx and rx/tx_count can be different right? To me it seems li=
ke max_rx/tx should read the max value not the current configured values.
>+}
>+
> static void enetc_get_ringparam(struct net_device *ndev,
> 				struct ethtool_ringparam *ring,
> 				struct kernel_ethtool_ringparam *kernel_ring, @@ -
>1196,6 +1207,7 @@ static const struct ethtool_ops enetc_pf_ethtool_ops =3D
>{
> 	.get_rxfh_indir_size =3D enetc_get_rxfh_indir_size,
> 	.get_rxfh =3D enetc_get_rxfh,
> 	.set_rxfh =3D enetc_set_rxfh,
>+	.get_channels =3D enetc_get_channels,
> 	.get_ringparam =3D enetc_get_ringparam,
> 	.get_coalesce =3D enetc_get_coalesce,
> 	.set_coalesce =3D enetc_set_coalesce,
>@@ -1226,6 +1238,7 @@ static const struct ethtool_ops
>enetc_vf_ethtool_ops =3D {
> 	.get_rxfh_indir_size =3D enetc_get_rxfh_indir_size,
> 	.get_rxfh =3D enetc_get_rxfh,
> 	.set_rxfh =3D enetc_set_rxfh,
>+	.get_channels =3D enetc_get_channels,
> 	.get_ringparam =3D enetc_get_ringparam,
> 	.get_coalesce =3D enetc_get_coalesce,
> 	.set_coalesce =3D enetc_set_coalesce,
>--
>2.25.1
>