Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Wed, 22 Nov 2023 11:44:34 +0000
From:   Lee Jones <lee@kernel.org>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Pavel Machek <pavel@ucw.cz>,
        Jean-Jacques Hiblot <jjhiblot@traphandler.com>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        Johannes =?iso-8859-1?Q?Pen=DFel?= <johannes.penssel@gmail.com>,
        Jeremy Soller <jeremy@system76.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [PATCH] Revert "leds: class: Store the color index in struct
 led_classdev"
Message-ID: <20231122114434.GI173820@google.com>
References: <20231121142629.27083-1-tiwai@suse.de>
 <170057941222.880794.5199112193553712244.b4-ty@kernel.org>
 <87v89v9j9t.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87v89v9j9t.wl-tiwai@suse.de>
Precedence: bulk

On Tue, 21 Nov 2023, Takashi Iwai wrote:

> On Tue, 21 Nov 2023 16:10:12 +0100,
> Lee Jones wrote:
> > 
> > On Tue, 21 Nov 2023 15:26:29 +0100, Takashi Iwai wrote:
> > > This reverts commit c7d80059b086c4986cd994a1973ec7a5d75f8eea.
> > > 
> > > The commit caused regressions to a few drivers (such as Logitech
> > > keyboard or System76 ACPI) that already had "color" leds sysfs entry;
> > > now they conflict with the commonly created sysfs of led class.
> > > 
> > > For addressing the regression, we revert the commit, so that the
> > > conflicting "color" sysfs entry is removed.
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [1/1] Revert "leds: class: Store the color index in struct led_classdev"
> >       commit: 17e1ad377bb1d39260e0594ee284d8e03f64fdfb
> 
> It turned out that drivers/leds/rgb/leds-group-multicolor.c
> initializes the cdev->color, and this revert breaks it.

Indeed:

linux/leds-fixes/drivers/leds/rgb/leds-group-multicolor.c: In function ‘leds_gmc_probe’:
linux/leds-fixes/drivers/leds/rgb/leds-group-multicolor.c:109:49: error: ‘struct led_classdev’ has no member named ‘color’
linux/leds-fixes/drivers/leds/rgb/leds-group-multicolor.c:120:13: error: ‘struct led_classdev’ has no member named ‘color’

> So please scratch my previous revert patch.
> I'm going to submit a partial revert instead.

Sure.

-- 
Lee Jones [李琼斯]