Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp1024898rdf; Wed, 22 Nov 2023 03:47:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IEFkIxHT9c5eQLkLI1BegTAnEa17LWKnkGVlOYNrZp+1HxIos1O179+a9x3hIdbCKWEMsL/ X-Received: by 2002:a05:6870:3e08:b0:1f5:b60d:68ff with SMTP id lk8-20020a0568703e0800b001f5b60d68ffmr2696553oab.14.1700653674220; Wed, 22 Nov 2023 03:47:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700653674; cv=none; d=google.com; s=arc-20160816; b=kuZEi+M72uxA5f4/ihnyXC1FiNVPk9GfUeYN1hgjEvnMgc0S0/CCXVlDLEsD2eOewW sKxl4sotfmnKfSkFwNIO65tm3Ca9WH4GhnZkcD0qe14eeEaL1xoBd3puspAzsnU5Z32E 6wGUErB0HMm1ZR2hz1yqd4N/OzrMyzhQtEPBjc2ZX+1yh4RI8Xgq0TCr1O87MzlncsCz 2tQ47s7ix65uiuYmPu3Zaunv3Vjmh0MU87e0Nq4LnOsAOgIQKv3+HULBOLN1PiEk0FB7 hZwL7+Lj47h7FsTzBgC1MX6zL9Kl1VkTpzPjByRG1MxH0ATuZPZKVg0iwL6zg3fOiwio 0Oxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=mXzunCsPQGZk6f3PvZWrRmvZPBvLZyBv60oNxaeXvvU=; fh=1usrCD8Zcv9hYI6E6jsmKG3qH0EyRfhVKVOHyAl6P2E=; b=Zsqyteod9G0QQvFl6chIMIyYueYr4sYJ9tuwOL6Djvsz5zu4R0ZbtsYOJ4sIRwi+gI 9rGbYVLNTUkRFEIe4uCmnVZd6FHRuhzfuaxO6XXL7vLQNz12R49HPcXf7lbLcnezCT34 RkTCe3OLwImz8jn2s5xhlnMYveoDTjbmyvc69DfIaUje3Dmwq8Yu3SnvLrmEZ2BJu3qB X2eXwZp7m4f+KnZNTkSJSeAKdsdKdQqAoX4ZvGF4RDBJMUIOuu5HAoMW/Yma0f65xAHS Ri/+dBeR3UxN3W6K/oVss0plYcWnxZTJ7X4MvZwiOJOzmEqPFOj9keW2x3226UKpHJVx 3qwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gMVxldUC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id q17-20020aa79831000000b006c4d5ca7fe7si12150873pfl.366.2023.11.22.03.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 03:47:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gMVxldUC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 1BA8D81C0C82; Wed, 22 Nov 2023 03:46:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343819AbjKVLqj (ORCPT + 99 others); Wed, 22 Nov 2023 06:46:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235200AbjKVLq3 (ORCPT ); Wed, 22 Nov 2023 06:46:29 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 988CAD7D for ; Wed, 22 Nov 2023 03:46:21 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46F7AC433C9; Wed, 22 Nov 2023 11:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700653581; bh=MyPYVBOb1JZQan55pmhKATWt/odIw2ODqt68yMlFupI=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=gMVxldUCSgXvsC5dn5yR/ULac2q4fOQ8SvLARrFz6fHI1Dt/iYdQXksQur2247kS4 qDkyVU2+CCxCurHbVypQJh7EVysKJE8HCUiYYsqrdoZnCVhRU8bjruM6tGmqxrzY+l cAZVTroBV9wiJ/Cx+L5HOrbKnGt17hjtikKaUZ8PJkLvkac8cyrmv983PVMMxioCHl 7M9iEzE8741fjaunh1USZthHf4uR85dUpW71knb2bhJXkriNHBVw0RxCzdwDj12ByI LfFXO4bIP1NPJHZblu4Brx/MW0t4uGym21fO1qtnZFhtMyO4P8arTIXxTJXt5od0ah MX5spd2BcrQuQ== From: Lee Jones To: Takashi Iwai Cc: Pavel Machek , Jean-Jacques Hiblot , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?q?Johannes_Pen=C3=9Fel?= , Jeremy Soller , Hans de Goede , Bagas Sanjaya In-Reply-To: <20231121162359.9332-1-tiwai@suse.de> References: <20231121162359.9332-1-tiwai@suse.de> Subject: Re: [PATCH] leds: class: Don't expose color sysfs entry Message-Id: <170065357900.994845.3674008624629651267.b4-ty@kernel.org> Date: Wed, 22 Nov 2023 11:46:19 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 22 Nov 2023 03:46:57 -0800 (PST) On Tue, 21 Nov 2023 17:23:59 +0100, Takashi Iwai wrote: > The commit c7d80059b086 ("leds: class: Store the color index in struct > led_classdev") introduced a new sysfs entry "color" that is commonly > created for the led classdev. Unfortunately, this conflicts with the > "color" sysfs entry of already existing drivers such as Logitech HID > or System76 ACPI drivers. The driver probe fails due to the conflict, > hence it leads to a severe regression with the missing keyboard, for > example. > > [...] Applied, thanks! [1/1] leds: class: Don't expose color sysfs entry commit: 8f2244c9af245ff72185c0473827125ee6b2d1a5 -- Lee Jones [李琼斯]