Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp1031581rdf; Wed, 22 Nov 2023 04:01:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEtSEMm+fGK4HZx2taelq9QHKbt7khYPBnq9EiX2o5QKpqLCM132gvYKnXP1pitlGPFZyLM X-Received: by 2002:a05:6a20:734a:b0:187:eea9:73c5 with SMTP id v10-20020a056a20734a00b00187eea973c5mr2210785pzc.3.1700654491913; Wed, 22 Nov 2023 04:01:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700654491; cv=none; d=google.com; s=arc-20160816; b=jygbV8hQB4sAgo7UN1wQ3nJyzpBuNDDwsDWkdeh6W/4tXO2pYkzg/eqjswaiLWkoKY jVQl+ZOjhiGsMfmcFXba84nbchBwqHv65nRYBWlqSzlC3sqSjBxz/kIj6EQQccTbBlBq PIB0P443xHPIXo2Gj6CDwN8JNWEW4XmSZ9RFFAtAaLkU+07tlcXt14FSMfbVKkSHOxb2 +v7KZbk56AKabGjNcrfCUAwZNud6nzSEEwSFnBKlKt09bBzWMGNea0mItfs3ec78XBCf ylZ8khXkoBFihZLgXM9pc9DdsYq2X9bylP/mge59ZIGhqAXwDHqbQ685/K6DomgitOj+ UzgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=QT8MyelSxHYRQiToCy09U/tLdWe22C7FstDGwRxECu4=; fh=hblRsZMDaFsrPndJljnh/iQH2rCC93j0x2HV6Ec59Co=; b=Hd3fFtvYDzFqsJ4Xp9JjgUikTrWP4QryH0xMkrdm+Brx6YLoVVLU5L4BUhUIUAC2ME elH4bu/IlrBg4uoIV6Kqyhstnre3mEaYYFfSWcPQL2V18d0+ELCqrQzO8zy+HErwJXbQ FAQQi8NBQL5ezyDGap/QDTM/CTuV9ynev2erE6J6b2uEFaCCCMKQoRVfkjgOm2Trcg4+ IvWpKt3+2nj7lazjWhLaS+6R2gma3Rk8nrLi64CskzWYEboN85blecWYkhpXQBaP1Gqc tC0s7KsxMzwMeTQ7QMb0J050/d3w1czcvemgZ7ZVyl4ddQOyxQgtguXL6VclJ2X8N16q IZsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="vM/GKcgf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id l5-20020a632505000000b005b8dd557b38si12694415pgl.14.2023.11.22.04.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 04:01:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="vM/GKcgf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id B1D9080EE763; Wed, 22 Nov 2023 04:01:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343917AbjKVMBA (ORCPT + 99 others); Wed, 22 Nov 2023 07:01:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343876AbjKVMA6 (ORCPT ); Wed, 22 Nov 2023 07:00:58 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50DEE19E for ; Wed, 22 Nov 2023 04:00:54 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2c876f1e44dso48891941fa.0 for ; Wed, 22 Nov 2023 04:00:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700654452; x=1701259252; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QT8MyelSxHYRQiToCy09U/tLdWe22C7FstDGwRxECu4=; b=vM/GKcgf3nI4usNcu66qef1XkFU45mV8UUNVOSgnhaxwATwVAZofzTX9GPiYqVwNyI arjngPb/vo0uJQTJogcrZug6ZluAP3dEOzl4d8r4F96E80EzfwbXRt06+J368guicsZg NjZgn/7mJNVnMZHiCnCqxEJSTPfSPmWGOpfw9tHwsl0QNIaHPPDJoH/S9Mmxv4tZ64JR HXHMJy0QCyWStwXXJzlyO1PHmYcIY5EmFBqGcbbzLgHxzarR8bAcdyt9frWzUCO1F/am nmW3NxR2KoAXJp3uIbSwKzpVK0gannOzf+OaSAOCzTc75ZaVEbvkZLkA1cZldQIEVeHZ VAXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700654452; x=1701259252; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QT8MyelSxHYRQiToCy09U/tLdWe22C7FstDGwRxECu4=; b=HkGjv4j6kFQaVIT4JNQ96bZ3LFAh4xeLMifnnPSud+ImAeCjSZb0T0AzBzL0CKYRPw r/ZxgLLsdVM4kWXw5FYJySMS/KfTKyU30/NF8nOo19X8tK+hU+WG4okl8gJVq4mspNWi Ft1//5vvU0yKd63jcjLjap6hWEPGzZ3gWIHHlg/NNK5kUV7CAhv1bIK5HXr2kNGRYU31 gsvXwMLGADzU6xyTgbY5845/FDa+Loh7Mj82yovhQycGROL44arYGhaoZv/YLNP9QHzQ EEAVNSboXWssNzF61bM/MgMq3bxvEJ9Wxh0+78ZNWHOskJWHdterrfXn5nm4R3J968/f JljA== X-Gm-Message-State: AOJu0YwbLCQiagiBGjk9Rgg9j8SRbTrb0L5+6mbpq0Gd7Hh/ydzpUEd2 DNVkM5NMvxI71otjl88+VWGo5w== X-Received: by 2002:a05:651c:1424:b0:2c2:8f22:d9c2 with SMTP id u36-20020a05651c142400b002c28f22d9c2mr1605866lje.22.1700654452500; Wed, 22 Nov 2023 04:00:52 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.100]) by smtp.gmail.com with ESMTPSA id s5-20020adfdb05000000b0032d8eecf901sm17204549wri.3.2023.11.22.04.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 04:00:51 -0800 (PST) Message-ID: Date: Wed, 22 Nov 2023 13:00:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] dt-bindings: usb: ti,j721e-usb: add ti,j7200-usb compatible Content-Language: en-US To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Roger Quadros , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Gr=C3=A9gory_Clement?= , Conor Dooley References: <20231120-j7200-usb-suspend-v2-0-038c7e4a3df4@bootlin.com> <20231120-j7200-usb-suspend-v2-1-038c7e4a3df4@bootlin.com> <6f0da181-717c-4b14-ba3f-d287efe4105b@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 22 Nov 2023 04:01:28 -0800 (PST) On 22/11/2023 11:46, Théo Lebrun wrote: >> >> How ti,j721e-usb can be and cannot be compatible with am64 in the same time? > > The code tells us that there is no difference between ti,j721e-usb & > ti,am64-usb. And the commit adding the of_device_id entry agrees, see > 4f30b9d2315f (usb: cdns3: Add support for TI's AM64 SoC, 2021-01-19). > Here is the entire patch because it is so small: > > diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c > index 90e246601537..eccb1c766bba 100644 > --- a/drivers/usb/cdns3/cdns3-ti.c > +++ b/drivers/usb/cdns3/cdns3-ti.c > @@ -214,6 +214,7 @@ static int cdns_ti_remove(struct platform_device *pdev) > > static const struct of_device_id cdns_ti_of_match[] = { > { .compatible = "ti,j721e-usb", }, > + { .compatible = "ti,am64-usb", }, > {}, > }; > MODULE_DEVICE_TABLE(of, cdns_ti_of_match); > >>> I've followed the same scheme & added both of those: >>> >>> compatible = "ti,j7200-usb"; >>> compatible = "ti,j7200-usb", "ti,j721e-usb"; >>> >>> I messed up the ordering in the added 'items' options, but the logic >>> seems right to me. And dtbs_check agrees. Am I missing something? >> >> Logic is wrong. Device either is or is not compatible with something. At >> least usually. We have some exceptions like SMMU for Adreno. Is this the >> case? Why the device is and is not compatible with some other variant? > > My understanding is this: j721e & am64 are strictly equivalent. On our Then this should be expressed in the bindings. Currently and in your patch, you express that they are not compatible. ... > > - properties: > compatible: > oneOf: > - const: ti,j7200-usb > - items: > - const: ti,j721e-usb > - const: ti,am64-usb > > J721E & AM64 are compatible, express that & update devicetrees. > > Option one is simpler & doesn't change devicetrees so I'd lean in that > direction. What's your opinion? This one should be for am64. For your j7200, it depends whether the fallback to j721e makes sense, IOW, if the Linux can use j721e compatible solely to use j7200 device. Best regards, Krzysztof