Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Wed, 22 Nov 2023 09:20:37 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Oliver Upton <oliver.upton@linux.dev>,
        Marc Zyngier <maz@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf MANIFEST: Add gen-sysreg for ARM SPE
Message-ID: <ZV3yFe7+wUNWwkVc@kernel.org>
References: <20231122022805.511839-1-irogers@google.com>
 <ZV3xe1qVCiz5bkLP@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZV3xe1qVCiz5bkLP@kernel.org>
Precedence: bulk

Em Wed, Nov 22, 2023 at 09:18:03AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Nov 21, 2023 at 06:28:05PM -0800, Ian Rogers escreveu:
> > The necessary files for generating sysreg-defs.h need adding to the
> > perf tool MANIFEST that lists the files for packaging the perf tool
> > source code. Fix for the following:
> > 
> > ```
> > $ make perf-tar-src-pkg
> > $ tar xvf perf-6.7.0-rc2.tar
> > $ cd perf-6.7.0-rc2
> > $ make -C tools/perf

And I detected this while doing these tests on
perf-tools/tmp.perf-tools:

[acme@toolbox perf-tools]$ git log --oneline -1 ; time make -C tools/perf build-test
4dbc034e08146c48 (HEAD -> perf-tools) tools/perf: Update tools's copy of mips syscall table
make: Entering directory '/home/acme/git/perf-tools/tools/perf'
egrep: warning: egrep is obsolescent; using grep -E
- tarpkg: ./tests/perf-targz-src-pkg .
make[1]: *** [tests/make:348: tarpkg] Error 2
make: *** [Makefile:103: build-test] Error 2
make: Leaving directory '/home/acme/git/perf-tools/tools/perf'

real	0m7.498s
user	0m12.059s
sys	0m5.491s
⬢[acme@toolbox perf-tools]$

> > Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path")
> 
> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Namhyung, I'm testing this together with your headers sync series + what
> is in perf-tools/tmp.perf-tools, will report results soon.
> 
> - Arnaldo
> 
> > ---
> > Note: the breakage is in Linus' tree and perf-tools, not yet in perf-tools-next.
> > 
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/MANIFEST | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
> > index 1da7f4b91b4f..dc42de1785ce 100644
> > --- a/tools/perf/MANIFEST
> > +++ b/tools/perf/MANIFEST
> > @@ -1,3 +1,5 @@
> > +arch/arm64/tools/gen-sysreg.awk
> > +arch/arm64/tools/sysreg
> >  tools/perf
> >  tools/arch
> >  tools/scripts
> > -- 
> > 2.43.0.rc1.413.gea7ed67945-goog
> > 
> 
> -- 
> 
> - Arnaldo

-- 

- Arnaldo