Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp1074191rdf; Wed, 22 Nov 2023 05:08:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHv0xVYHl9XVylRg93WfEtb1oHloP7ZH5s9BmhwMiRBNw2iLmjUv6QCEwYO8DSKpBf4I9s8 X-Received: by 2002:a05:6870:3927:b0:1ef:b16f:d29d with SMTP id b39-20020a056870392700b001efb16fd29dmr2624919oap.18.1700658509918; Wed, 22 Nov 2023 05:08:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700658509; cv=none; d=google.com; s=arc-20160816; b=Zu2U04mIt1DeZa9LHtQByJpjHXnDZR92qwIz01tnrRCHZhvn4gymjYjPVllveA3pcK yRHwml1JNMG7DJRte/Y6ZcGiu3GnBcg1cWHkxjJq45zLSSB33p9+StJuHqn8/Q/ws9b+ 8J/GLs2NBgFxlWt/F7iJBmTlOdqmMnkFvu/5MxCpMZt+YOquXtwcLXkBzBuhScx/uR5s 641HjuhyGgGXtQkRcr/1d47+Zaha6I1q9kMZQtjFfXLAnLIWAbzTgnI8I0TFh8Iulc/L UsQALbfdXP99NKC0xLdWUTiX4cRXvXrt5LV/SHlLuxYP4R/vPanUwPGCFN3Fjt2pJ2Qw G/PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=aFvIffjeh7UJPy7HOhTCrJstZpn+ngVTAePPWXClIk8=; fh=qGOFz6qPTaU461HwaWlbkSIWoHXRffUy1bFm9qdw+0w=; b=jtRY6QwbgxiUHv6P+1WVULtm27MJg/VdpXqDX/Ar143DTSarj094ZYUDWvMwxjoTvK cx7XdMsZxvPeZ1R2DYPgoNvGFNwcxb60KBEQxzKyQo7QJtk/19xCy/kFpXTAJQi8T+4+ eWrzFBtlqJFhk9zmk5CeMhsJ1bYRLYxLKOOdzOFvVcFGgKTBLeSKJlTGCeavbBs+1wzT IPO48iGpkg2zKzVw2cv7W4cywWq9fP5gNzkRzGuBgEpnwZKgwsaDMVIzTUtKIJ8DE1ON IZTizezzcfapMOfwQissNxFIp/E1ZC+Db3Uvahk7naDevKVJJ4Ix+RsO/zKc6hlNDafg 6O2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=b22uI0fU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id wh18-20020a056871a69200b001f962090a5csi1469141oab.65.2023.11.22.05.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 05:08:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=b22uI0fU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 9F85081BC48A; Wed, 22 Nov 2023 05:08:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343815AbjKVNIP (ORCPT + 99 others); Wed, 22 Nov 2023 08:08:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343619AbjKVNIO (ORCPT ); Wed, 22 Nov 2023 08:08:14 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1316D8 for ; Wed, 22 Nov 2023 05:08:10 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 740B4240006; Wed, 22 Nov 2023 13:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1700658489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aFvIffjeh7UJPy7HOhTCrJstZpn+ngVTAePPWXClIk8=; b=b22uI0fU6uVROmNHIJUVxCRkvwkKJ8Nwog9Pd9sSD6nGP3631K6YDNIpgosh03ReDOswsm ptKkyqsPt/9HaJZnxxB8ZyN1LiWs86OCrhWaXWkmeFBlaizKDLsIsyVNhW9mJSapFRSFAb b68clEpLdXqxBA6vRcUj8FpE8RwWhvZQ7I3aVOlFe2Bnc47aIy9FMQWynO7HjYBZCIGdUD ezUf0lrgiLbiCGd6rFG/bVzhfXQxF2XGqtU90CDa2Neke2yIU0ABtPF8S18qj+3f6BYTbQ r4fBqNLBnPeKbD7+HRDADqjNfqlKkfgBSl/v2JEiVkzzIqW0q986lTGzCoI58A== Date: Wed, 22 Nov 2023 14:08:03 +0100 From: Miquel Raynal To: Andy Shevchenko Cc: Nikita Shubin , Richard Weinberger , Vignesh Raghavendra , Arnd Bergmann , Linus Walleij , Neil Armstrong , Daniel Golle , Jean Delvare , Christophe Kerello , Chris Packham , Johan Jonker , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Sverdlin Subject: Re: [PATCH v5 19/39] mtd: rawnand: add support for ts72xx Message-ID: <20231122140803.239a3c17@xps-13> In-Reply-To: References: <20231122-ep93xx-v5-0-d59a76d5df29@maquefel.me> <20231122-ep93xx-v5-19-d59a76d5df29@maquefel.me> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 22 Nov 2023 05:08:27 -0800 (PST) Hi Andy, > > + int ret; > > + > > + ret =3D mtd_device_unregister(nand_to_mtd(chip)); > > + WARN_ON(ret); =20 >=20 > Is this a requirement by MTD to have return value being checked? Yes, for now this is the preferred way, with the hope some day to turn the return value into void. Thanks, Miqu=C3=A8l