Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <8c9133ba-31d0-4582-918d-1e1b5dee5eb1@prevas.dk>
Date:   Wed, 22 Nov 2023 14:34:42 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] serial: imx: also enable Transmit Complete interrupt in
 rs232 mode
Content-Language: en-US, da
To:     Frieder Schrempf <frieder.schrempf@kontron.de>,
        Eberhard Stoll <eberhard.stoll@gmx.de>, sherry.sun@nxp.com
Cc:     festevam@gmail.com, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, kernel@pengutronix.de,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        s.hauer@pengutronix.de, shawnguo@kernel.org,
        eberhard.stoll@kontron.de
References: <AS8PR04MB8404D066C247F5B2979CBD1F92BBA@AS8PR04MB8404.eurprd04.prod.outlook.com>
 <dbe5959d-2b68-4f16-89ee-32538aab4f34@gmx.de>
 <5ad44085-c90b-4a88-bb7b-8ddc2b612793@prevas.dk>
 <fc843c33-03e4-4603-9cc9-0b30b2c21c66@kontron.de>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <fc843c33-03e4-4603-9cc9-0b30b2c21c66@kontron.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWxydDl4VE9rOFdIb1d1MXBRNzVseTZxcDJVSUpzS2FMUXp6VlpRTGRZTzBZ?=
 =?utf-8?B?NzE1OUJNaGFnTGVXby9lQlBLV2s0cXdWNnhiVjBycW1TWDI0R0VhT2drOWx6?=
 =?utf-8?B?TkQyWFJUejU3b216cUVabWNQZTI3bm9sVTBzcERQT1Rqb0MzYkxUTVQxSnpk?=
 =?utf-8?B?N1VyNDk1R1V1V0JBZFUvSXJROFdjZU5XM0NOYjNkYUxrZFNGZGtYVm5EVDdK?=
 =?utf-8?B?VTZzbGFQM1JWenlPOGZWSlIzMzQwdnQ4M3UyN3ZwRm53QkJhcVdWQjVMbUdi?=
 =?utf-8?B?UzU2SG9tUXEwUWxXQU51ejhydzhMODA5cDZsTkREVWNMWGRJTFJEV3hyd1N1?=
 =?utf-8?B?TlZBTXBhT3FZUi9Rai9OdWJzN3lKMmRET1F5czFPbTZDZGo1c3hjUTBCTm94?=
 =?utf-8?B?MmRBWVdYYWY2YjBjSEtwV3A3RTJtUEdibUR1Q051ZG4zVmhoT2ludjhuVWZD?=
 =?utf-8?B?anVIdi80Sk5DM29qaTJEMm5kUzdZT1VqeWF4NGtLdDFyY0dwcmNhc0xLMkJY?=
 =?utf-8?B?OS9OWXB4WEV1TnZSZzkwT2tHU3E0Rkh3Q2FqN0ZKcGh2a2J3ZjdBbzJ2STFi?=
 =?utf-8?B?bm5qVWdYZ0lzOUN5R2tTY1ozQVNtMWx3d3VpQ05lcVhJb2pEeGRwWUhLWnVx?=
 =?utf-8?B?R2l2WmNZYUJudGNSb0lsa20yZVNneGwrWW16OE52RWNoMk9IYmFsZTErMEpr?=
 =?utf-8?B?TEVoODFpMWExR1Z4ZWRjdGNycWoxUVNTQmN6bEVzQVJYa1JTNlBIZEdEcGJ3?=
 =?utf-8?B?OEJ4VUZBdk1kVkZQaDZEZHBCV05HZ08wYnlQYkNHYzNKV0VSZThlZjJoQnpE?=
 =?utf-8?B?MWVpenZRMDVIOUZ0WDZoblVlTWF6QzZST3FyRXRDT0xMN2pMZUwzWndnVDcx?=
 =?utf-8?B?bHk5NmpkYUVxNUg4d2ZXckV4K04rRjRvM0xjbkxZNXlCYVVVT1NlT1Zibkg3?=
 =?utf-8?B?aGlCWG5EcEkvV0RLRFpFclhMUTgydnVyeVFVclZmSUttcDRkRjUrek9mbFJ6?=
 =?utf-8?B?dG5MSjVYZlZHdnVLanR4MHFoa3pPQzBMMmY0Sk5EVnE0S0Nsa2gyL2tCTDNP?=
 =?utf-8?B?QmFTUVdPb2c3MzJBamV1MDVBQzNPalRUUitDNEpXNm1aZXhzSWxXOFdWOWdT?=
 =?utf-8?B?Y3FXdm1SK3JOMG8vdWlRS3RCam5NaGFNMzhMNWV5NklscXk3dUxWNzNrb2pj?=
 =?utf-8?B?UTBOdHhvb0g3NFA0bThwWndpcHlSQ3MwbC9kYTU3WCtKS2VINXhDOHpRRXlS?=
 =?utf-8?B?czM5bDBuckE2L2dXS1REM0xHWmV6eXRjZE1SRHJRSHVaTFg3RW5UUnp5R204?=
 =?utf-8?B?ekFRTW5ZZVZXWDIwaGRjZ2hycTlOM0ZCcWZSNVpVNVBmNC9wbGIvY04xTzRu?=
 =?utf-8?B?azZ5bXM4U3RwaGNSckJMN3JRTTNtd3kwTXc1VDVsVG1yQzE4TnpISDlSYzI4?=
 =?utf-8?B?K2FOU0hwY3BVNXp3Tk1XVEZHVER4WnBwNmhqVVpOYmhMODVPbklxNUhPcnp5?=
 =?utf-8?B?NGJib25qcmYrN25nM2gzZklGdzZIS2VMZERUQTQ2aUVLKzFrenVzZzF6NHAr?=
 =?utf-8?B?M2VTRXVEL2FSUW9GVk5CNktsR3BidkJiZnhwTFg1OUFSZUZ0eFBoRnRMV2V4?=
 =?utf-8?B?bm1DRERGOEp3TmtYQ3daS3p5akUvTTBhZDFyZTZ2Smd4V1RCRk1FM3BGSEVD?=
 =?utf-8?B?Wm9rRGpHZDVZajVFZ2JubEw2aEM5MG1KK01JWUlhVG5FRTRLK2lpSndaUUpP?=
 =?utf-8?B?cUlHdHFWR05hdzFyOVJsRlkxZ3NPOTFVYXk3dS84Nnh4YkVWQ1Nxck5ZYVVa?=
 =?utf-8?B?Y0diOGw1WEZ0V1RHVWNBOXpMR0ZQY2M5R05HaTd1Wk9LUG1EbHlKdml2eWZK?=
 =?utf-8?B?Q0dLSmJZOUMrZHlsTVp0d1lQZmdlME9HUkFkdTZoZHlFT2FicnpxWmFJSjQr?=
 =?utf-8?B?RkpKejlBWDhWR3graGdYT1RkTi9wWE1ralFCd0M3cVJjRC80SlEzT1FSS3ZS?=
 =?utf-8?B?NlNtTmZNcDVyTG4vV09YTFlJcUJUaTRxOCtYaWhJenJMR0RIbHoyQTh1WkdI?=
 =?utf-8?B?b3ZsOWNuangrckNDQ0E3czRxVnlSbWVwVU1tZFdtdWpiSUVMNmtQcGFyNThF?=
 =?utf-8?B?RDh6YVhFbFdMdWFCT04yWGtvbVJ4T3ByNXFDUFUvOVhvOW1MeEFFejdKQUE2?=
 =?utf-8?B?ckE9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: 02829625-5dbf-4de3-8aee-08dbeb5fcb2d
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 13:34:46.8047
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kcJBDM+XOPyuddFH2lZRYnPiczGQkEvNySOkEXkgPBCkB+BhlAzu6SoLMzOfvpbS168WTx4orsSiaFeRZLsbDfmlam4txDY8H5PATcJePUw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR10MB7937
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 22 Nov 2023 05:35:16 -0800 (PST)

On 22/11/2023 14.01, Frieder Schrempf wrote:
> On 22.11.23 09:03, Rasmus Villemoes wrote:
>> On 21/11/2023 21.49, Eberhard Stoll wrote:

>>> But IMHO there is one next issue with this situation: When the port
>>> operates with WAIT_AFTER_RTS and WAIT_AFTER_SEND then some timers
>>> for callback functions might be active. I did not discover where they
>>> are stopped for the case when the serial port is closed. Maybe stopping
>>> is not required ...
>>
>> Indeed, that's an extra complication. Adding two hrtimer_try_to_cancel()
>> in shutdown would probably not hurt, along with setting tx_state OFF.
>>
>> I wonder if at least mode switching should simply be disallowed (-EBUSY)
>> if tx_state is anything but OFF.
> 
> Is there a valid use-case for switching the mode while the device is
> transmitting? Is this something we need to support for whatever reason?
> It sounds rather an obscure thing to do.

No, I don't think there is, and that's not at all what I'm trying to do.
I was just thinking out loud that maybe we should explicitly disallow it
[further, in fact, if possible, it should be disallowed in the serial
core]. But of course that requires that ->tx_state can actually be
relied upon, which is what my patch attempts to do for the rs232 case -
though it might not be an entirely complete fix, as described by
Eberhard, since we can get to ->shutdown and thus disable the TC
interrupt before it has a chance to fire.

Rasmus