Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp1098144rdf; Wed, 22 Nov 2023 05:43:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHPgAarWUWmS7b8BSHVpkZvYzfP+Z0MyZpJA2tkc1mJ6SG6WsfRHHc+EbxTvzJYaZtifwCI X-Received: by 2002:a05:6a20:bea2:b0:17f:d42e:202c with SMTP id gf34-20020a056a20bea200b0017fd42e202cmr1656559pzb.49.1700660597162; Wed, 22 Nov 2023 05:43:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700660597; cv=none; d=google.com; s=arc-20160816; b=G5ER2iHqyXZ4j7LEa/ZUGNoEPMlamrGoUPasYB3ml8Mh38os+ofQh9SWFOjYfOD32R YTnGIipEcNT5GoVXIxlJkfuzr5L4BQwzUyHsYeu0/qijrzkzNWCn8ueVIUZ0TFT3B/bS dkB4Xuc6eiLtC988GK//s1egzDFJHYuTNuRYa+6r9VGNQ0Xjfy5Ca+Vj8RKwPJQF58MZ mo0fyh7Y9o2bzrhdypOYvS2gI48j4W+HoCyRU3e9Ac5BfDm3jjZsVqTz3TuWF1TmAvpg wXJSzzP4g9BB3rPzKefTuQCbFIM4uJvlLEzoFlW5KA7IbRZaP5bHu/Y5C1GBUbqJ7qKD F+SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=9gGmYo4GGQsuh8hITKaYDqM8JQ11gZwcjahtThUAeRc=; fh=hEJbBCrjWn6WowRLqPjLbG4LhBOAypwbuW1YtMFWw7Y=; b=gBbeJFbDUKUAqhb2CdM8/BlVjRY+PgPykK1ieeEPLZI9kup2hQm47ABKboqktRmNGW X5qYlFydhgR7iBRjZk34CXQl5OY8sDI8QcjMPOWqQ3v2PjpYaCbcAUZYMaYMyAM74KiD OIKZj8bQ5ebszx5OTje0C7S4xMNKvhKVTa5wQ5YMehQdp4BROWt+juSZHyA8t56CcIOz +l6+Mke4saNl0ah7pWkeTaRhjeXmy5ORg5Tb/tGgrNoDw8wQPyKF6Xo47DmsZd3pBfgy D520T16nYLl8hN6nlVHpDT4FsPnJDIHBqYQaBiqF5AeAHcxykPab35KhHGv3qeKkjwnE LA0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=LbnwH9Mb; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=on5V3Px+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id y23-20020a056a00181700b006cb8489ce1csi7881441pfa.54.2023.11.22.05.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 05:43:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=LbnwH9Mb; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=on5V3Px+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 38237807FCD2; Wed, 22 Nov 2023 05:40:56 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231410AbjKVNkr (ORCPT + 99 others); Wed, 22 Nov 2023 08:40:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231345AbjKVNkq (ORCPT ); Wed, 22 Nov 2023 08:40:46 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30C5C197; Wed, 22 Nov 2023 05:40:42 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ABCC721982; Wed, 22 Nov 2023 13:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700660440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9gGmYo4GGQsuh8hITKaYDqM8JQ11gZwcjahtThUAeRc=; b=LbnwH9MbFIfOuDeb1eRHuAMvU5J0CN+a3X/ksA23uS0fMnjjMFlPv4FsZ2ETJOtdhR83t/ MkCCqZbeKeHsq4NufrXo+YLm/G8m4Oc/YF30bMd6SozRhd+phwLKU/WNXove7nK9wxoFf+ kVhN/JkvRm5dGLysAt22o6afz9H/2rI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700660440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9gGmYo4GGQsuh8hITKaYDqM8JQ11gZwcjahtThUAeRc=; b=on5V3Px+T1NwJyLID7d2FpzVAbVvPuy9aWL2FZsbKjiLCvsGxMf3KmEw7uza6tX4OjmULy bhWnF7x1N4awNVCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8FBAE13467; Wed, 22 Nov 2023 13:40:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vP7KItgEXmVicAAAMHmgww (envelope-from ); Wed, 22 Nov 2023 13:40:40 +0000 Date: Wed, 22 Nov 2023 14:40:40 +0100 Message-ID: <87pm013nzb.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , , Subject: Re: [PATCH] ALSA: hda: cs35l56: Enable low-power hibernation mode on SPI In-Reply-To: <1528da8b-4ca3-4f12-be17-a3222039fa20@opensource.cirrus.com> References: <20231121154419.19435-1-rf@opensource.cirrus.com> <87h6lealos.wl-tiwai@suse.de> <1528da8b-4ca3-4f12-be17-a3222039fa20@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -4.53 X-Spamd-Result: default: False [-4.53 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; RCPT_COUNT_FIVE(0.00)[6]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.23)[72.66%] X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 22 Nov 2023 05:40:56 -0800 (PST) On Wed, 22 Nov 2023 12:04:27 +0100, Richard Fitzgerald wrote: > > On 21/11/23 20:36, Takashi Iwai wrote: > > On Tue, 21 Nov 2023 16:44:19 +0100, > > Richard Fitzgerald wrote: > >> > >> SPI hibernation is now supported with the latest hibernation/wake > >> sequences in the shared ASoC code. > >> > >> This has a functional dependency on two commits: > >> > >> commit 3df761bdbc8b ("ASoC: cs35l56: Wake transactions need to be issued > >> twice") > >> > >> commit a47cf4dac7dc ("ASoC: cs35l56: Change hibernate sequence to use > >> allow auto hibernate") > >> > >> To protect against this, enabling hibernation is conditional on > >> CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new > >> hibernation sequences are available. > >> > >> Signed-off-by: Richard Fitzgerald > > > > Is this expected to be merged for 6.7? Or it can be post 6.7? > > I guess the former, but just to make sure. > > > > It would be good to get it into 6.7 because it reduces the power > consumption in runtime-suspend and suspend-to-RAM. But it's not > critical (it's not a bugfix). OK, now applied to for-linus branch (for 6.7). thanks, Takashi