Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 22 Nov 2023 15:02:47 +0100
From:   Mehdi Djait <mehdi.djait@bootlin.com>
To:     Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc:     Michael Riesch <michael.riesch@wolfvision.net>,
        Tommaso Merciai <tomm.merciai@gmail.com>, mchehab@kernel.org,
        heiko@sntech.de, hverkuil-cisco@xs4all.nl,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        conor+dt@kernel.org, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com,
        maxime.chevallier@bootlin.com
Subject: Re: [PATCH v11 2/3] media: rockchip: Add a driver for Rockchip's
 camera interface
Message-ID: <ZV4KB7/TO66if41o@pc-70.home>
References: <cover.1700132457.git.mehdi.djait@bootlin.com>
 <db605935ad21c4780b73db87605b52d30bc936a4.1700132457.git.mehdi.djait@bootlin.com>
 <ZVz58b0r4gtxyVQy@tom-HP-ZBook-Fury-15-G7-Mobile-Workstation>
 <9570dc1c-a437-46d4-95e7-1f3dd399e458@wolfvision.net>
 <ZV3_xe6A0v7kKgmo@aptenodytes>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZV3_xe6A0v7kKgmo@aptenodytes>
Precedence: bulk

Hello everyone,

> > >>  create mode 100644 drivers/media/platform/rockchip/cif/Kconfig
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/Makefile
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/capture.c
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/capture.h
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/common.h
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/dev.c
> > >>  create mode 100644 drivers/media/platform/rockchip/cif/regs.h
> > > 
> > > Just a logigistic comment on my side for now, sorry :)
> > > What about use cif-* prefix in front of driver files?
> > > 
> > > like:
> > > 
> > > cif-capture.c
> > > cif-capture.h
> > > cif-common.h
> > > cif-dev.c
> > > cif-regs.h
> > 
> > What would be the rationale here?
> > 
> > IMHO the files are in a folder named cif, so adding this prefix seems
> > kind of redundant.
> > 
> > That said, if there is a good reason I could live with cif-*.{c,h} as
> > well, of course. My only request would be to agree on something ASAP.
> 
> It's rather common to do that in Linux and one advantage is that it makes it
> clear in your text editor which driver you are looking at when only the file
> name is shown.
> 
> I don't have any strong opinion on this either though.

I see that the majority of the drivers are named like suggested. I will
change the names in the V12.

--
Kind Regards
Mehdi Djait