Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 22 Nov 2023 16:19:55 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     =?utf-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
        Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@tuxon.dev>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        UNGLinuxDriver@microchip.com, Simon Horman <horms@kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org,
        Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time
 stamping layer be selectable
Message-ID: <20231122141955.vx6gb4a47jr3bhal@skbuf>
References: <20231120093723.4d88fb2a@kernel.org>
 <20231120190023.ymog4yb2hcydhmua@skbuf>
 <20231120115839.74ee5492@kernel.org>
 <20231120211759.j5uvijsrgt2jqtwx@skbuf>
 <20231120133737.70dde657@kernel.org>
 <20231120220549.cvsz2ni3wj7mcukh@skbuf>
 <20231121183114.727fb6d7@kmaincent-XPS-13-7390>
 <20231121094354.635ee8cd@kernel.org>
 <20231122144453.5eb0382f@kmaincent-XPS-13-7390>
 <20231122140850.li2mvf6tpo3f2fhh@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231122140850.li2mvf6tpo3f2fhh@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o8UrAe0maRwumCphx2MijaFhWOBogc7fPw/j/72JwGA9ToLE2cKEwELqmjsz?=
 =?us-ascii?Q?MuaygJMRzg2HqkYAbTP22/QfAY1KQK6EFIorsgH5Pv5NNFctohz4ZKNzpDy3?=
 =?us-ascii?Q?PHHbnjXkBMqTXC11KSY1D2Isw48fdJ/OQdV252GBps9M+siaKlF3Zze/9+XH?=
 =?us-ascii?Q?8/T0B/6noIjSm/EhjdqZ49LThogFltxsbHoCR+BS1EFUh9iBLW7ox6LlK8Gf?=
 =?us-ascii?Q?Kr6z0luVAKQoVL5gJZmd1HgbRFURh8rbzvtwDGkrHk0jiIOkei3x1XPA/UTh?=
 =?us-ascii?Q?HkHNWttzMgrsIY/Lxy3Cbt6+ZNMYFs+a7gu5PvbNnUrEw7c6znmTFmX+npQI?=
 =?us-ascii?Q?VhQL4w5Rqh++tB2U7GY7U33EcYtGa9ULG5vigBIZYLLrVDPbRpfdNu1qYr4C?=
 =?us-ascii?Q?theRrF1buncb08b6rp+0j5EVzZ33yUh5D48VOtvlkDECXXyjzErEEuEHksZE?=
 =?us-ascii?Q?iz+ZGp/krBEaJZG6eeHs8mcFfqFmaPQx+Sw1HONmkD6cwzoe4vfDN0p4uCSh?=
 =?us-ascii?Q?Sp6P1V1eI1833GgcqUvMelq6f9mPwdfDOsNaIHngIlELkp7ebX9Q5rul5W/k?=
 =?us-ascii?Q?MZZgAoAbsOcfyRsIy5EUSHy6DwOLTMUBbw39R87AjzNLM1492GQl4Ao6IRPw?=
 =?us-ascii?Q?eOIe+WPoEjTr/TqIsIoLhBQ+PdZpFGnld3PHXwQpQyRzprh6DveVoe0PBKku?=
 =?us-ascii?Q?u8Lex/sRmPYreF06lhPd89qj2s2jq+n/xb54GqxhVBN/Bv0ARueKJl87tAbO?=
 =?us-ascii?Q?zpPvzbFxVcdjf9uz0KqvgixqSlHygS4yMyf+Qhr2jRyh4t79y9zWm05b71NY?=
 =?us-ascii?Q?xl5NEQoIdHO5ImV//8IgOZ3bbEql4TG+X14jhyY2K5+2heu/QOOF/x2bZ4h5?=
 =?us-ascii?Q?0Lskartpgnbw4mIRyiErJtdKYw3s+ysH4bwy7AsafZ0LV2DLFaj1N7rC8cFl?=
 =?us-ascii?Q?rKYBgSgejwrgugOWP5M5bncFx1kXWDEMEW58Muwi2jKNr/Sj6vQjReIzdkO/?=
 =?us-ascii?Q?8vgXAOL8RUMgZAHFKrEoiFinqogHxYA/VqZ9KqKkFlmRY1TcHyfd2DvD/RXh?=
 =?us-ascii?Q?lzk0+UrEuU2QqpinDArmnBADPZ574bpqW0c3YGK1Zjle3N2DvNluOongpW98?=
 =?us-ascii?Q?FlfiuZYzLyQZhtNWh+w8ZcdmuYe6NrnUZQBnvs0HVN24o3RFxrHqCm7H6oRO?=
 =?us-ascii?Q?Ext7z2i+qeh2E+xvflftXmZDGV95xVpYLb92kgfsjPZnkwkZVB18fBVBt5TB?=
 =?us-ascii?Q?QPHiL02NCuxrHH30fiwltRR+uJ9U74iu2lAwVkPANKxl7B+smtZYwUDq5aZq?=
 =?us-ascii?Q?uiQlYJGXSUjXSsrgnfNsxo1gymEFdIPd89v0aAX4bW8iGOznMKU20QAX89hv?=
 =?us-ascii?Q?sAPGDiGZjDRoqRxVjN3hp0CckiR2zbPbJYIehqhk9BSO2IfQVvkeZalGrLUM?=
 =?us-ascii?Q?QhHDVqJx0FTPbKwpqBw2/CVz2lcUxl4k+D9nVGwLo1ix1VonDqLZ+JCuewLi?=
 =?us-ascii?Q?LptY8XWh8/xFmESnabeDYpYGA9LGnavO4wrU6DDs1pdpNoBAzU5JiFJlJzbc?=
 =?us-ascii?Q?1bcUlEx2Wm8SMMHDl+kqqSYBW+7OrqMr3ObqwHQiQvkEaDx//HgeQxMX4EkQ?=
 =?us-ascii?Q?qg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 008e5905-e3dc-4513-6f63-08dbeb661c99
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 14:20:00.5450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6UC3L/3ERzRLCyTWvbBVlQFgRhh9lu6qGEEXLzd2aZ2T+XwXNAktD5AbP+Ska90LXCT+5r3Szje1bXkJ3BdkbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8893
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 22 Nov 2023 06:20:12 -0800 (PST)

On Wed, Nov 22, 2023 at 04:08:50PM +0200, Vladimir Oltean wrote:
> The concept of an "active phc_index" would not explicitly exist in the
> UAPI. Thus I'm not sure what's with this TSINFO_SET being floated around.
> The only thing would exist is a configurable rx_filter and tx_type per
> hwtstamp provider (aka "{phc_index, qualifier}"). User space will have
> to learn to select the hwtstamp provider it wants to configure through
> netlink, and use for its class of traffic.

One clarification: the extended timestamping filters are PER NETDEV
(in addition to being per one of the hwtstamp providers listed for that
netdev). This was understated from the fact that the netlink interface
itself targets a netdev, but I didn't say it explicitly.