Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Wed, 22 Nov 2023 16:36:18 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     =?utf-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
        Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@tuxon.dev>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        UNGLinuxDriver@microchip.com, Simon Horman <horms@kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org,
        Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time
 stamping layer be selectable
Message-ID: <20231122143618.cqyb45po7bon2xzg@skbuf>
References: <20231120093723.4d88fb2a@kernel.org>
 <20231120190023.ymog4yb2hcydhmua@skbuf>
 <20231120115839.74ee5492@kernel.org>
 <20231120211759.j5uvijsrgt2jqtwx@skbuf>
 <20231120133737.70dde657@kernel.org>
 <20231120220549.cvsz2ni3wj7mcukh@skbuf>
 <20231121183114.727fb6d7@kmaincent-XPS-13-7390>
 <20231121094354.635ee8cd@kernel.org>
 <20231122144453.5eb0382f@kmaincent-XPS-13-7390>
 <20231122140850.li2mvf6tpo3f2fhh@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231122140850.li2mvf6tpo3f2fhh@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rOabux9UycFeWONqiGe4ylLVp44WGFRcGHKaCpJKgdriHL3ph0IWYLwZ5HTg?=
 =?us-ascii?Q?0x7zXyAyyxYC5kEvD0htEuxjfRHXJzHf4OcJxrwtwMWRpwnDSsXX1vPFAba6?=
 =?us-ascii?Q?2XejtRULfdsbBl8/82gwJYjnjRIdCSeilIi+6bpLNRe7rmNVW5+Q7XVQ+QW4?=
 =?us-ascii?Q?BcJyuVm7TCyjAK/Xv6/oqGhhni6bie2y0xE1XnXZMbbp6Rl2gk6euO8qOu9b?=
 =?us-ascii?Q?/pP8cHGH4BjgfE/HydvrXm8YckIo2LIoG5lQrCMOC3IZ35ulZNvKpuvypehn?=
 =?us-ascii?Q?MxyS6lIQpzladffCa9fgHhooUX1KMCMJceuVQeaERd9m1OvUrCDB8QtrtwoW?=
 =?us-ascii?Q?hkwPHWhV98ueOZzvzMMl5dsfI8mZZ6bJsq/IapFIIhFJ8EDw4M00V1lNX5P7?=
 =?us-ascii?Q?D6ghSuUUScZImlCgp/arMNbcFWkIgl+xdg8Ks9QPrw97VsyAM98laJEFUwco?=
 =?us-ascii?Q?DmDzHRsi1y8MOJW/a2VL3dc3hjWLl1akPA55QkMwX7v7/5Dlg/O+riMpK23D?=
 =?us-ascii?Q?/Py3DZPlkQ61HeTZuddqQ4HiQhfl5dorLs3gP2FqiF4xZjBGB/Zb/scCtVML?=
 =?us-ascii?Q?35IR/BugYkHbHjyab62SbRBKjwk6vTc41eLhElY1PCUC8YXCe3tDr6VpdqVq?=
 =?us-ascii?Q?pSHTa0iQNR3M/L7pGdjmOFB4p+BkQIm+s8Ihpc1FKWq1hnToAp1FhZ2WmFVv?=
 =?us-ascii?Q?iNDGx9wIfvPSQWDvvn37kNOxJKGrkkrDg10un6YYwPobj5PbzzBwTwXJWgLT?=
 =?us-ascii?Q?mDmEQOUw9VHJzVsp5eIDG6+hwt8Cmc3vHAa/bgLCzgvdzZguo1ysoRtwXHBB?=
 =?us-ascii?Q?mB7cQd91ZMV3a5PC/4sKwfkgdd4eWW7pAVK9O/Mxd+NwCGSKzl42duuj+myg?=
 =?us-ascii?Q?RGj0EcP87n/xsHu9nNkSwwWe+0np3w0dXCxNR9ASosUcHmHe2g6onwcWjYA6?=
 =?us-ascii?Q?FJ5v2TJWuTTQp4fwgybyCD1d5zD5hJDlwlVU5fLB2IahGlnGQURdMUdScnUp?=
 =?us-ascii?Q?1HfV4jnTB2uex0zJK5p8M8B9i6O7GhGOYC2eBzHTiSzlK6WgZ4unJA2Zd/E+?=
 =?us-ascii?Q?ikVOzMakz7uLvWbAc2+0ZtRpQtSX6/OyrlKofE2dH4sLiF8L8E8CTojM7Wdg?=
 =?us-ascii?Q?w+xJ1tV19xCPeixBa8lzUNqaFwiJr597/DB1/98lWe5iaBghk7lRDCBICbdE?=
 =?us-ascii?Q?sLytabVbt3OXhOQE/tm/iwuhif1s3BiBkamjVq6+qo3pUXYcWSCJhZV0q8gj?=
 =?us-ascii?Q?VRwpSYwQwqLje08sPE5JlDIz2l5z1fNSMST1R0CY8JD+C9OfZQLngVjb6ICp?=
 =?us-ascii?Q?2zVpdm9VKxC40Z4OgWpL1UcjwnMh0jJa644Qh2UjbJS80DdulHG0XGVizW/0?=
 =?us-ascii?Q?JT9nwYFQ5Dp9t5emkRin8lW0CVHQy338JDgIGWab+IeE7u7DvWEPI2aQwQjl?=
 =?us-ascii?Q?ZeH7fokIpegShhtoiH2jk+e6BaJABtamFMbKBmUR3OMeg118e9YAZsp04oaq?=
 =?us-ascii?Q?iXNI8hAKl+j219J7b0l0+PZ2jyDTQFGDf2ihF7ehuykG75gYjlsmfaRxoZwM?=
 =?us-ascii?Q?LoyM4NTr0O2/nU/65IPv57Lu2NE2SQBim3si9JrIy7FTBJV/cQVrXVDPdgur?=
 =?us-ascii?Q?6g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe5d6e82-d157-41b4-b00f-08dbeb68663e
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 14:36:22.8936
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TMbuoro59UvgBDqFGmY9CR0zQFyl0nAYJcxGSFLG8isIvNW8h7Y3cb6TesBTaR6nLnfMGRbhZpkDPkG7VPFsuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8559
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 22 Nov 2023 06:36:34 -0800 (PST)

On Wed, Nov 22, 2023 at 04:08:50PM +0200, Vladimir Oltean wrote:
> The concept of an "active phc_index" would not explicitly exist in the
> UAPI. Thus I'm not sure what's with this TSINFO_SET being floated around.
> The only thing would exist is a configurable rx_filter and tx_type per
> hwtstamp provider (aka "{phc_index, qualifier}"). User space will have
> to learn to select the hwtstamp provider it wants to configure through
> netlink, and use for its class of traffic.

@Jakub, for your long-term "MAC timestamps for PTP, DMA for everything else".
How do you see this? I guess we need some sort of priority function in
the UAPI between hwtstamp providers.

And even with that, I think the enums that we currently have for filters
are not specific enough. The most we could expose is:

                      MAC provider                      DMA provider

hwtstamp_rx_filters   HWTSTAMP_FILTER_PTP_V2_EVENT      HWTSTAMP_FILTER_ALL
tx_type               HWTSTAMP_TX_ON                    HWTSTAMP_TX_ON

but it isn't clear: for PTP, does the DMA provider give you an RX
timestamp too? What about a TX timestamp?